taskotron.yaml: provide a default value for fas_password
ClosedPublic
Actions

Authored by kparal on Jul 9 2015, 8:26 AM.

Details

Reviewers

tflink
mkrizek
jskladan

Maniphest Tasks

T523: Simplify set up of Taskotron development environment

Commits

rLTRN17979b95f578: taskotron.yaml: provide a default value for fas_password

Summary

When testing Bodhi code with fake_fedorainfra, some FAS password must be
provided (can't be empty), the bodhi API does not allow it. Providing
some (any non-empty) value makes it easier for the developer - one less
option to configure, one less problem to debug in case he forgets. This
does not affect regular dev workflow (without custom Bodhi) in any way,
and in production it has to be configured anyway.

Test Plan

test suite works, and you no longer need to edit config file
when using fake_fedorainfra

Diff Detail

Repository

rLTRN libtaskotron

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kparal retitled this revision from to taskotron.yaml: provide a default value for fas_password.Jul 9 2015, 8:26 AM

kparal updated this object.

kparal edited the test plan for this revision. (Show Details)

kparal added reviewers: mkrizek, jskladan, tflink.

kparal added a task: T523: Simplify set up of Taskotron development environment.

Herald added a subscriber: tflink. · View Herald TranscriptJul 9 2015, 8:26 AM

mkrizek accepted this revision.Jul 9 2015, 11:43 AM

This revision is now accepted and ready to land.Jul 9 2015, 11:43 AM

kparal added a dependent revision: D424: Simplify setting up development instance.Jul 9 2015, 12:04 PM

jskladan accepted this revision.Jul 10 2015, 6:35 AM

Closed by commit rLTRN17979b95f578: taskotron.yaml: provide a default value for fas_password (authored by kparal). · Explain WhyJul 10 2015, 9:22 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

			Path	Packages
M			conf/taskotron.yaml.example (2 lines)
M			libtaskotron/config_defaults.py (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1116	93e5ae3		Jul 9 2015, 8:26 AM	★	★
Diff 2	1130	93e5ae3	Commit rLTRN17979b95f5781dfa13a5ee9c74d7eb36c8d4b189	Jul 10 2015, 9:20 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
6cd078668fde	e7b8ad0c0b01	93e5ae393e2a	Kamil Páral	taskotron.yaml: provide a default value for fas_password (Show More…)	Jul 3 2015, 3:55 PM

	Status	Author	Revision
	Closed	kparal	D424 Simplify setting up development instance
	Closed	kparal	D423 taskotron.yaml: provide a default value for fas_password

Diff 1130

View Options

conf/taskotron.yaml.example

Show First 20 Lines • Show All 135 Lines • ▼ Show 20 Line(s)
136		136
137	## ==== SECRETS section ====	137	## ==== SECRETS section ====
138	## All login credentials and other secrets are here. If you add some secret	138	## All login credentials and other secrets are here. If you add some secret
139	## here, make sure you make this file readable just for the right user accounts.	139	## here, make sure you make this file readable just for the right user accounts.
140		140
141	## FAS (Fedora Accounts System) credentials	141	## FAS (Fedora Accounts System) credentials
142	## These credentials are used when reporting results into Bodhi.	142	## These credentials are used when reporting results into Bodhi.
143	#fas_username: taskotron	143	#fas_username: taskotron
144	#fas_password: ''	144	#fas_password: password