Differential D41

remove yamlish.py and tap.py, we can now use pypi versions
ClosedPublic
Actions

Authored by garretraziel on Apr 3 2014, 8:50 AM.

Details

Reviewers
kparal
tflink
jskladan
Maniphest Tasks
T100: bayeux library does not define a dependency on yamlish
T101: replace tap.py and yamlish.py with PyPI libraries
Commits
rLTRNaffa32d15db1: remove yamlish.py and tap.py, we can now use pypi versions
Summary

yamlish and bayeux (tap.py) were updated so that now they can
be installed from pypi using requirements.txt.

Test Plan

py.test --functional should run as usual.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
kparal accepted this revision.Apr 3 2014, 9:17 AM

Seems to work well!

Before committing, please make sure we haven't done any local changes to tap.py or yamlish.py.

garretraziel closed this revision.Apr 3 2014, 9:52 AM

Closed by commit rLTRNaffa32d15db1 (authored by Garret Raziel <boloomka@gmail.com>).

ralph added a comment.Apr 3 2014, 1:25 PM

Yeah, looks good.

Revision Contents

Path
Mlibtaskotron/check.py (3 lines)
DMlibtaskotron/tap.py (90 lines)
DMlibtaskotron/yamlish.py (210 lines)
Mrequirements.txt (6 lines)

Diff 110

View Options

libtaskotron/check.py

1# -*- coding: utf-8 -*- 1​# -*- coding: utf-8 -*-
2# Copyright 2014, Red Hat, Inc. 2​# Copyright 2014, Red Hat, Inc.
3# License: GNU General Public License version 2 or later 3​# License: GNU General Public License version 2 or later
4 4​
5'''Helper tools for managing check status, outcome, and output.''' 5​'''Helper tools for managing check status, outcome, and output.'''
6 6​
7import pprint 7​import pprint
8 8​
9​import tap
10​
9from . import python_utils 11​from . import python_utils
10from . import exceptions as exc 12​from . import exceptions as exc
11from . import tap ​
12 13​
13 14​
14class CheckDetail(object): 15​class CheckDetail(object):
15 '''Class encompassing everything related to the outcome of a check run. 16​ '''Class encompassing everything related to the outcome of a check run.
16 It contains convenience methods for tracking, evaluating and reporting 17​ It contains convenience methods for tracking, evaluating and reporting
17 check results. 18​ check results.
18 19​
19 For some checks, it's trivial to parse its output at the end of its 20​ For some checks, it's trivial to parse its output at the end of its
▲ Show 20 Lines • Show All 278 Lines • Show Last 20 Lines
View Options

libtaskotron/tap.py

  • This file was deleted.
This file was completely deleted. Show File Contents
View Options

libtaskotron/yamlish.py

  • This file was deleted.
This file was completely deleted. Show File Contents
View Options

requirements.txt

1PyYAML==3.10 1​PyYAML==3.10
2dingus==0.3.4 2​dingus==0.3.4
3py>=1.4.18 3​py>=1.4.18
4pyaml==13.07.1 4​pyaml==13.07.1
5pytest>=2.4.2 5​pytest>=2.4.2
6pytest-cov>=1.6 6​pytest-cov>=1.6
7jinja2>=2.7.2 7​jinja2>=2.7.2
8 8​bayeux>=0.8
9# these are bundled in libtaskotron for now 9​yamlish>=0.11
10#bayeux==0.7 ​
11#yamlish==0.10 ​