Differential D406

generate rpmlint log as an artifact
ClosedPublic
Actions

Authored by kparal on Jun 23 2015, 1:58 PM.

Details

Reviewers
tflink
mkrizek
jskladan
Maniphest Tasks
T399: Feature: Task Artifacts
Commits
rRPMLINT6544cde356e6: generate rpmlint log as an artifact
Summary

This will point people directly to an rpmlint output with no extra
buildbot information around.

Add basic logging and adjust subprocess invocation to allow capturing
and printing the output at the same time.

Test Plan

I tested it manually, it saves the file correctly and includes the path in TAP.

Diff Detail

Repository
rRPMLINT task-rpmlint
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kparal retitled this revision from to generate rpmlint log as an artifact.Jun 23 2015, 1:58 PM
kparal updated this object.
kparal added a task: T470: allow checks to provide URLs for their specific per-build/update logs from artifactsdir.
kparal edited the test plan for this revision. (Show Details)
kparal added reviewers: tflink, jskladan, mkrizek.
tflink accepted this revision.Jun 25 2015, 4:24 PM

Looks good to me, just make sure it's pushed to develop instead of master until we get all the reqired bits deployed

This revision is now accepted and ready to land.Jun 25 2015, 4:24 PM
Closed by commit rRPMLINT6544cde356e6: generate rpmlint log as an artifact (authored by kparal). · Explain WhyJun 29 2015, 12:38 PM
This revision was automatically updated to reflect the committed changes.
kparal added a comment.Jun 29 2015, 12:39 PM

Good call. I have created develop branch for rpmlint and set it as default.

Revision Contents

PathPackages
Mrpmlint.yml (1 line)
Mrun_rpmlint.py (69 lines)

Diff 1080

View Options

rpmlint.yml

Show All 19 Lines16 koji:
20 src: True 20​ src: True
21 21​
22 - name: run rpmlint on downloaded rpms 22​ - name: run rpmlint on downloaded rpms
23 python: 23​ python:
24 file: run_rpmlint.py 24​ file: run_rpmlint.py
25 callable: run 25​ callable: run
26 workdir: ${workdir} 26​ workdir: ${workdir}
27 koji_build: ${koji_build} 27​ koji_build: ${koji_build}
28​ artifactsdir: ${artifactsdir}
28 export: rpmlint_output 29​ export: rpmlint_output
29 30​
30 - name: report results to resultsdb 31​ - name: report results to resultsdb
31 resultsdb: 32​ resultsdb:
32 results: ${rpmlint_output} 33​ results: ${rpmlint_output}
33 34​
View Options

run_rpmlint.py

1​import logging
2​if __name__ == '__main__':
3​ # Set up logging ASAP to see potential problems during import.
4​ # Don't set it up when not running as the main script, someone else handles
5​ # that then.
6​ logging.basicConfig()
7​
1import subprocess 8​import subprocess
2import os 9​import os
10​import sys
11​
3from libtaskotron import check 12​from libtaskotron import check
4 13​
5def run(koji_build, workdir = u'.'): 14​log = logging.getLogger('rpmlint')
6 retcode = subprocess.call(['rpmlint', '%s' % os.path.abspath(workdir)]) 15​log.setLevel(logging.DEBUG)
16​log.addHandler(logging.NullHandler())
17​
18​
19​def run(koji_build, workdir='.', artifactsdir='artifacts'):
20​ '''The main method to run from Taskotron'''
21​
22​ if not os.path.exists(artifactsdir):
23​ os.makedirs(artifactsdir)
24​
25​ command = ['rpmlint', '%s' % os.path.abspath(workdir)]
7 26​
8 if retcode == 0: 27​ # run rpmlint
28​ log.debug('Running command: %s', command)
29​ proc = subprocess.Popen(command, stdout=subprocess.PIPE,
30​ stderr=subprocess.STDOUT, bufsize=1,
31​ close_fds=True)
32​ output = []
33​ for line in iter(proc.stdout.readline, ''):
34​ print line,
35​ output.append(line)
36​ stdout, stderr = proc.communicate()
37​
38​ # stdout and stderr should be empty, because we printed them out
39​ # before calling .communicate()
40​ if stdout or stderr:
41​ log.warn("Extra stdout or stderr found, this shouldn't happen:")
42​ print 'STDOUT:\n%s' % stdout
43​ print >> sys.stderr, 'STDERR:\n%s' % stderr
44​ output.append(stdout)
45​ output.append(stderr)
46​
47​ if proc.returncode == 0:
9 result = 'PASSED' 48​ result = 'PASSED'
10 else: 49​ else:
11 if retcode == 64 or retcode == 66: 50​ if proc.returncode == 64 or proc.returncode == 66:
12 result = 'FAILED' 51​ result = 'FAILED'
13 else: 52​ else:
14 result = 'ABORTED' 53​ result = 'ABORTED'
15 54​
16 summary = 'rpmlint %s for %s' % (result, koji_build) 55​ summary = 'rpmlint %s for %s' % (result, koji_build)
56​ log.info(summary)
57​
17 detail = check.CheckDetail(koji_build, check.ReportType.KOJI_BUILD, 58​ detail = check.CheckDetail(koji_build, check.ReportType.KOJI_BUILD,
18 result, summary) 59​ result, summary)
19 60​
20 tapdetail = check.export_TAP(detail, checkname='rpmlint') 61​ # store logs
21 return tapdetail 62​ log_path = os.path.join(artifactsdir, '%s.log' % koji_build)
63​ log.debug('Saving log to: %s', log_path)
64​ with open(log_path, 'w') as log_file:
65​ log_file.writelines(output)
66​ detail.artifact = log_path
67​
68​ tap = check.export_TAP(detail, checkname='rpmlint')
69​ return tap
22 70​
23if __name__ == '__main__': ​
24 tapout = run() ​
25 71​
26 for result in tapout: 72​if __name__ == '__main__':
27 print result 73​ tap = run('local-run')
74​ print tap