typo fix
ClosedPublic
Actions

Authored by adamwill on Jun 10 2015, 5:43 PM.

Details

Reviewers

kparal
garretraziel

Commits

rOPENQA2014df51780d: typo fix

Summary

Wrong brace used for a str.format() call - caused a crash when
no universal test image is found for a compose.

Test Plan

Check that tests still run. Ideally try testing a compose with
no universal image (e.g. a Rawhide nightly with no boot.iso).

Repository

rOPENQA fedora_openqa

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

adamwill retitled this revision from to typo fix.Jun 10 2015, 5:43 PM

adamwill updated this object.

adamwill edited the test plan for this revision. (Show Details)

This revision is now accepted and ready to land.Jun 11 2015, 8:13 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			tools/openqa_trigger/openqa_trigger.py (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1023	a2bb9f4		Jun 10 2015, 5:43 PM	★	★
Diff 2	1032	a2bb9f4	Commit rOPENQA2014df51780d7af57b91c99b013ed6b7b277b043	Jun 11 2015, 5:00 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
60069a2c00aa	218d7958ae02	a2bb9f428c7f	Adam Williamson	typo fix (Show More…)	Jun 10 2015, 5:41 PM

Show First 20 Lines • Show All 156 Lines • ▼ Show 20 Line(s)		150	for img in okimgs:
157	elif img.payload == 'server':	157		elif img.payload == 'server':
158	score += 3	158		score += 3
159	elif img.payload == 'workstation':	159		elif img.payload == 'workstation':
160	score += 1	160		score += 1
161	if score > bestscore:	161		if score > bestscore:
162	bestimg = img	162		bestimg = img
163	bestscore = score	163		bestscore = score
164	if not bestimg:	164		if not bestimg:
165	print("No universal tests image found for {0)!".format(arch))	165		print("No universal tests image found for {0}!".format(arch))
166	continue	166		continue
167	print("Running universal tests for {0} with {1}!".format(	167		print("Running universal tests for {0} with {1}!".format(
168	arch, bestimg.desc))	168		arch, bestimg.desc))
169	isoname = download_image(bestimg)	169		isoname = download_image(bestimg)
170	job_ids = run_openqa_jobs(isoname, 'universal', arch, build)	170		job_ids = run_openqa_jobs(isoname, 'universal', arch, build)
171	jobs.extend(job_ids)	171		jobs.extend(job_ids)
172		172
173	# Now schedule per-image jobs.	173		# Now schedule per-image jobs.
▲ Show 20 Lines • Show All 156 Lines • Show Last 20 Lines