Allow koji directive to download debug info
ClosedPublic
Actions

Authored by mkrizek on Jun 7 2015, 9:17 AM.

Details

Reviewers

kparal
tflink
jskladan

Maniphest Tasks

T494: extend koji directive to allow downloading of debug info

Commits

rLTRN20f226dfb1b9: Allow koji directive to download debug info

Test Plan

Tests amended. Run rpmlint with debuginfo: True. Worked on my machine.

Diff Detail

Repository

rLTRN libtaskotron

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mkrizek retitled this revision from to Allow koji directive to download debug info.Jun 7 2015, 9:17 AM

mkrizek updated this object.

mkrizek edited the test plan for this revision. (Show Details)

mkrizek added reviewers: tflink, kparal, jskladan.

Herald added a subscriber: tflink. · View Herald TranscriptJun 7 2015, 9:17 AM

mkrizek added a task: T494: extend koji directive to allow downloading of debug info.Jun 7 2015, 9:17 AM

Looks good. I haven't tried to run it.

This revision is now accepted and ready to land.Jun 8 2015, 12:38 PM

looks good to me - lint errors are OK by me, can see why you did it that way. tried code with rpmlint locally, downloaded debuginfo.

Closed by commit rLTRN20f226dfb1b9: Allow koji directive to download debug info (authored by mkrizek). · Explain WhyJun 9 2015, 8:16 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

			Path	Packages
M			libtaskotron/directives/koji_directive.py (11 lines)
M			testing/test_koji_directive.py (19 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1019	612ad44		Jun 7 2015, 9:16 AM	★	★
Diff 2	1020	612ad44	Commit rLTRN20f226dfb1b9e0aca7a347bd139d8be987cef2db	Jun 9 2015, 7:54 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
69c6d9539e0c	ed22254dba3c	612ad442aa09	Martin Krizek	Allow koji directive to download debug info (Show More…)	Jun 7 2015, 9:14 AM

Diff 1020

View Options

libtaskotron/directives/koji_directive.py

Show All 40 Lines		40	description: \|
41	name of a Koji tag to download all builds from. Only required when	41		name of a Koji tag to download all builds from. Only required when
42	``action="download_tag"``. Example: ``f20-updates-pending``	42		``action="download_tag"``. Example: ``f20-updates-pending``
43	type: str	43		type: str
44	src:	44		src:
45	required: false	45		required: false
46	description: download also ``src`` RPM files	46		description: download also ``src`` RPM files
47	type: bool	47		type: bool
48	default: False	48		default: False
		49		debuginfo:
		50		required: false
		51		description: download also ``debuginfo`` RPM files
		52		type: bool
		53		default: False
49	target_dir:	54		target_dir:
50	required: false	55		required: false
51	description: directory into which to download builds	56		description: directory into which to download builds
52	type: str	57		type: str
53	default: ${workdir}	58		default: ${workdir}
54	returns: \|	59		returns: \|
55	A dictionary containing following items:	60		A dictionary containing following items:
56		61
▲ Show 20 Lines • Show All 62 Lines • ▼ Show 20 Line(s)		122	if 'arch' not in input_data:
119	raise exc.TaskotronDirectiveError(	124		raise exc.TaskotronDirectiveError(
120	"The koji directive requires 'arch' as an argument. Detected "	125		"The koji directive requires 'arch' as an argument. Detected "
121	"arguments: %s" % detected_args)	126		"arguments: %s" % detected_args)
122		127
123	self.arches = input_data['arch']	128		self.arches = input_data['arch']
124	if self.arches and ('noarch' not in self.arches):	129		if self.arches and ('noarch' not in self.arches):
125	self.arches.append('noarch')	130		self.arches.append('noarch')
126		131
		132		self.debuginfo = input_data.get('debuginfo', False)
		133
127	self.src = input_data.get('src', False)	134		self.src = input_data.get('src', False)
128		135
129	# download files	136		# download files
130	output_data = {}	137		output_data = {}
131		138
132	if action == 'download':	139		if action == 'download':
133	if 'koji_build' not in input_data:	140		if 'koji_build' not in input_data:
134	detected_args = ', '.join(input_data.keys())	141		detected_args = ', '.join(input_data.keys())
135	raise exc.TaskotronDirectiveError(	142		raise exc.TaskotronDirectiveError(
136	"The koji directive requires 'koji_build' for the 'download' "	143		"The koji directive requires 'koji_build' for the 'download' "
137	"action. Detected arguments: %s" % detected_args)	144		"action. Detected arguments: %s" % detected_args)
138		145
139	nvr = rpm_utils.rpmformat(input_data['koji_build'], 'nvr')	146		nvr = rpm_utils.rpmformat(input_data['koji_build'], 'nvr')
140		147
141	output_data['downloaded_rpms'] = self.koji.get_nvr_rpms(nvr,	148		output_data['downloaded_rpms'] = self.koji.get_nvr_rpms(nvr,
142	self.target_dir, arches=self.arches, src=self.src)	149		self.target_dir, arches=self.arches, debuginfo=self.debuginfo, src=self.src)
143		150
144	elif action == 'download_tag':	151		elif action == 'download_tag':
145	if 'koji_tag' not in input_data:	152		if 'koji_tag' not in input_data:
146	detected_args = ', '.join(input_data.keys())	153		detected_args = ', '.join(input_data.keys())
147	raise exc.TaskotronDirectiveError(	154		raise exc.TaskotronDirectiveError(
148	"The koji directive requires 'koji_tag' for the 'download_tag' "	155		"The koji directive requires 'koji_tag' for the 'download_tag' "
149	"action. Detected arguments: %s" % detected_args)	156		"action. Detected arguments: %s" % detected_args)
150		157
151	koji_tag = input_data['koji_tag']	158		koji_tag = input_data['koji_tag']
152		159
153	output_data['downloaded_rpms'] = self.koji.get_tagged_rpms(koji_tag,	160		output_data['downloaded_rpms'] = self.koji.get_tagged_rpms(koji_tag,
154	self.target_dir, arches=self.arches, src=self.src)	161		self.target_dir, arches=self.arches, debuginfo=self.debuginfo, src=self.src)
155		162
156	return output_data	163		return output_data