None
Details
- Reviewers
kparal tflink - Commits
- rTRGR89a92bd1227c: arcconfig: add correct project_id
The review itself :)
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Seems to work well! This review request, unlike D36, correctly says Arcanist Project: taskotron-trigger. But wait on @tflink for confirmation.
I think we should create taskotron-trigger project as well, so that people can subscribe to its tickets (and any tickets currently under libtaskotron can be moved there). Or do we want to have tickets for both libtaskotron and taskotron-trigger under taskotron project? I'm getting a bit dizzy from all those names :-)
Change looks good to me.
Seems to work well! This review request, unlike D36, correctly says Arcanist Project: taskotron-trigger. But wait on @tflink for confirmation.
Yeah, looks good to me.
I think we should create taskotron-trigger project as well, so that people can subscribe to its tickets (and any tickets currently under libtaskotron can be moved there). Or do we want to have tickets for both libtaskotron and taskotron-trigger under taskotron project? I'm getting a bit dizzy from all those names :-)
It makes enough sense to create the taskotron-trigger project, so I've created it.
We could always go the openstack or phabricator route and have tons of sub-project names which don't really indicate the purpose of the project. I was thinking about renaming all the taskotron components after card games: euchre, hearts, poker, solitare ... :)
I was thinking about renaming all the taskotron components after card games: euchre, hearts, poker, solitare ... :)
I think we should stick with some theme, so THeuchre, THearts, THoker Tholitaire... :)