Differential D362

ignore ABORTED, CRASHED results when posting bodhi comments. Fixes T467
ClosedPublic
Actions

Authored by tflink on Apr 30 2015, 8:42 PM.

Details

Reviewers
kparal
jskladan
Maniphest Tasks
T467: hide depcheck "inferior architecture" issue (T366) from the users
Commits
rLTRN15e6409627ff: ignore ABORTED, CRASHED results when posting bodhi comments. Fixes T467
Summary

The libtaskotron part of this change - ignores results with state of ABORTED or CRASHED when reporting to bodhi with comments

Test Plan

unit tests added

Diff Detail

Repository
rLTRN libtaskotron
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tflink retitled this revision from to ignore ABORTED, CRASHED results when posting bodhi comments. Fixes T467.Apr 30 2015, 8:42 PM
tflink updated this object.
tflink edited the test plan for this revision. (Show Details)
tflink added reviewers: jskladan, kparal.
jskladan accepted this revision.May 4 2015, 8:33 AM
This revision is now accepted and ready to land.May 4 2015, 8:33 AM
kparal accepted this revision.May 4 2015, 4:12 PM
kparal added a comment.May 5 2015, 7:56 AM

Just a side note, this will also resolve other issues like these:
https://admin.fedoraproject.org/updates/FEDORA-2015-4630/mpich-3.1.4-2.fc22
https://taskotron.fedoraproject.org/taskmaster//builders/x86_64/builds/67165/steps/runtask/logs/stdio

I was debugging this today and these are the problems:

  1. ABORTED result is posted to Bodhi -> will be fixed by this patch
  2. there is a crash in bodhi_comment_directive.py, because update is None, because the update got edited in the middle of the execution -> will be fixed by this patch, we will no longer reach that code. I consider that satisfactory solution.
  3. the result was not reported to ResultsDB -> should be fixed by @jskladan's D345.
Closed by commit rLTRN15e6409627ff: ignore ABORTED, CRASHED results when posting bodhi comments. Fixes T467 (authored by tflink). · Explain WhyMay 5 2015, 1:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 970

View Options

libtaskotron/directives/bodhi_comment_directive.py

Show First 20 Lines • Show All 433 Lines • ▼ Show 20 Line(s)433 if not update or not testname or not result or url == None:
434 log.error("bodhi_post_testresults() requires non-empty update, "\ 434​ log.error("bodhi_post_testresults() requires non-empty update, "\
435 "testname, result and url arguments.") 435​ "testname, result and url arguments.")
436 return False 436​ return False
437 437​
438 if not Config.fas_username or not Config.fas_password: 438​ if not Config.fas_username or not Config.fas_password:
439 log.error('Conf file containing FAS credentials is incomplete!') 439​ log.error('Conf file containing FAS credentials is incomplete!')
440 return False 440​ return False
441 441​
442​ if result in ['ABORTED', 'CRASHED']:
443​ log.debug("Results with outcome of CRASHED or ABORTED are not submitted"
444​ " to bodhi: %s %s" % (update, result))
445​ return True
446​
442 log.debug('Posting a result to Bodhi for: %s', update) 447​ log.debug('Posting a result to Bodhi for: %s', update)
443 448​
444 comment = 'Taskotron: %s test %s on %s. Result log: %s ' \ 449​ comment = 'Taskotron: %s test %s on %s. Result log: %s ' \
445 '(results are informative only)' % (testname, result, arch, url) 450​ '(results are informative only)' % (testname, result, arch, url)
446 try: 451​ try:
447 bodhi_update = bodhi_api.query_update(update) 452​ bodhi_update = bodhi_api.query_update(update)
448 453​
449 (old_result, comment_time) = _already_commented(bodhi_update, testname, 454​ (old_result, comment_time) = _already_commented(bodhi_update, testname,
Show All 37 Lines
View Options

testing/test_bodhi_comment_directive.py

Show First 20 Lines • Show All 250 Lines • ▼ Show 20 Line(s)238 def test_post_testresult(self, prepare_for_bodhi_comment):
251 # Select the positional arguments of that call 251​ # Select the positional arguments of that call
252 call_data = call[1] 252​ call_data = call[1]
253 253​
254 assert call_data[0] == "update_title" 254​ assert call_data[0] == "update_title"
255 assert call_data[1] == ref_comment 255​ assert call_data[1] == ref_comment
256 assert call_data[2] == 0 256​ assert call_data[2] == 0
257 assert call_data[3] is False 257​ assert call_data[3] is False
258 258​
259​ def test_post_testresult_aborted(self, prepare_for_bodhi_comment):
260​ """Checks whether _post_testresult correctly does not submit comments
261​ for ABORTED results."""
262​ self.stub_bodhi.client = Dingus('bodhi_api.bodhi')
263​
264​ bodhi_comment_directive._post_testresult(self.stub_bodhi,
265​ update="update_title", testname="depcheck", result="ABORTED",
266​ url=self.ref_log_url)
267​
268​ # if the result was properly ignored, this should be empty
269​ assert len(self.stub_bodhi.client.calls) == 0
270​
271​ def test_post_testresult_crashed(self, prepare_for_bodhi_comment):
272​ """Checks whether _post_testresult correctly does not submit comments
273​ for ABORTED results."""
274​ self.stub_bodhi.client = Dingus('bodhi_api.bodhi')
275​
276​ bodhi_comment_directive._post_testresult(self.stub_bodhi,
277​ update="update_title", testname="depcheck", result="CRASHED",
278​ url=self.ref_log_url)
279​
280​ # if the result was properly ignored, this should be empty
281​ assert len(self.stub_bodhi.client.calls) == 0
282​
259 def test_tap_mapping(self, prepare_for_bodhi_comment): 283​ def test_tap_mapping(self, prepare_for_bodhi_comment):
260 """Checks whether TAP output is mapped correctly to 284​ """Checks whether TAP output is mapped correctly to
261 the bodhi comment call.""" 285​ the bodhi comment call."""
262 ref_comment = "Taskotron: depcheck test PASSED on noarch. "\ 286​ ref_comment = "Taskotron: depcheck test PASSED on noarch. "\
263 "Result log: %s (results are informative only)" % self.ref_log_url 287​ "Result log: %s (results are informative only)" % self.ref_log_url
264 self.stub_bodhi.client = Dingus('bodhi_api.bodhi') 288​ self.stub_bodhi.client = Dingus('bodhi_api.bodhi')
265 289​
266 self.directive.process(self.ref_input, self.ref_envdata) 290​ self.directive.process(self.ref_input, self.ref_envdata)
▲ Show 20 Lines • Show All 61 Lines • Show Last 20 Lines