Differential D355

logger: don't modify global logging.Formatter
ClosedPublic
Actions

Authored by kparal on Apr 27 2015, 8:24 AM.

Details

Reviewers
tflink
mkrizek
jskladan
Commits
rLTRN9bbdb205ed32: logger: don't modify global logging.Formatter
Summary

Instead, make the changes local to our instances. This is especially
important when running in the library mode.

Test Plan

local execution seems to work, it prints times in UTC, and the test suite works as well

Diff Detail

Repository
rLTRN libtaskotron
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kparal retitled this revision from to logger: don't modify global logging.Formatter.Apr 27 2015, 8:24 AM
kparal updated this object.
kparal edited the test plan for this revision. (Show Details)
kparal added reviewers: tflink, jskladan, mkrizek.
jskladan accepted this revision.Apr 27 2015, 11:08 AM
This revision is now accepted and ready to land.Apr 27 2015, 11:08 AM
mkrizek accepted this revision.Apr 27 2015, 11:59 AM
Closed by commit rLTRN9bbdb205ed32: logger: don't modify global logging.Formatter (authored by kparal). · Explain WhyApr 28 2015, 12:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mlibtaskotron/logger.py (7 lines)

Diff 955

View Options

libtaskotron/logger.py

Show All 26 Lines
27# you must not import libtaskotron.config here because of cyclic dependencies 27​# you must not import libtaskotron.config here because of cyclic dependencies
28 28​
29# http://docs.python.org/2/howto/logging.html#configuring-logging-for-a-library 29​# http://docs.python.org/2/howto/logging.html#configuring-logging-for-a-library
30#: the main logger for libtaskotron library, easily accessible from all our 30​#: the main logger for libtaskotron library, easily accessible from all our
31#: modules 31​#: modules
32log = logging.getLogger('libtaskotron') 32​log = logging.getLogger('libtaskotron')
33log.addHandler(logging.NullHandler()) # this is needed when running in library mode 33​log.addHandler(logging.NullHandler()) # this is needed when running in library mode
34 34​
35# set logging time to UTC/GMT 35​# log formatting
36logging.Formatter.converter = time.gmtime ​
37 ​
38_fmt_full = '[%(name)s:%(filename)s:%(lineno)d] '\ 36​_fmt_full = '[%(name)s:%(filename)s:%(lineno)d] '\
39 '%(asctime)s %(levelname)-7s %(message)s' 37​ '%(asctime)s %(levelname)-7s %(message)s'
40_fmt_simple = '[%(name)s] %(asctime)s %(levelname)-7s %(message)s' 38​_fmt_simple = '[%(name)s] %(asctime)s %(levelname)-7s %(message)s'
41_datefmt_full = '%Y-%m-%d %H:%M:%S' 39​_datefmt_full = '%Y-%m-%d %H:%M:%S'
42_datefmt_simple = '%H:%M:%S' 40​_datefmt_simple = '%H:%M:%S'
43_formatter_full = logging.Formatter(fmt=_fmt_full, datefmt=_datefmt_full) 41​_formatter_full = logging.Formatter(fmt=_fmt_full, datefmt=_datefmt_full)
44_formatter_simple = logging.Formatter(fmt=_fmt_simple, datefmt=_datefmt_simple) 42​_formatter_simple = logging.Formatter(fmt=_fmt_simple, datefmt=_datefmt_simple)
43​# set logging time to UTC/GMT
44​_formatter_full.converter = time.gmtime
45​_formatter_simple.converter = time.gmtime
45 46​
46#: our current stream handler sending logged messages to stderr 47​#: our current stream handler sending logged messages to stderr
47stream_handler = None 48​stream_handler = None
48 49​
49#: our current syslog handler sending logged messages to syslog 50​#: our current syslog handler sending logged messages to syslog
50syslog_handler = None 51​syslog_handler = None
51 52​
52#: our current file handler sending logged messages to file log 53​#: our current file handler sending logged messages to file log
▲ Show 20 Lines • Show All 184 Lines • Show Last 20 Lines