Add ABORTED outcome
ClosedPublic
Actions

Authored by jskladan on Apr 21 2015, 2:33 PM.

Details

Reviewers

kparal
tflink
mkrizek

Maniphest Tasks

T264: add 'CRASHED' and 'ABORTED' to list of possible outcomes
T458: resultsdb doesn't support ABORTED outcome

Commits

rRSDBe24915103e19: Add ABORTED outcome
rRSDB36f31442e4e5: Add ABORTED outcome

Summary

As per @kparal's request, adding ABORTED outcome to the list of possible results.

Test Plan

alembic upgrade/downgrade tested locally with sqlite and postgresql database

Diff Detail

Repository

rRSDB resultsdb

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

jskladan retitled this revision from to Add ABORTED outcome.Apr 21 2015, 2:33 PM

jskladan updated this object.

jskladan edited the test plan for this revision. (Show Details)

jskladan added reviewers: tflink, mkrizek, kparal.

jskladan added a subscriber: kparal.

Herald added a subscriber: tflink. · View Herald TranscriptApr 21 2015, 2:33 PM

jskladan added a task: T458: resultsdb doesn't support ABORTED outcome.Apr 21 2015, 2:33 PM

tflink accepted this revision.Apr 21 2015, 2:36 PM

This revision is now accepted and ready to land.Apr 21 2015, 2:36 PM

Well, I don't know anything about alembic, but the change in the other file looks OK :-)

Closed by commit rRSDBe24915103e19: Add ABORTED outcome (authored by Josef Skladanka <jskladan@redhat.com>). · Explain WhyApr 28 2015, 12:24 PM

This revision was automatically updated to reflect the committed changes.

kparal mentioned this in D362: ignore ABORTED, CRASHED results when posting bodhi comments. Fixes T467.May 5 2015, 7:56 AM

jskladan added a task: T264: add 'CRASHED' and 'ABORTED' to list of possible outcomes.Nov 4 2015, 12:14 PM

Revision Contents

			Path	Packages
A	M		alembic/versions/34760e10040b_add_aborted_outcome.py (51 lines)
M			resultsdb/models/results.py (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	931	f90fc31		Apr 21 2015, 2:33 PM	★	★
Diff 2	954	f90fc31	Commit rRSDBe24915103e19ee33affad2aa86495dcf93362a69	Apr 28 2015, 12:21 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
fef5464dfa8b	473f081f84f1	f90fc3191ade	Josef Skladanka	Add ABORTED outcome (Show More…)	Apr 21 2015, 11:04 AM

Diff 954

View Options

alembic/versions/34760e10040b_add_aborted_outcome.py

This file was added.

		1		"""Add ABORTED outcome
		2
		3		Revision ID: 34760e10040b
		4		Revises: 4ace44a44bf
		5		Create Date: 2015-04-21 14:01:41.374105
		6
		7		"""
		8
		9		# revision identifiers, used by Alembic.
		10		revision = '34760e10040b'
		11		down_revision = '4ace44a44bf'
		12		branch_labels = None
		13		depends_on = None
		14
		15		from alembic import op
		16		import sqlalchemy as sa
		17
		18		old_values = ('PASSED', 'INFO', 'FAILED', 'ERROR', 'WAIVED', 'NEEDS_INSPECTION')
		19		new_values = ('PASSED', 'INFO', 'FAILED', 'ERROR', 'WAIVED', 'NEEDS_INSPECTION', 'ABORTED')
		20
		21		old_enum = sa.Enum(*old_values, name='resultoutcome')
		22		tmp_enum = sa.Enum(*new_values, name='resultoutcome_tmp')
		23		new_enum = sa.Enum(*new_values, name='resultoutcome')
		24
		25
		26		def upgrade():
		27		# this migration is postgresql specific and fails on sqlite
		28		if op.get_bind().engine.url.drivername.startswith("postgresql"):
		29		tmp_enum.create(op.get_bind(), checkfirst=False)
		30		op.execute('ALTER TABLE result ALTER COLUMN outcome TYPE resultoutcome_tmp '
		31		' USING outcome::text::resultoutcome_tmp')
		32		old_enum.drop(op.get_bind(), checkfirst=False)
		33		new_enum.create(op.get_bind(), checkfirst=False)
		34		op.execute('ALTER TABLE result ALTER COLUMN outcome TYPE resultoutcome '
		35		' USING outcome::text::resultoutcome')
		36		tmp_enum.drop(op.get_bind(), checkfirst=False)
		37
		38
		39		def downgrade():
		40		# this migration is postgresql specific and fails on sqlite
		41		if op.get_bind().engine.url.drivername.startswith("postgresql"):
		42		op.execute("UPDATE result SET outcome='ERROR' WHERE outcome='ABORTED'")
		43
		44		tmp_enum.create(op.get_bind(), checkfirst=False)
		45		op.execute('ALTER TABLE result ALTER COLUMN outcome TYPE resultoutcome_tmp '
		46		' USING outcome::text::resultoutcome_tmp')
		47		new_enum.drop(op.get_bind(), checkfirst=False)
		48		old_enum.create(op.get_bind(), checkfirst=False)
		49		op.execute('ALTER TABLE result ALTER COLUMN outcome TYPE resultoutcome '
		50		' USING outcome::text::resultoutcome')
		51		tmp_enum.drop(op.get_bind(), checkfirst=False)