Fix repo links to point to fc21 in docs
ClosedPublic

Authored by mkrizek on Apr 8 2015, 7:16 AM.

Details

Diff Detail

Repository
rLTRN libtaskotron
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mkrizek retitled this revision from to Fix repo links to point to fc21 in docs.Apr 8 2015, 7:16 AM
mkrizek updated this object.
mkrizek edited the test plan for this revision. (Show Details)
mkrizek added reviewers: tflink, kparal, jskladan.
kparal accepted this revision.Apr 8 2015, 10:34 AM
This revision is now accepted and ready to land.Apr 8 2015, 10:34 AM

Actually, the file contains this:

[tflink-taskotron]
name=Copr repo for taskotron owned by tflink
baseurl=http://copr-be.cloud.fedoraproject.org/results/tflink/taskotron/fedora-$releasever-$basearch/
skip_if_unavailable=True
gpgcheck=0
enabled=1

So it is not hardcoded for a specific release, but uses $releasever and $basearch instead. That is great. So what if we simplified the target file name in /etc/yum.repos.d?

Instead of tflink-taskotron-fedora-21.repo we could name it tflink-taskotron.repo or taskotron-copr.repo or just taskotron.repo?

In D332#6041, @kparal wrote:

Actually, the file contains this:

[tflink-taskotron]
name=Copr repo for taskotron owned by tflink
baseurl=http://copr-be.cloud.fedoraproject.org/results/tflink/taskotron/fedora-$releasever-$basearch/
skip_if_unavailable=True
gpgcheck=0
enabled=1

So it is not hardcoded for a specific release, but uses $releasever and $basearch instead. That is great. So what if we simplified the target file name in /etc/yum.repos.d?

Instead of tflink-taskotron-fedora-21.repo we could name it tflink-taskotron.repo or taskotron-copr.repo or just taskotron.repo?

I suspect the files are generated by copr.

In D332#6042, @mkrizek wrote:

I suspect the files are generated by copr.

I was talking about the files we save into the user system, not the generated ones.

sudo wget http://copr-fe.cloud.fedoraproject.org/coprs/tflink/taskotron/repo/fedora-21/tflink-taskotron-fedora-21.repo -O /etc/yum.repos.d/taskotron-copr.repo

But if we can't control the repo name header:

[tflink-taskotron]

then I'd say we should keep that in the filename as well. So probably rather:

sudo wget http://copr-fe.cloud.fedoraproject.org/coprs/tflink/taskotron/repo/fedora-21/tflink-taskotron-fedora-21.repo -O /etc/yum.repos.d/tflink-taskotron.repo

But that's just an idea how to make it simpler and shorter in the docs, no big deal.

This revision was automatically updated to reflect the committed changes.