Makefile: fix MOCKCHAINREPO directory permissions
ClosedPublic
Actions

Authored by kparal on Apr 7 2015, 3:39 PM.

Details

Reviewers

tflink
mkrizek
jskladan

Commits

rLTRNde88ab83c2b0: Makefile: fix MOCKCHAINREPO directory permissions

Summary

Recently introduced tmpfiles.d config file started creating
/var/tmp/taskotron-mockchain as root with 777. Mockchain tries to do
chmod on it and crashes (RHBZ 1209532). The solution is to add a
subdirectory and mockchain is now happy.

As a polish change, adjust group ownership of
/var/tmp/taskotron-mockchain. That does not work around the bug, but
seems more correct.

Test Plan

make mockchain works now

Diff Detail

Repository

rLTRN libtaskotron

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kparal retitled this revision from to Makefile: fix MOCKCHAINREPO directory permissions.Apr 7 2015, 3:39 PM

kparal updated this object.

kparal edited the test plan for this revision. (Show Details)

kparal added reviewers: tflink, jskladan, mkrizek.

Herald added a subscriber: tflink. · View Herald TranscriptApr 7 2015, 3:39 PM

tflink accepted this revision.Apr 7 2015, 4:03 PM

This revision is now accepted and ready to land.Apr 7 2015, 4:03 PM

mkrizek accepted this revision.Apr 8 2015, 6:07 AM

Closed by commit rLTRNde88ab83c2b0: Makefile: fix MOCKCHAINREPO directory permissions (authored by kparal). · Explain WhyApr 8 2015, 10:25 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

			Path	Packages
M			Makefile (2 lines)
M			conf/tmpfiles.d/taskotron.conf (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	899	ce47a6e		Apr 7 2015, 3:39 PM	★	★
Diff 2	904	589dd68	Commit rLTRNde88ab83c2b037f7fa0eb9eb50a7ed6d4a6c3e44	Apr 8 2015, 10:22 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
8c5afdd31175	0d01e4c16dde	ce47a6e42286	Kamil Páral	Makefile: fix MOCKCHAINREPO directory permissions (Show More…)	Apr 7 2015, 3:33 PM

Diff 904

View Options

Makefile

Show All 27 Lines
28	DIST:=$(shell rpm --eval '%{dist}')	28	DIST:=$(shell rpm --eval '%{dist}')
29	VERSION:=$(shell rpmspec -q --queryformat="%{VERSION}\n" $(SPECFILE) \| uniq)	29	VERSION:=$(shell rpmspec -q --queryformat="%{VERSION}\n" $(SPECFILE) \| uniq)
30	RELEASE:=$(subst $(DIST),,$(shell rpmspec -q --queryformat="%{RELEASE}\n" $(SPECFILE) \| uniq))	30	RELEASE:=$(subst $(DIST),,$(shell rpmspec -q --queryformat="%{RELEASE}\n" $(SPECFILE) \| uniq))
31	NVR:=$(SRC)-$(VERSION)-$(RELEASE)	31	NVR:=$(SRC)-$(VERSION)-$(RELEASE)
32	GITBRANCH:=$(shell git rev-parse --abbrev-ref HEAD)	32	GITBRANCH:=$(shell git rev-parse --abbrev-ref HEAD)
33	TARGETDIST:=fc21	33	TARGETDIST:=fc21
34	BUILDTARGET=fedora-21-x86_64	34	BUILDTARGET=fedora-21-x86_64
35	COPRREPO=https://copr-be.cloud.fedoraproject.org/results/tflink/taskotron/fedora-21-x86_64	35	COPRREPO=https://copr-be.cloud.fedoraproject.org/results/tflink/taskotron/fedora-21-x86_64
36	MOCKCHAINREPO=/var/tmp/taskotron-mockchain	36	MOCKCHAINREPO=/var/tmp/taskotron-mockchain/repo
37		37
38	test: $(VENV)	38	test: $(VENV)
39	sh -c "TEST='true' . $(VENV)/bin/activate; py.test --cov $(SRC) testing/; deactivate"	39	sh -c "TEST='true' . $(VENV)/bin/activate; py.test --cov $(SRC) testing/; deactivate"
40		40
41	test-ci: $(VENV)	41	test-ci: $(VENV)
42	sh -c "TEST='true' . $(VENV)/bin/activate; py.test --cov-report xml --cov $(SRC) testing/; deactivate"	42	sh -c "TEST='true' . $(VENV)/bin/activate; py.test --cov-report xml --cov $(SRC) testing/; deactivate"
43		43
44	pylint:	44	pylint:
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines