Differential D330

spec: require python-setuptools
ClosedPublic
Actions

Authored by kparal on Apr 7 2015, 2:51 PM.

Details

Reviewers
tflink
mkrizek
jskladan
Maniphest Tasks
T449: missing dependency on python-setuptools?
Commits
rLTRN589dd68afe77: spec: require python-setuptools
Summary

this should fix the dependency

Test Plan

verified that the dependency was added using make mockchain

Diff Detail

Repository
rLTRN libtaskotron
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kparal retitled this revision from to spec: require python-setuptools.Apr 7 2015, 2:51 PM
kparal updated this object.
kparal edited the test plan for this revision. (Show Details)
kparal added reviewers: mkrizek, tflink, jskladan.
kparal added a task: T449: missing dependency on python-setuptools?.
jskladan accepted this revision.Apr 7 2015, 3:05 PM
This revision is now accepted and ready to land.Apr 7 2015, 3:05 PM
tflink accepted this revision.Apr 7 2015, 3:45 PM

Would be nice to have a bit more detail and a ticket number in the changelog but certainly not requried

kparal updated this revision to Diff 900.Apr 7 2015, 3:58 PM

I wasn't sure whether I should add a changelog entry at all :) Added more explanation.

Closed by commit rLTRN589dd68afe77: spec: require python-setuptools (authored by kparal). · Explain WhyApr 7 2015, 4:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mlibtaskotron.spec (6 lines)

Diff 901

View Options

libtaskotron.spec

1# sitelib for noarch packages, sitearch for others (remove the unneeded one) 1​# sitelib for noarch packages, sitearch for others (remove the unneeded one)
2%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} 2​%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")}
3%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")} 3​%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
4 4​
5Name: libtaskotron 5​Name: libtaskotron
6Version: 0.3.13 6​Version: 0.3.13
7Release: 1%{?dist} 7​Release: 2%{?dist}
8Summary: Taskotron Support Library 8​Summary: Taskotron Support Library
9 9​
10License: GPLv3 10​License: GPLv3
11URL: https://bitbucket.org/fedoraqa/libtaskotron 11​URL: https://bitbucket.org/fedoraqa/libtaskotron
12Source0: http://qadevel.fedoraproject.org/releases/%{name}/%{name}-%{version}.tar.gz 12​Source0: http://qadevel.fedoraproject.org/releases/%{name}/%{name}-%{version}.tar.gz
13 13​
14BuildArch: noarch 14​BuildArch: noarch
15 15​
16Requires: bodhi-client 16​Requires: bodhi-client
17Requires: koji 17​Requires: koji
18Requires: rpm-python 18​Requires: rpm-python
19Requires: pyOpenSSL 19​Requires: pyOpenSSL
20Requires: python-pycurl 20​Requires: python-pycurl
21Requires: python-urlgrabber 21​Requires: python-urlgrabber
22Requires: pytap13 >= 0.1.0 22​Requires: pytap13 >= 0.1.0
23Requires: resultsdb_api 23​Requires: resultsdb_api
24Requires: python-bayeux 24​Requires: python-bayeux
25Requires: resultsdb_api 25​Requires: resultsdb_api
26Requires: python-hawkey >= 0.4.13-1 26​Requires: python-hawkey >= 0.4.13-1
27Requires: python-bunch 27​Requires: python-bunch
28Requires: python-fedora 28​Requires: python-fedora
29Requires: createrepo 29​Requires: createrepo
30Requires: mash 30​Requires: mash
31Requires: libtaskotron-config 31​Requires: libtaskotron-config
32​Requires: python-setuptools
32BuildRequires: python-devel 33​BuildRequires: python-devel
33BuildRequires: python-setuptools 34​BuildRequires: python-setuptools
34BuildRequires: pytest 35​BuildRequires: pytest
35BuildRequires: python-bunch 36​BuildRequires: python-bunch
36BuildRequires: python-dingus 37​BuildRequires: python-dingus
37BuildRequires: python-urlgrabber 38​BuildRequires: python-urlgrabber
38BuildRequires: koji 39​BuildRequires: koji
39BuildRequires: pytap13 >= 0.3.0 40​BuildRequires: pytap13 >= 0.3.0
▲ Show 20 Lines • Show All 61 Lines • ▼ Show 20 Line(s)
101%files -n libtaskotron-config 102​%files -n libtaskotron-config
102%dir %{_sysconfdir}/taskotron 103​%dir %{_sysconfdir}/taskotron
103%config(noreplace) %{_sysconfdir}/taskotron/taskotron.yaml 104​%config(noreplace) %{_sysconfdir}/taskotron/taskotron.yaml
104%config %{_sysconfdir}/taskotron/yumrepoinfo.conf 105​%config %{_sysconfdir}/taskotron/yumrepoinfo.conf
105 106​
106 107​
107 108​
108%changelog 109​%changelog
110​* Tue Apr 7 2015 Kamil Paral <kparal@redhat.com> - 0.3.13-2
111​- Require python-setuptools, otherwise runtask fails to execute. See T449.
112​
109* Tue Mar 31 2015 Martin Krizek <mkrizek@redhat.com> - 0.3.13-1 113​* Tue Mar 31 2015 Martin Krizek <mkrizek@redhat.com> - 0.3.13-1
110- Add support for execdb 114​- Add support for execdb
111- Various fixes 115​- Various fixes
112 116​
113* Wed Feb 25 2015 Martin Krizek <mkrizek@redhat.com> - 0.3.12-1 117​* Wed Feb 25 2015 Martin Krizek <mkrizek@redhat.com> - 0.3.12-1
114- Add support for task artifacts 118​- Add support for task artifacts
115 119​
116* Thu Feb 12 2015 Tim Flink <tflink@fedoraproject.org> - 0.3.11-1 120​* Thu Feb 12 2015 Tim Flink <tflink@fedoraproject.org> - 0.3.11-1
▲ Show 20 Lines • Show All 84 Lines • Show Last 20 Lines