Initial Skeleton for disposable clients
ClosedPublic

Authored by tflink on Apr 1 2015, 2:10 PM.

Details

Summary

This is a very simple start to the disposable client work. It's by no means set in stone - meant to be a starting point that can (and should) be altered as we continue the work.

Test Plan

No testing needed at this point, meant to be a starting point with little working code.

Diff Detail

Repository
rLTRN libtaskotron
Branch
disposable-develop
Lint
Lint OK
Unit
No Unit Test Coverage
tflink retitled this revision from to Initial Skeleton for disposable clients.Apr 1 2015, 2:10 PM
tflink updated this object.
tflink edited the test plan for this revision. (Show Details)
tflink added reviewers: kparal, mkrizek, jskladan.
tflink set the repository for this revision to rLTRN libtaskotron.
tflink added a project: libtaskotron.
kparal accepted this revision.Apr 1 2015, 3:04 PM

Thanks, looks reasonable.

This revision is now accepted and ready to land.Apr 1 2015, 3:04 PM
mkrizek accepted this revision.Apr 2 2015, 7:48 AM

LGTM

jskladan accepted this revision.Apr 2 2015, 8:38 AM

Looks good. I have probably missed something so - what is the thought behind the --patch argument?

tflink added a comment.Apr 9 2015, 9:48 PM
In D321#5845, @jskladan wrote:

Looks good. I have probably missed something so - what is the thought behind the --patch argument?

When I was writing the PoC, I ran into a problem - the VMs are created from scratch using packages. If I wanted to test a small change, I had to build a new package and get in a repo used during client creation.

It's a huge PITA, so I added the --patch argument as a sort of hotfix on the clients, enabling me to test changes in the libtaskotron code running on the clients without too much effort. It's mostly a dev convenience option but I'm open to other solutions or taking it out if it's considered too hacky

tflink closed this revision.May 6 2015, 4:06 PM

This was pushed a while ago and the change wasn't detected. Closing