Differential D320

Show the artifacts URL in job overview
ClosedPublic
Actions

Authored by jskladan on Mar 25 2015, 3:05 PM.

Details

Reviewers
kparal
tflink
Maniphest Tasks
T445: Show link to Artifacts in ExecDB
Commits
rEXECDB794941f6635c: Show the artifacts URL in job overview
Summary

The artifacts URL is now shown in the Job's overview

Test Plan

None so far

Diff Detail

Repository
rEXECDB execdb
Branch
feature/artifacts
Lint
No Linters Available
Unit
No Unit Test Coverage
jskladan retitled this revision from to Show the artifacts URL in job overview.Mar 25 2015, 3:05 PM
jskladan updated this object.
jskladan edited the test plan for this revision. (Show Details)
jskladan added a reviewer: tflink.
tflink accepted this revision.Apr 7 2015, 4:06 PM
This revision is now accepted and ready to land.Apr 7 2015, 4:06 PM
tflink added a comment.May 6 2015, 4:17 PM

@jskladan - can you push this change when you get a chance?

tflink commandeered this revision.May 6 2015, 4:18 PM
tflink edited reviewers, added: jskladan; removed: tflink.

nvm, this was pushed. phab just didn't see the change for some reason. Commandeering and closing

This revision now requires review to proceed.May 6 2015, 4:18 PM
tflink added a comment.May 6 2015, 4:19 PM

nvm about the closing part - looks like I can't do that.

@jskladan - do you have the option to close the revision since you created it?

jskladan commandeered this revision.May 7 2015, 7:16 AM
jskladan edited reviewers, added: tflink; removed: jskladan.

hmm, seems that I can't close it either *sigh*, the only thing I seem to be able to do is abandon it. Should we do that?

kparal accepted this revision.May 7 2015, 12:09 PM
kparal added a reviewer: kparal.
This revision is now accepted and ready to land.May 7 2015, 12:09 PM
jskladan closed this revision.May 7 2015, 12:10 PM

OK, so it needed to be ACKed, in order to be Closed manually.. Thanks @kparal!

Revision Contents

Diff 874

View Options

conf/settings.py.example

1# you can use this as a template 1​# you can use this as a template
2SECRET_KEY = 'not-really-a-secret' 2​SECRET_KEY = 'not-really-a-secret'
3SQLALCHEMY_DATABASE_URI = 'postgresql+psycopg2://dbuser:dbpassword@dbhost:dbport/dbname' 3​SQLALCHEMY_DATABASE_URI = 'postgresql+psycopg2://dbuser:dbpassword@dbhost:dbport/dbname'
4SHOW_DB_URI = False 4​SHOW_DB_URI = False
5PRODUCTION = True 5​PRODUCTION = True
6 6​
7FILE_LOGGING = False 7​FILE_LOGGING = False
8SYSLOG_LOGGING = False 8​SYSLOG_LOGGING = False
9STREAM_LOGGING = True 9​STREAM_LOGGING = True
10LOGFILE = '/var/log/execdb/execdb.log' 10​LOGFILE = '/var/log/execdb/execdb.log'
11SHOW_DB_URI = False 11​SHOW_DB_URI = False
12 12​
13BUILDBOT_FRONTPAGE_URL = 'http://taskotron-local/taskmaster' 13​BUILDBOT_FRONTPAGE_URL = 'http://taskotron-local/taskmaster'
14RESULTSDB_FRONTPAGE_URL = 'http://taskotron-local/resultsdb' 14​RESULTSDB_FRONTPAGE_URL = 'http://taskotron-local/resultsdb'
15​ARTIFACTS_BASE_URL = 'http://taskotron-local/artifacts/all'
View Options

execdb/controllers/main.py

Show First 20 Lines • Show All 115 Lines • ▼ Show 20 Line(s)115def show_job(uuid):
116 try: 116​ try:
117 job = db.session.query(Job).filter(Job.uuid == uuid).one() 117​ job = db.session.query(Job).filter(Job.uuid == uuid).one()
118 except orm_exc.NoResultFound: 118​ except orm_exc.NoResultFound:
119 return 'UUID not found', 404 119​ return 'UUID not found', 404
120 120​
121 return render_template('show_job.html', 121​ return render_template('show_job.html',
122 job = job, 122​ job = job,
123 buildbot_url = BB_URL, 123​ buildbot_url = BB_URL,
124 resultsdb_url = RESULTSDB_URL) 124​ resultsdb_url = RESULTSDB_URL,
125​ artifacts_base_url = app.config['ARTIFACTS_BASE_URL'])
125 126​
126 127​
127@main.route('/jobs', methods = ['POST']) 128​@main.route('/jobs', methods = ['POST'])
128def create_job(): 129​def create_job():
129 job = Job() 130​ job = Job()
130 131​
131 data = request.json 132​ data = request.json
132 job.fedmsg_data = json.dumps(data) 133​ job.fedmsg_data = json.dumps(data)
▲ Show 20 Lines • Show All 159 Lines • Show Last 20 Lines
View Options

execdb/templates/show_job.html

Show First 20 Lines • Show All 66 Lines • ▼ Show 20 Line(s)
67 67​
68<br /> 68​<br />
69 69​
70<div class="row"> 70​<div class="row">
71 <div class="col-md-2"><strong>Logs</strong></div> 71​ <div class="col-md-2"><strong>Logs</strong></div>
72 <div class="col-md-9"><a href="{{buildbot_url}}{{job.link_build_log}}"><span class="glyphicon glyphicon-new-window"></span></a></div> 72​ <div class="col-md-9"><a href="{{buildbot_url}}{{job.link_build_log}}"><span class="glyphicon glyphicon-new-window"></span></a></div>
73</div> 73​</div>
74 74​
75​<div class="row">
76​ <div class="col-md-2"><strong>Artifacts</strong></div>
77​ <div class="col-md-9"><a href="{{artifacts_base_url}}/{{job.uuid}}"><span class="glyphicon glyphicon-new-window"></span></a></div>
78​</div>
79​
75<br /> 80​<br />
76 81​
77<div class="row"> 82​<div class="row">
78 <div class="col-md-2"><strong>ResultsDB</strong></div> 83​ <div class="col-md-2"><strong>ResultsDB</strong></div>
79 <div class="col-md-9"><a href="{{resultsdb_url}}/jobs/{{job.uuid}}"><span class="glyphicon glyphicon-new-window"></span></a></div> 84​ <div class="col-md-9"><a href="{{resultsdb_url}}/jobs/{{job.uuid}}"><span class="glyphicon glyphicon-new-window"></span></a></div>
80</div> 85​</div>
81 86​
82</div> 87​</div>
Show All 21 Lines