T47 bodhi download
ClosedPublic

Authored by pschindl on Mar 26 2014, 3:34 PM.

Details

Summary

Bodhi directive created. It provides action download, which downloads rpms
from builds of specified bodhi update.

Bodhi utils are used for communitation with bodhi

Test Plan

Tests for both b.-directive and b.-utils are included

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
tflink requested changes to this revision.Mar 27 2014, 8:34 AM

Overall, it looks pretty good. The runner args may need to be updated if we decide to go with more generic item and item_type route in T106 but we can deal with that later.

libtaskotron/directives/bodhi_directive.py
57

I'd like to see this extracted into a standalone method since we'll be adding more code for bodhi comments etc.

81

This is a bit more complex than it needs to be, I think it'd be better as: [build['nvr'] for build in res['builds]]

pschindl updated this revision.Mar 28 2014, 2:06 PM

Action downloaded put in the standalone method

tflink accepted this revision.Mar 31 2014, 7:35 AM

Looks good to me

pschindl closed this revision.Mar 31 2014, 8:18 AM

Closed by commit rLTRN9ae3d93aa4db (authored by @pschindl).