Differential D315

Add an ISO size test (copied right from openSUSE)
AbandonedPublic
Actions

Authored by adamwill on Mar 20 2015, 2:56 AM.

Details

Reviewers
garretraziel
jskladan
Test Plan

Run some tests and verify that the size test is run for the appropriate images.

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Branch
maxsize
Lint
No Linters Available
Unit
No Unit Test Coverage
adamwill retitled this revision from to Add an ISO size test (copied right from openSUSE).Mar 20 2015, 2:56 AM
adamwill updated this object.
adamwill edited the test plan for this revision. (Show Details)
adamwill added reviewers: garretraziel, jskladan.
adamwill added a comment.Mar 20 2015, 3:00 AM

Running the test is trivial. Reporting results may be a bit harder. Two problems:

  1. The results matrix for the sanity checks isn't really great and requires some logic: it only has per-Flavor environments, and you have to test *all* images for each flavor to report the result. That doesn't map into our current openqa_fedora_tools design very well.
  1. I don't think it's right to set this test as 'important' (i.e. mark the entire job as failed if it fails), but that means we can't assume this test passed if the job as a whole passed, which again is something the current openqa_fedora_tools design assumes.

I'm going to think about those two issues for a bit and see how much hackery it'd take in o_f_t to fix them, but even if we can't, I think it's useful to have the test run in openQA; we can always check the results of the size check tests and manually report them to the wiki for now.

I suppose an alternative approach would be simply to run the size tests *in the dispatcher*...

adamwill abandoned this revision.Mar 20 2015, 7:03 AM

Actually, forget this, I'm just gonna make it a relval subcommand. Easier that way. I'm about 90% done with it already. I'll finish it off tomorrow.

Revision Contents

PathPackages
Mmain.pm (6 lines)
Mtemplates (3 lines)
AMtests/mediakit_iso_size.pm (22 lines)

Diff 860

View Options

main.pm

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Line(s)
44} 44​}
45$needle::cleanuphandler = \&cleanup_needles; 45​$needle::cleanuphandler = \&cleanup_needles;
46 46​
47if (get_var('LIVE')) { 47​if (get_var('LIVE')) {
48 # No package set selection for lives. 48​ # No package set selection for lives.
49 set_var('PACKAGE_SET', "default"); 49​ set_var('PACKAGE_SET', "default");
50} 50​}
51 51​
52​# Sanity checks
53​
54​if (get_var("ISO_MAXSIZE")) {
55​ autotest::loadtest get_var('CASEDIR')."/tests/mediakit_iso_size.pm";
56​}
57​
52# Boot to anaconda Hub in English 58​# Boot to anaconda Hub in English
53 59​
54if (get_var("ENTRYPOINT")) 60​if (get_var("ENTRYPOINT"))
55{ 61​{
56 autotest::loadtest get_var('CASEDIR')."/tests/".get_var("ENTRYPOINT").".pm"; 62​ autotest::loadtest get_var('CASEDIR')."/tests/".get_var("ENTRYPOINT").".pm";
57} 63​}
58else 64​else
59{ 65​{
▲ Show 20 Lines • Show All 84 Lines • Show Last 20 Lines
View Options

templates

Show First 20 Lines • Show All 201 Lines • ▼ Show 20 Line(s)194 {
202 version => "*", 202​ version => "*",
203 }, 203​ },
204 { 204​ {
205 arch => "x86_64", 205​ arch => "x86_64",
206 distri => "fedora", 206​ distri => "fedora",
207 flavor => "generic_boot", 207​ flavor => "generic_boot",
208 name => "", 208​ name => "",
209 settings => [ 209​ settings => [
210​ { key => "ISO_MAXSIZE", value => 734003200 }
210 ], 211​ ],
211 variables => "", 212​ variables => "",
212 version => "*", 213​ version => "*",
213 }, 214​ },
214 { 215​ {
215 arch => "x86_64", 216​ arch => "x86_64",
216 distri => "fedora", 217​ distri => "fedora",
217 flavor => "server_boot", 218​ flavor => "server_boot",
218 name => "", 219​ name => "",
219 settings => [ 220​ settings => [
221​ { key => "ISO_MAXSIZE", value => 734003200 }
220 ], 222​ ],
221 variables => "", 223​ variables => "",
222 version => "*", 224​ version => "*",
223 }, 225​ },
224 { 226​ {
225 arch => "x86_64", 227​ arch => "x86_64",
226 distri => "fedora", 228​ distri => "fedora",
227 flavor => "workstation_live", 229​ flavor => "workstation_live",
228 name => "", 230​ name => "",
229 settings => [ 231​ settings => [
232​ { key => "ISO_MAXSIZE", value => 2000000000 },
230 { key => "LIVE", value => "1" }, 233​ { key => "LIVE", value => "1" },
231 { key => "DESKTOP", value => "gnome" } 234​ { key => "DESKTOP", value => "gnome" }
232 ], 235​ ],
233 variables => "", 236​ variables => "",
234 version => "*", 237​ version => "*",
235 } 238​ }
236 ], 239​ ],
237 TestSuites => [ 240​ TestSuites => [
▲ Show 20 Lines • Show All 148 Lines • Show Last 20 Lines
View Options

tests/mediakit_iso_size.pm

  • This file was added.
1​use base "basetest";
2​use strict;
3​use testapi;
4​
5​sub run {
6​ my $self = shift;
7​ my $iso = get_var("ISO");
8​ my $size = -s $iso;
9​ my $result = 'ok';
10​ my $max = get_var("ISO_MAXSIZE");
11​ if ( $size > $max ) {
12​ $result = 'fail';
13​ }
14​ bmwqemu::diag("check if actual iso size $size fits $max: $result");
15​ $self->result($result);
16​}
17​
18​sub test_flags() {
19​}
20​
21​1;
22​# vim: set sw=4 et: