fix mock crashes during task-depcheck for single arch packages
ClosedPublic

Authored by kparal on Mar 4 2015, 12:08 PM.

Details

Summary

This consists of three commits:


koji_utils: fix return value in get_tagged_rpms()
Also rewrite one ugly line.


koji_utils: always create destination directory

Even when no RPMs are actually downloaded. This fixes issues with tools
or directives which then later expect the directory to exist.

To make things easier, stop wrapping filesystem errors into Taskotron
errors, but raise them as they are. That allows us to move a lot of
error checking and warning producing code into a single place.


koji_utils: add unit tests


Test Plan

test suite passes, and depcheck manually run on docker (x86_64 only) package passes as well

Diff Detail

Repository
rLTRN libtaskotron
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kparal retitled this revision from to fix mock crashes during task-depcheck for single arch packages.Mar 4 2015, 12:08 PM
kparal updated this object.
kparal edited the test plan for this revision. (Show Details)
kparal added reviewers: jskladan, tflink, mkrizek.
kparal updated this object.Mar 4 2015, 12:14 PM
This revision is now accepted and ready to land.Mar 4 2015, 1:35 PM

Received unofficial blessing from @mkrizek, pushing.

This revision was automatically updated to reflect the committed changes.