Differential D302

Always create the directory for downloading tag's rpms
AbandonedPublic
Actions

Authored by jskladan on Feb 27 2015, 9:15 AM.

Details

Reviewers
kparal
tflink
mkrizek
Maniphest Tasks
T351: mash directive crashes if koji directive downloaded no RPMs
Summary
In T351#4854, @kparal wrote:

@jskladan, D267 doesn't seem to have fixed it:
http://taskotron-dev.fedoraproject.org/taskmaster/builders/x86_64/builds/73376/steps/runtask/logs/stdio

libtaskotron 0.3.11 should contain the fix. Can you look at it? Thanks.

I was unable to reproduce, but this patch ensures that the directory is created.
file_utils.makedirs() will not fail if the provided path is an already existing directory.

Test Plan

ran locally, unitests pass

Diff Detail

Repository
rLTRN libtaskotron
Branch
feature/t351
Lint
Lint OK
Unit
No Unit Test Coverage
jskladan retitled this revision from to Always create the directory for downloading tag's rpms.Feb 27 2015, 9:15 AM
jskladan updated this object.
jskladan edited the test plan for this revision. (Show Details)
jskladan added reviewers: kparal, tflink, mkrizek.
jskladan added a subscriber: kparal.
kparal added a comment.Feb 27 2015, 3:09 PM

I really want to know why it fails. I'll investigate.

kparal requested changes to this revision.Feb 27 2015, 4:22 PM

I've found the root issue, please see T351.

This revision now requires changes to proceed.Feb 27 2015, 4:22 PM
jskladan abandoned this revision.Feb 27 2015, 4:57 PM

@kparal will provide a better patch see T351

Revision Contents

PathPackages
Mlibtaskotron/koji_utils.py (13 lines)

Diff 823

View Options

libtaskotron/koji_utils.py

Show First 20 Lines • Show All 212 Lines • ▼ Show 20 Line(s)197 def get_tagged_rpms(self, tag, dest, arches=['all'], debuginfo=False,
213 log.info("Fetching %s builds for tag: %s", len(nvrs), tag) 213​ log.info("Fetching %s builds for tag: %s", len(nvrs), tag)
214 log.debug('Builds to be downloaded:\n %s', '\n '.join(nvrs)) 214​ log.debug('Builds to be downloaded:\n %s', '\n '.join(nvrs))
215 215​
216 for nvr in nvrs: 216​ for nvr in nvrs:
217 rpms.append(self.get_nvr_rpms(nvr, dest, arches, debuginfo, src)) 217​ rpms.append(self.get_nvr_rpms(nvr, dest, arches, debuginfo, src))
218 218​
219 # ensure that at least an empty directory is created, if no NVRs were 219​ # ensure that at least an empty directory is created, if no NVRs were
220 # actually downloaded 220​ # actually downloaded
221 if not rpms: 221​ # file_utils.makedirs will not fail, if the path exists,
222 try: 222​ # and is a directory
223 file_utils.makedirs(dest) 223​ try:
224 except OSError, e: 224​ file_utils.makedirs(dest)
225 log.error("Can't create directory %s", dest) 225​ except OSError, e:
226 raise exc.TaskotronRemoteError(e) 226​ log.error("Can't create directory %s", dest)
227​ raise exc.TaskotronRemoteError(e)
227 228​
228 return rpms 229​ return rpms
229 230​
230 231​
231def getNEVR(build): 232​def getNEVR(build):
232 '''Extract RPM version identifier in NEVR format from Koji build object 233​ '''Extract RPM version identifier in NEVR format from Koji build object
233 234​
234 :param dict build: Koji buildinfo dictionary (as returned e.g. from 235​ :param dict build: Koji buildinfo dictionary (as returned e.g. from
Show All 17 Lines