Added mockchain support to makefile
ClosedPublic

Authored by jskladan on Feb 23 2015, 8:40 AM.

Details

Summary

In order to be able to build the rpms locally, I have added a 'mockchain' command to the Makefile.
One can now run make mockchain to build the rpms locally

Test Plan

Tested several times, rpms deployed via Ansible

Diff Detail

Repository
rLTRN libtaskotron
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jskladan retitled this revision from to Added mockchain support to makefile.Feb 23 2015, 8:40 AM
jskladan updated this object.
jskladan edited the test plan for this revision. (Show Details)
jskladan added reviewers: tflink, mkrizek, kparal.
mkrizek accepted this revision.Feb 23 2015, 9:18 AM
This revision is now accepted and ready to land.Feb 23 2015, 9:18 AM

I don't know much about package building, so I'm not giving any review status here. A few comments below.

Makefile
75

I would like to see at least a comment about what this is useful for, because I was utterly confused why mockbuild is not enough.

77

I might be a good idea to move the package instead of copying it? Because standard mock dirs will clean themselves on their next use, but your custom mockchain dir will not. So either we should move the results out, or maybe even better to delete the temp directory after the build is complete? Otherwise some old packages will remain in there and they can affect future builds?

Closed by commit rLTRN00df40aa5b73: Added mockchain support to makefile (authored by Josef Skladanka <jskladan@redhat.com>). · Explain WhyFeb 23 2015, 5:03 PM
This revision was automatically updated to reflect the committed changes.