Differential D283

runner: print current artifacts dir with INFO level
ClosedPublic
Actions

Authored by kparal on Feb 20 2015, 1:08 PM.

Details

Reviewers
tflink
mkrizek
jskladan
Commits
rLTRN4698de48f2b3: runner: print current artifacts dir with INFO level
Summary

This allows users to see where to look for task artifacts even if they
haven't run libtaskotron runner in debug mode.

Test Plan

test suite fails, but I'm totally innocent in this :-)

Diff Detail

Repository
rLTRN libtaskotron
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kparal retitled this revision from to runner: print current artifacts dir with INFO level.Feb 20 2015, 1:08 PM
kparal updated this object.
kparal edited the test plan for this revision. (Show Details)
kparal added reviewers: mkrizek, jskladan, tflink.
mkrizek accepted this revision.Feb 20 2015, 1:49 PM
This revision is now accepted and ready to land.Feb 20 2015, 1:49 PM
Closed by commit rLTRN4698de48f2b3: runner: print current artifacts dir with INFO level (authored by kparal). · Explain WhyFeb 20 2015, 4:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mlibtaskotron/runner.py (2 lines)

Diff 781

View Options

libtaskotron/runner.py

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Line(s)42 self.workdir = tempfile.mkdtemp(prefix="task-",
43 dir=config.get_config().tmpdir) 43​ dir=config.get_config().tmpdir)
44 log.debug("Current workdir: %s", self.workdir) 44​ log.debug("Current workdir: %s", self.workdir)
45 self.envdata['workdir'] = self.workdir 45​ self.envdata['workdir'] = self.workdir
46 self.envdata['checkname'] = self.taskdata['name'] 46​ self.envdata['checkname'] = self.taskdata['name']
47 self.envdata['artifactsdir'] = "%s/%s" % \ 47​ self.envdata['artifactsdir'] = "%s/%s" % \
48 (config.get_config().artifactsdir, self.envdata['uuid']) 48​ (config.get_config().artifactsdir, self.envdata['uuid'])
49 try: 49​ try:
50 file_utils.makedirs(self.envdata['artifactsdir']) 50​ file_utils.makedirs(self.envdata['artifactsdir'])
51 log.debug("Current artifactsdir: %s", self.envdata['artifactsdir']) 51​ log.info("Task artifacts will be saved in: %s", self.envdata['artifactsdir'])
52 except OSError, e: 52​ except OSError, e:
53 log.error("Can't create artifacts directory %s", self.envdata['artifactsdir']) 53​ log.error("Can't create artifacts directory %s", self.envdata['artifactsdir'])
54 raise TaskotronError(e) 54​ raise TaskotronError(e)
55 55​
56 #override variable values 56​ #override variable values
57 for var, val in self.envdata['override']: 57​ for var, val in self.envdata['override']:
58 log.debug("Overriding variable %s, new value: %s", var, val) 58​ log.debug("Overriding variable %s, new value: %s", var, val)
59 self.envdata[var] = eval(val, {}, {}) 59​ self.envdata[var] = eval(val, {}, {})
▲ Show 20 Lines • Show All 208 Lines • Show Last 20 Lines