Differential D267

Download_tag creates empty dir for 0 rpms
ClosedPublic
Actions

Authored by jskladan on Dec 2 2014, 4:28 PM.

Details

Reviewers
kparal
tflink
Maniphest Tasks
T351: mash directive crashes if koji directive downloaded no RPMs
Commits
rLTRNfa10d6698e95: Download_tag creates empty dir for 0 rpms
Summary

Based on the comments in T351, koji_utils' download_tag now creates a
directory, when no rpms were downloaded. The steps next up in the
chain (mash directive and depcheck), are well able to handle empty
directories (which are 'correct' input).

Test Plan

unittests work, tested with several runs of depcheck with modified code (commented-out the section actually downloading rpms in the code)

Diff Detail

Repository
rLTRN libtaskotron
Lint
Lint Skipped
Unit
Unit Tests Skipped
jskladan retitled this revision from to Download_tag creates empty dir for 0 rpms.Dec 2 2014, 4:28 PM
jskladan updated this object.
jskladan edited the test plan for this revision. (Show Details)
jskladan added reviewers: tflink, kparal.
tflink accepted this revision.Dec 2 2014, 5:54 PM
This revision is now accepted and ready to land.Dec 2 2014, 5:54 PM
jskladan closed this revision.Dec 3 2014, 1:03 PM
jskladan updated this revision to Diff 743.

Closed by commit rLTRNfa10d6698e95 (authored by @jskladan).

Revision Contents

PathPackages
Mlibtaskotron/koji_utils.py (9 lines)

Diff 743

View Options

libtaskotron/koji_utils.py

Show First 20 Lines • Show All 210 Lines • ▼ Show 20 Line(s)197 def get_tagged_rpms(self, tag, dest, arches=['all'], debuginfo=False,
211 nvrs = ["%(nvr)s" % x for x in tag_data] 211​ nvrs = ["%(nvr)s" % x for x in tag_data]
212 rpms = [] 212​ rpms = []
213 log.info("Fetching %s builds for tag: %s", len(nvrs), tag) 213​ log.info("Fetching %s builds for tag: %s", len(nvrs), tag)
214 log.debug('Builds to be downloaded:\n %s', '\n '.join(nvrs)) 214​ log.debug('Builds to be downloaded:\n %s', '\n '.join(nvrs))
215 215​
216 for nvr in nvrs: 216​ for nvr in nvrs:
217 rpms.append(self.get_nvr_rpms(nvr, dest, arches, debuginfo, src)) 217​ rpms.append(self.get_nvr_rpms(nvr, dest, arches, debuginfo, src))
218 218​
219​ # ensure that at least an empty directory is created, if no NVRs were
220​ # actually downloaded
221​ if not rpms:
222​ try:
223​ file_utils.makedirs(dest)
224​ except OSError, e:
225​ log.error("Can't create directory %s", dest)
226​ raise exc.TaskotronRemoteError(e)
227​
219 return rpms 228​ return rpms
220 229​
221 230​
222def getNEVR(build): 231​def getNEVR(build):
223 '''Extract RPM version identifier in NEVR format from Koji build object 232​ '''Extract RPM version identifier in NEVR format from Koji build object
224 233​
225 :param dict build: Koji buildinfo dictionary (as returned e.g. from 234​ :param dict build: Koji buildinfo dictionary (as returned e.g. from
226 :meth:`koji.getBuild`) 235​ :meth:`koji.getBuild`)
Show All 16 Lines