Differential D256

improve logging levels and verbosity
ClosedPublic
Actions

Authored by kparal on Oct 16 2014, 12:29 PM.

Details

Reviewers
mkrizek
jskladan
Commits
rLTRNb6b6ac492c2c: improve logging levels and verbosity
Summary

Should make the user-facing log more readable.

Test Plan

test suite works

Diff Detail

Repository
rLTRN libtaskotron
Lint
Lint Skipped
Unit
Unit Tests Skipped
kparal retitled this revision from to improve logging levels and verbosity.Oct 16 2014, 12:29 PM
kparal updated this object.
kparal edited the test plan for this revision. (Show Details)
kparal added reviewers: jskladan, mkrizek.
This revision is now accepted and ready to land.Oct 16 2014, 12:58 PM
kparal closed this revision.Oct 16 2014, 1:10 PM
kparal updated this revision to Diff 715.

Closed by commit rLTRNb6b6ac492c2c (authored by @kparal).

Revision Contents

Diff 715

View Options

libtaskotron/directives/bodhi_comment_directive.py

Show First 20 Lines • Show All 103 Lines • ▼ Show 20 Line(s)102 def __init__(self, bodhi_api=None):
104 if bodhi_api: 104​ if bodhi_api:
105 self.bodhi_api = bodhi_api 105​ self.bodhi_api = bodhi_api
106 else: 106​ else:
107 self.bodhi_api = bodhi_utils.BodhiUtils() 107​ self.bodhi_api = bodhi_utils.BodhiUtils()
108 108​
109 def process(self, input_data, env_data): 109​ def process(self, input_data, env_data):
110 output_data = [] 110​ output_data = []
111 111​
112 ​
113 Config = config.get_config() 112​ Config = config.get_config()
114 if not (Config.reporting_enabled and Config.report_to_bodhi): 113​ if not (Config.reporting_enabled and Config.report_to_bodhi):
115 log.info("Reporting to Bodhi is disabled, not doing anything.") 114​ log.info("Reporting to Bodhi is disabled, not doing anything.")
116 return 115​ return
117 116​
118 ​
119 if not ('doreport' in input_data and 'results' in input_data): 117​ if not ('doreport' in input_data and 'results' in input_data):
120 detected_args = ', '.join(input_data.keys()) 118​ detected_args = ', '.join(input_data.keys())
121 raise TaskotronDirectiveError("The bodhi_comment directive "\ 119​ raise TaskotronDirectiveError("The bodhi_comment directive "\
122 "requires 'doreport' and 'results' arguments. "\ 120​ "requires 'doreport' and 'results' arguments. "\
123 "Detected arguments: %s" % detected_args) 121​ "Detected arguments: %s" % detected_args)
124 122​
125 if input_data['doreport'] not in ['all', 'onchange']: 123​ if input_data['doreport'] not in ['all', 'onchange']:
126 raise TaskotronDirectiveError("The argument 'doreport' is"\ 124​ raise TaskotronDirectiveError("The argument 'doreport' is"\
Show All 16 Lines140 check_details = [r for r in check_details
143 if r.report_type == check.ReportType.BODHI_UPDATE] 141​ if r.report_type == check.ReportType.BODHI_UPDATE]
144 142​
145 # ? Log when no results of the type are found ? 143​ # ? Log when no results of the type are found ?
146 144​
147 _, log_url = buildbot_utils.get_urls(env_data['jobid'], 145​ _, log_url = buildbot_utils.get_urls(env_data['jobid'],
148 Config.taskotron_master, 146​ Config.taskotron_master,
149 Config.buildbot_task_step) 147​ Config.buildbot_task_step)
150 148​
149​ log.info('Posting %s results to Bodhi...', len(check_details))
150​
151 for detail in check_details: 151​ for detail in check_details:
152 outcome = _post_testresult(self.bodhi_api, detail.item, 152​ outcome = _post_testresult(self.bodhi_api, detail.item,
153 env_data['checkname'], 153​ env_data['checkname'],
154 detail.outcome, 154​ detail.outcome,
155 url = log_url, 155​ url = log_url,
156 doreport = input_data['doreport'], 156​ doreport = input_data['doreport'],
157 arch = detail.keyvals.get('arch', 'noarch'), 157​ arch = detail.keyvals.get('arch', 'noarch'),
158 ) 158​ )
▲ Show 20 Lines • Show All 246 Lines • ▼ Show 20 Line(s)368def _is_comment_needed(old_result, comment_time, result, time_span = None):
405 405​
406 if delta_minutes < time_span: 406​ if delta_minutes < time_span:
407 return False 407​ return False
408 408​
409 return True 409​ return True
410 410​
411 411​
412def _post_testresult(bodhi_api, update, testname, result, url, 412​def _post_testresult(bodhi_api, update, testname, result, url,
413 arch = 'noarch', karma = 0, doreport='onchange'): 413​ arch = 'noarch', karma = 0, doreport='onchange'):
414 '''Post comment and karma to bodhi 414​ '''Post comment and karma to bodhi
415 415​
416 :param str update: the **title** of the update comment on 416​ :param str update: the **title** of the update comment on
417 :param str testname: the name of the test 417​ :param str testname: the name of the test
418 :param str result: the result of the test 418​ :param str result: the result of the test
419 :param str url: url of the result of the test 419​ :param str url: url of the result of the test
420 :param str arch: tested architecture (default ``noarch``) 420​ :param str arch: tested architecture (default ``noarch``)
421 :param int karma: karma points (default ``0``) 421​ :param int karma: karma points (default ``0``)
Show All 21 Lines
443 comment = 'Taskotron: %s test %s on %s. Result log: %s ' \ 443​ comment = 'Taskotron: %s test %s on %s. Result log: %s ' \
444 '(results are informative only)' % (testname, result, arch, url) 444​ '(results are informative only)' % (testname, result, arch, url)
445 try: 445​ try:
446 (old_result, comment_time) = _already_commented(bodhi_api, update, testname, arch) 446​ (old_result, comment_time) = _already_commented(bodhi_api, update, testname, arch)
447 447​
448 comment_needed = _is_comment_needed(old_result, comment_time, result) 448​ comment_needed = _is_comment_needed(old_result, comment_time, result)
449 449​
450 if not comment_needed and doreport != 'all': 450​ if not comment_needed and doreport != 'all':
451 log.info('Current test result is already present in bodhi.') 451​ log.debug('Up-to-date test result is already present in Bodhi: %s %s',
452​ update, result)
452 return True 453​ return True
453 454​
454 bodhi_update = bodhi_api.query_update(update) 455​ bodhi_update = bodhi_api.query_update(update)
455 parsed_results = [] 456​ parsed_results = []
456 for found_comment in bodhi_update['comments']: 457​ for found_comment in bodhi_update['comments']:
457 if found_comment['author'] == Config.fas_username: 458​ if found_comment['author'] == Config.fas_username:
458 parsed_results.append(_parse_result_from_comment(found_comment)) 459​ parsed_results.append(_parse_result_from_comment(found_comment))
459 460​
460 kojitag = 'updates-testing' 461​ kojitag = 'updates-testing'
461 if bodhi_update['request'] == 'stable' or bodhi_update['status'] == 'stable': 462​ if bodhi_update['request'] == 'stable' or bodhi_update['status'] == 'stable':
462 kojitag = 'updates' 463​ kojitag = 'updates'
463 464​
464 new_result = {'time':datetime.datetime.utcnow(), 'testname':testname, 465​ new_result = {'time':datetime.datetime.utcnow(), 'testname':testname,
465 'result':result, 'arch':arch} 466​ 'result':result, 'arch':arch}
466 467​
467 send_email = _is_comment_email_needed(update, parsed_results, 468​ send_email = _is_comment_email_needed(update, parsed_results,
468 new_result, kojitag) 469​ new_result, kojitag)
469 470​
470 471​
471 if not bodhi_api.client.comment(update, comment, karma, send_email): 472​ if not bodhi_api.client.comment(update, comment, karma, send_email):
472 log.error('Could not post a comment to Bodhi. %r, %r, %r, %r', 473​ log.error('Could not post a comment to Bodhi. %r, %r, %r, %r',
473 update, comment, karma, send_email) 474​ update, comment, karma, send_email)
474 return False 475​ return False
475 476​
476 log.info('The test result was sent to bodhi successfully.') 477​ log.debug('Test result successfully submitted to Bodhi: %s %s',
478​ update, result)
477 479​
478 except Exception as e: 480​ except Exception as e:
479 log.exception(e) 481​ log.exception(e)
480 return False 482​ return False
481 483​
482 return True 484​ return True
View Options

libtaskotron/koji_utils.py

Show First 20 Lines • Show All 199 Lines • ▼ Show 20 Line(s)197 def get_tagged_rpms(self, tag, dest, arches=['all'], debuginfo=False,
200 200​
201 Note: This works basically the same as :meth:`get_nvr_rpms`, it just 201​ Note: This works basically the same as :meth:`get_nvr_rpms`, it just
202 downloads a lot of builds instead of a single one. For description of 202​ downloads a lot of builds instead of a single one. For description of
203 all shared parameters and return values, please see that method. 203​ all shared parameters and return values, please see that method.
204 204​
205 :param str tag: Koji tag to be queried for available builds, e.g. 205​ :param str tag: Koji tag to be queried for available builds, e.g.
206 ``f20-updates-pending`` 206​ ``f20-updates-pending``
207 ''' 207​ '''
208 log.debug('Querying Koji for tag: %s' % tag) 208​ log.info('Querying Koji for tag: %s' % tag)
209 tag_data = self.session.listTagged(tag) 209​ tag_data = self.session.listTagged(tag)
210 210​
211 nvrs = ["%(nvr)s" % x for x in tag_data] 211​ nvrs = ["%(nvr)s" % x for x in tag_data]
212 rpms = [] 212​ rpms = []
213 log.info("Fetching %s builds for tag: %s", len(nvrs), tag) 213​ log.info("Fetching %s builds for tag: %s", len(nvrs), tag)
214 log.debug('Builds to be downloaded:\n %s', '\n '.join(nvrs)) 214​ log.debug('Builds to be downloaded:\n %s', '\n '.join(nvrs))
215 215​
216 for nvr in nvrs: 216​ for nvr in nvrs:
Show All 26 Lines