Differential D254

Testing linters
AbandonedPublic
Actions

Authored by jskladan on Oct 16 2014, 11:37 AM.

Details

Reviewers
kparal
Summary

Bogus

Test Plan

None

Diff Detail

Repository
rLTRN libtaskotron
Branch
feature/linter
Lint
Lint SkippedExcuse: pyflakes not installed
Unit
No Unit Test Coverage
jskladan retitled this revision from to Testing linters.Oct 16 2014, 11:37 AM
jskladan updated this object.
jskladan edited the test plan for this revision. (Show Details)
jskladan added a reviewer: kparal.
jskladan abandoned this revision.Oct 16 2014, 4:21 PM

Revision Contents

PathPackages
AM.arclint (9 lines)
Mlibtaskotron/arch_utils.py (4 lines)

Diff 712

View Options

.arclint

  • This file was added.
1​{
2​ "linters": {
3​ "pyflakes lint": {
4​ "type": "pyflakes",
5​ "include": "(\\.py$)"
6​ }
7​ }
8​}
9​
View Options

libtaskotron/arch_utils.py

Show All 19 Lines8class Arches():
20 base = ['i386', 'x86_64', 'armhfp'] 20​ base = ['i386', 'x86_64', 'armhfp']
21 21​
22 #: meta architectures 22​ #: meta architectures
23 meta = ['noarch', 'src'] 23​ meta = ['noarch', 'src']
24 24​
25def basearch(arch=None): 25​def basearch(arch=None):
26 ''' 26​ '''
27 This returns the 'base' architecture identifier for a specified architecture 27​ This returns the 'base' architecture identifier for a specified architecture
28​
29​
28 (e.g. ``i386`` for ``i[3-6]86``), to be used by YUM etc. 30​ (e.g. ``i386`` for ``i[3-6]86``), to be used by YUM etc.
29 31​
30 :param str arch: an architecture to be converted to a basearch. If ``None``, 32​ :param str arch: an architecture to be converted to a basearch. If ``None``,
31 then the arch of the current machine is used. 33​ then the arch of the current machine is used.
32 :return: basearch, or ``arch`` if no basearch was found for it 34​ :return: basearch, or ``arch`` if no basearch was found for it
33 :rtype: str 35​ :rtype: str
34 ''' 36​ '''
35 if arch is None: 37​ if arch is None:
36 arch = os.uname()[4] 38​ arch = os.uname()[4]
37 if arch in ['i386', 'i486', 'i586', 'i686']: 39​ if arch in ['i386', 'i486', 'i586', 'i686']:
38 arch = 'i386' 40​ arch = 'i386'
39 if arch in ['armhfp', 'arm7hl']: 41​ if arch in ['armhfp', 'arm7hl']:
40 arch = 'armhfp' 42​ arch = 'armhfp'
41 return arch 43​ return arch
42No newline at end of file ​