Differential D252

Do not hardcode links to release criteria on blocker proposal page
ClosedPublic
Actions

Authored by mkrizek on Oct 15 2014, 4:25 PM.

Details

Reviewers
tflink
Maniphest Tasks
T360: links to release criteria on blocker proposal page are hard-coded
Commits
rBLKR7c881daabe78: Do not hardcode links to release criteria on blocker proposal page
Summary

Fixes T360

Test Plan

Works on my dev instance

Diff Detail

Repository
rBLKR blockerbugs
Lint
Lint Skipped
Unit
Unit Tests Skipped
mkrizek retitled this revision from to Do not hardcode links to release criteria on blocker proposal page.Oct 15 2014, 4:25 PM
mkrizek updated this object.
mkrizek edited the test plan for this revision. (Show Details)
mkrizek added a reviewer: tflink.
mkrizek added a task: T360: links to release criteria on blocker proposal page are hard-coded.
tflink accepted this revision.Oct 15 2014, 4:40 PM

LGTM

This revision is now accepted and ready to land.Oct 15 2014, 4:40 PM
mkrizek closed this revision.Oct 15 2014, 5:30 PM
mkrizek updated this revision to Diff 705.

Closed by commit rBLKR7c881daabe78 (authored by @mkrizek).

Revision Contents

Diff 705

View Options

blockerbugs/controllers/main.py

Show First 20 Lines • Show All 356 Lines • ▼ Show 20 Line(s)
357@fas_login_required 357​@fas_login_required
358def propose_bug(): 358​def propose_bug():
359 user_info = UserInfo.query.filter_by(fas_login=g.fas_user.username).first() 359​ user_info = UserInfo.query.filter_by(fas_login=g.fas_user.username).first()
360 if not user_info or not user_info.bz_user: 360​ if not user_info or not user_info.bz_user:
361 return redirect(url_for('.fas_bugzilla')) 361​ return redirect(url_for('.fas_bugzilla'))
362 362​
363 bugform = BugProposeForm() 363​ bugform = BugProposeForm()
364 bugform.bz_user.data = user_info.bz_user 364​ bugform.bz_user.data = user_info.bz_user
365 bugform.release.choices = [(r.id, r.number) for r in Release.query.all()] ​
366 bugform.milestone.choices = [(m.id, m.name) for m in Milestone.query.filter_by(active=True).all()] 365​ bugform.milestone.choices = [(m.id, m.name) for m in Milestone.query.filter_by(active=True).all()]
367 366​
368 if bugform.validate_on_submit(): 367​ if bugform.validate_on_submit():
369 app.logger.debug('bugid: %i' % bugform.bugid.data) 368​ app.logger.debug('bugid: %i' % bugform.bugid.data)
370 app.logger.debug('bz_user: %s' % user_info.bz_user) 369​ app.logger.debug('bz_user: %s' % user_info.bz_user)
371 app.logger.debug('milestone: %i' % bugform.milestone.data) 370​ app.logger.debug('milestone: %i' % bugform.milestone.data)
372 app.logger.debug('blocker: %s' % str(bugform.blocker.data)) 371​ app.logger.debug('blocker: %s' % str(bugform.blocker.data))
373 app.logger.debug('freeze_exception: %s' % str(bugform.freeze_exception.data)) 372​ app.logger.debug('freeze_exception: %s' % str(bugform.freeze_exception.data))
▲ Show 20 Lines • Show All 54 Lines • Show Last 20 Lines
View Options

blockerbugs/templates/propose_bug.html

Show First 20 Lines • Show All 132 Lines • ▼ Show 20 Line(s)121 {% endif %}
133 </table> 133​ </table>
134 </div> 134​ </div>
135 <div class="eight columns"> 135​ <div class="eight columns">
136 <div class="panel radius"> 136​ <div class="panel radius">
137 <h5>Blocker</h5> 137​ <h5>Blocker</h5>
138 A release blocking bug is a bug which is judged severe 138​ A release blocking bug is a bug which is judged severe
139 enough to justify blocking release until it is fixed. 139​ enough to justify blocking release until it is fixed.
140 Blocker bugs generally violate a release criterion 140​ Blocker bugs generally violate a release criterion
141 (<a href="https://fedoraproject.org/wiki/Fedora_19_Alpha_Release_Criteria">alpha</a>, 141​ (<a href="https://fedoraproject.org/wiki/Fedora_{{ release }}_Alpha_Release_Criteria">alpha</a>,
142 <a href="https://fedoraproject.org/wiki/Fedora_19_Beta_Release_Criteria">beta</a>, 142​ <a href="https://fedoraproject.org/wiki/Fedora_{{ release }}_Beta_Release_Criteria">beta</a>,
143 <a href="https://fedoraproject.org/wiki/Fedora_19_Final_Release_Criteria">final</a>) 143​ <a href="https://fedoraproject.org/wiki/Fedora_{{ release }}_Final_Release_Criteria">final</a>)
144 and follow the <a href="https://fedoraproject.org/wiki/QA:SOP_blocker_bug_process">blocker SOP</a>. 144​ and follow the <a href="https://fedoraproject.org/wiki/QA:SOP_blocker_bug_process">blocker SOP</a>.
145 145​
146 <h5>Freeze Exception</h5> 146​ <h5>Freeze Exception</h5>
147 Freeze exception bugs are generally not possible to fix 147​ Freeze exception bugs are generally not possible to fix
148 with an update after release but do not qualify as 148​ with an update after release but do not qualify as
149 release blocking. Freeze exception bugs follow the 149​ release blocking. Freeze exception bugs follow the
150 <a href="https://fedoraproject.org/wiki/QA:SOP_freeze_exception_bug_process"> 150​ <a href="https://fedoraproject.org/wiki/QA:SOP_freeze_exception_bug_process">
151 freeze exception SOP</a>. 151​ freeze exception SOP</a>.
Show All 22 Lines173 <div class="six columns">
174 174​
175 <div class="panel radius" id="justification-explain"> 175​ <div class="panel radius" id="justification-explain">
176 <h5>Why Require Justification?</h5> 176​ <h5>Why Require Justification?</h5>
177 Proposing a bug as either blocker or freeze 177​ Proposing a bug as either blocker or freeze
178 exception requires review by Fedora contributors. 178​ exception requires review by Fedora contributors.
179 This process is much more straight forward when 179​ This process is much more straight forward when
180 there is a clear reason why a bug has been proposed. 180​ there is a clear reason why a bug has been proposed.
181 If you are proposing a blocker, please cite a violated 181​ If you are proposing a blocker, please cite a violated
182 release criterion ( 182​ release criterion
183 <a href="https://fedoraproject.org/wiki/Fedora_{{ release }}_Alpha_Release_Criteria">alpha</a>, 183​ (<a href="https://fedoraproject.org/wiki/Fedora_{{ release }}_Alpha_Release_Criteria">alpha</a>,
184 <a href="https://fedoraproject.org/wiki/Fedora_{{ release }}_Beta_Release_Criteria">beta</a>, 184​ <a href="https://fedoraproject.org/wiki/Fedora_{{ release }}_Beta_Release_Criteria">beta</a>,
185 <a href="https://fedoraproject.org/wiki/Fedora_{{ release }}_Final_Release_Criteria">final</a>) 185​ <a href="https://fedoraproject.org/wiki/Fedora_{{ release }}_Final_Release_Criteria">final</a>)
186 if possible. 186​ if possible.
187 </div> 187​ </div>
188 </div> 188​ </div>
189 </div> 189​ </div>
190 </div> 190​ </div>
191 </fieldset> 191​ </fieldset>
Show All 15 Lines