Depcheck - transform the repo args from CLI to dict
ClosedPublic
Actions

Authored by jskladan on Oct 15 2014, 8:57 AM.

Details

Reviewers

Maniphest Tasks

T355: depcheck crashes when ran from cmdline

Commits

rDEPCKaf6b2c1afec0: Transform the repo args from CLI to dict

Summary

The CLI-call of depcheck did not reflect the changes in the rest of the
code. The repos argument must be provided as a dict (was list).

Test Plan

./run_depcheck.py -r /tmp/depcheck_scenarios1pDScq/repo_current/ -- /tmp/depcheck_scenarios1pDScq/repo_updates/bar-0.1-1.fc19.noarch.rpm

Repository

rDEPCK task-depcheck

Lint

Lint Skipped

Unit

Unit Tests Skipped

jskladan retitled this revision from to Transform the repo args from CLI to dict.Oct 15 2014, 8:57 AM

jskladan updated this object.

jskladan edited the test plan for this revision. (Show Details)

jskladan added reviewers: tflink, kparal.

jskladan retitled this revision from Transform the repo args from CLI to dict to Depcheck - transform the repo args from CLI to dict.

Looks good to me.

This revision is now accepted and ready to land.Oct 15 2014, 10:34 AM

Closed by commit rDEPCKaf6b2c1afec0 (authored by @jskladan).

			Path	Packages
M			depcheck/__init__.py (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	697	97f1dc6		Oct 15 2014, 8:57 AM	★	★
Diff 2	698	97f1dc6	- This can actually be done much simpler	Oct 15 2014, 10:48 AM	★	★
Diff 3	701	97f1dc6	Commit rDEPCKaf6b2c1afec095784f1840ce347e449383b178f9	Oct 15 2014, 12:46 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
9cb51c3657fb	b3927d5da9bd	1fa92f452fa5	Josef Skladanka	This can actually be done much simpler	Oct 15 2014, 10:48 AM
1fa92f452fa5	2dfc2a491243	97f1dc64074b	Josef Skladanka	Transform the repo args from CLI to dict (Show More…)	Oct 15 2014, 8:54 AM

Show First 20 Lines • Show All 146 Lines • ▼ Show 20 Line(s)		131	def depcheck_cli():
147		147
148	args = parser.parse_args()	148		args = parser.parse_args()
149	# autodetect arch if none is passed in	149		# autodetect arch if none is passed in
150	arch = args.arch	150		arch = args.arch
151	if arch is None:	151		if arch is None:
152	arch = platform.machine()	152		arch = platform.machine()
153		153
154		154
		155		repos = dict([(repo, repo) for repo in args.repos])
		156
155	try:	157		try:
156	print run(args.rpm, arch, args.repos, args.format)	158		print run(args.rpm, arch, repos, args.format)
157	except KeyboardInterrupt, e:	159		except KeyboardInterrupt, e:
158	print >> sys.stderr, ("\n\nExiting on user cancel.")	160		print >> sys.stderr, ("\n\nExiting on user cancel.")
159	sys.exit(1)	161		sys.exit(1)
160		162
161		163