Differential D244

bodhi_utils: fix typo error
ClosedPublic
Actions

Authored by kparal on Oct 9 2014, 1:19 PM.

Details

Reviewers
garretraziel
Commits
rLTRNa153a5141be5: bodhi_utils: fix typo error
Summary

This was in a hardly reachable code, so nobody noticed. Thanks Jan
Sedlak for spotting this.

Test Plan

I don't think it's worth adding unit tests, because it's a lot of work and not being executed anyway. So, no real testing performed. I'm just believing it.

Diff Detail

Repository
rLTRN libtaskotron
Lint
Lint Skipped
Unit
Unit Tests Skipped
kparal retitled this revision from to bodhi_utils: fix typo error.Oct 9 2014, 1:19 PM
kparal updated this object.
kparal edited the test plan for this revision. (Show Details)
kparal added a reviewer: garretraziel.
garretraziel accepted this revision.Oct 9 2014, 1:21 PM

After long examination, it seems rather okay.

This revision is now accepted and ready to land.Oct 9 2014, 1:21 PM
kparal closed this revision.Oct 9 2014, 1:24 PM
kparal updated this revision to Diff 691.

Closed by commit rLTRNa153a5141be5 (authored by @kparal).

Revision Contents

PathPackages
Mlibtaskotron/bodhi_utils.py (5 lines)

Diff 691

View Options

libtaskotron/bodhi_utils.py

Show First 20 Lines • Show All 151 Lines • ▼ Show 20 Line(s)78 def build2update(self, builds, strict=False):
152 # some builds might have been added to both @var failures and 152​ # some builds might have been added to both @var failures and
153 # @var build2update. That's probably a Bodhi fault, because a build 153​ # @var build2update. That's probably a Bodhi fault, because a build
154 # should not be part of two different updates. If that happens, remove 154​ # should not be part of two different updates. If that happens, remove
155 # it from @var build2update and keep it in @var failures. 155​ # it from @var build2update and keep it in @var failures.
156 for build in failures: 156​ for build in failures:
157 if build in build2update: 157​ if build in build2update:
158 log.warn("The build %s is a part of two different updates: '%s'" 158​ log.warn("The build %s is a part of two different updates: '%s'"
159 " and '%s'. That's probably a bug in Bodhi." % (build, 159​ " and '%s'. That's probably a bug in Bodhi." % (build,
160 failures[build]['title'], build2update[build]['title']) 160​ failures[build]['title'], build2update[build]['title']))
161 ) 161​ del build2update[build]
162 del build2update.pop[build] ​
163 162​
164 return (build2update, failures) 163​ return (build2update, failures)