Differential D238

splitting out koji build trigger checks, adding debug log messages, adding delay. Fixes T341
AbandonedPublic
Actions

Authored by tflink on Sep 30 2014, 4:46 AM.

Details

Reviewers

mkrizek

Maniphest Tasks

T341: taskotron-trigger is not scheduling jobs for koji build messages in dev, stg or prod

Summary

adding delay before grabbing data from koji after fedmsg, workaround to fix T341

Test Plan

unit tests pass, code is working locally for now, similar delay has been working on dev

Diff Detail

Repository

rTRGR taskotron-trigger

Branch

feature/T341-koji-info-issue

Lint

No Linters Available

Unit

No Unit Test Coverage

tflink retitled this revision from to splitting out koji build trigger checks, adding debug log messages, adding delay. Fixes T341.Sep 30 2014, 4:46 AM

tflink updated this object.

tflink edited the test plan for this revision. (Show Details)

tflink added a reviewer: mkrizek.

tflink added a task: T341: taskotron-trigger is not scheduling jobs for koji build messages in dev, stg or prod.

Herald added a subscriber: tflink. · View Herald TranscriptSep 30 2014, 4:46 AM

Sorry for hi-jacking, please have a look at D240.

superseded by D240

Revision Contents

			Path	Packages
M			jobtriggers/koji_build_msg.py (24 lines)

Commit	Tree	Parents	Author	Summary	Date
583fb98e8d71	6dc7225bd510	a2fb580212b6	Tim Flink	splitting out koji build trigger checks, adding debug log messages, adding… (Show More…)	Sep 29 2014, 2:54 PM

Diff 664

View Options

jobtriggers/koji_build_msg.py

1	import koji	1	import koji
2	import fedmsg	2	import fedmsg
3	import fedmsg.encoding	3	import fedmsg.encoding
		4	import time
4		5
5	from . import utils, config	6	from . import utils, config
6	from . import JobTrigger	7	from . import JobTrigger
7		8
8	ITEM_TYPE = 'koji_build'	9	ITEM_TYPE = 'koji_build'
9		10
10	class KojiBuildCompletedJobTrigger(JobTrigger):	11	class KojiBuildCompletedJobTrigger(JobTrigger):
11	topic = "org.fedoraproject.prod.buildsys.build.state.change"	12	topic = "org.fedoraproject.prod.buildsys.build.state.change"
12	jsonify = False	13	jsonify = False
13	config_key = 'taskotron.kojibuildcompletedjobtrigger.enabled'	14	config_key = 'taskotron.kojibuildcompletedjobtrigger.enabled'
14		15
15	def __init__(self, args, *kw):	16	def __init__(self, args, *kw):
16	super(KojiBuildCompletedJobTrigger, self).__init__(args, *kw)	17	super(KojiBuildCompletedJobTrigger, self).__init__(args, *kw)
17		18
18	def consume(self, message):	19	def consume(self, message):
19	usable_message = fedmsg.encoding.loads(message.body)	20	usable_message = fedmsg.encoding.loads(message.body)
20		21
21	release = usable_message['msg']['release']	22	release = usable_message['msg']['release']
22	state = usable_message['msg']['new']	23	state = usable_message['msg']['new']
23	instance = usable_message['msg']['instance']	24	instance = usable_message['msg']['instance']
24		25
		26	name = usable_message['msg']['name']
		27	version = usable_message['msg']['version']
		28	buildid = usable_message['msg']['build_id']
		29
		30	envr = "%s-%s-%s" % (name, version, release)
		31
25	if not instance == 'primary':	32	if not instance == 'primary':
		33	self.log.debug('rejecting message not from primary koji instance (%s)' % envr)
26	return	34	return
27		35
28	# filter builds	36	# filter builds
29	if state != koji.BUILD_STATES['COMPLETE'] or utils.blacklist_releases(release):	37	if state != koji.BUILD_STATES['COMPLETE']:
		38	self.log.debug('rejecting message for not being a completion message (%s)' % envr)
30	return	39	return
31		40
32	name = usable_message['msg']['name']	41	# do not schledule jobs for blacklisted releases
33	version = usable_message['msg']['version']	42	if utils.blacklist_releases(release):
34	buildid = usable_message['msg']['build_id']	43	self.log.debug('rejecting message from blacklisted release (%s)' % envr)
		44	return
35		45
36	envr = "%s-%s-%s" % (name, version, release)	46	self.log.debug('should be scheduling job for %s' % envr)
		47
		48	# add a short delay before attempting to get data from koji as a workaround
		49	# for T341
		50	time.sleep(2)
37		51
38	arches = utils.get_arches(buildid=buildid)	52	arches = utils.get_arches(buildid=buildid)
39		53
40	self.trigger_tasks(envr, ITEM_TYPE, config.koji_build_completed_tasks, arches)	54	self.trigger_tasks(envr, ITEM_TYPE, config.koji_build_completed_tasks, arches)