| mkrizek |
adding milestone/current api endpoint as a convenience method and a .simple() dict representation of milestones
added unit test, tested locally in dev env
| Lint Skipped |
| Unit Tests Skipped |
| Path | Packages | |||
|---|---|---|---|---|
| M | blockerbugs/controllers/api/api.py (5 lines) | |||
| M | blockerbugs/models/milestone.py (10 lines) | |||
| M | testing/test_api.py (9 lines) |
| Commit | Tree | Parents | Author | Summary | Date |
|---|---|---|---|---|---|
| b13eb272befc | db490956b390 | 584fb6d95ce7 | Tim Flink | adding milestone/current api endpoint. Fixes T328 (Show More…) | Sep 9 2014, 2:23 AM |
| Show First 20 Lines • Show All 227 Lines • ▼ Show 20 Line(s) | 206 | def update_spin(rel_num, milestone_version, spin_id): | |||
|---|---|---|---|---|---|
| 228 | if 'spin_type' in data: | 228 | if 'spin_type' in data: | ||
| 229 | spin.spin_type = data['spin_type'] | 229 | spin.spin_type = data['spin_type'] | ||
| 230 | if 'date_created' in data: | 230 | if 'date_created' in data: | ||
| 231 | spin.date_created = parse_date(data['date_created']) | 231 | spin.date_created = parse_date(data['date_created']) | ||
| 232 | db.session.add(spin) | 232 | db.session.add(spin) | ||
| 233 | db.session.commit() | 233 | db.session.commit() | ||
| 234 | return JsonResponse(status=200) | 234 | return JsonResponse(status=200) | ||
| 235 | 235 | | |||
| 236 | 236 | @api_v0.route('/milestones/current') | |||
| 237 | def get_current_milestone(): | ||||
| 238 | current_milestone = get_or_404(Milestone, current=True) | ||||
| 239 | return JsonResponse(current_milestone.simple()) | ||||
| Show First 20 Lines • Show All 54 Lines • ▼ Show 20 Line(s) | 47 | def __init__(self, release, version, blocker_tracker, fe_tracker, | |||
|---|---|---|---|---|---|
| 55 | self.last_bug_sync = None | 55 | self.last_bug_sync = None | ||
| 56 | self.current = current | 56 | self.current = current | ||
| 57 | if succeeds: | 57 | if succeeds: | ||
| 58 | self.succeeds = succeeds | 58 | self.succeeds = succeeds | ||
| 59 | 59 | | |||
| 60 | def __repr__(self): | 60 | def __repr__(self): | ||
| 61 | number = self.release.number if self.release else -1 | 61 | number = self.release.number if self.release else -1 | ||
| 62 | return 'milestone: %d-%s' % (number, self.version) | 62 | return 'milestone: %d-%s' % (number, self.version) | ||
| 63 | | ||||
| 64 | def simple(self): | ||||
| 65 | return {'id': self.id, | ||||
| 66 | 'release': self.release.number, | ||||
| 67 | 'version': self.version, | ||||
| 68 | 'name': self.name, | ||||
| 69 | 'blocker_tracker': self.blocker_tracker, | ||||
| 70 | 'fe_tracker': self.fe_tracker, | ||||
| 71 | 'current': self.current, | ||||
| 72 | } | ||||
| Show All 18 Lines | 17 | class TestRestAPI(object): | |||
|---|---|---|---|---|---|
| 19 | def setup_class(cls): | 19 | def setup_class(cls): | ||
| 20 | db.session.rollback() | 20 | db.session.rollback() | ||
| 21 | db.drop_all() | 21 | db.drop_all() | ||
| 22 | db.create_all() | 22 | db.create_all() | ||
| 23 | cls.client = app.test_client() | 23 | cls.client = app.test_client() | ||
| 24 | cls.release = add_release(99) | 24 | cls.release = add_release(99) | ||
| 25 | cls.milestone = add_milestone(cls.release, 'final', 100, 101, | 25 | cls.milestone = add_milestone(cls.release, 'final', 100, 101, | ||
| 26 | '99-final', True) | 26 | '99-final', True) | ||
| 27 | cls.milestone.current = True | ||||
| 28 | | ||||
| 27 | cls.milestone2 = add_milestone(cls.release, 'beta', 200, 201, | 29 | cls.milestone2 = add_milestone(cls.release, 'beta', 200, 201, | ||
| 28 | '99-beta') | 30 | '99-beta') | ||
| 29 | bug1 = add_bug(9000, 'testbug1', cls.milestone) | 31 | bug1 = add_bug(9000, 'testbug1', cls.milestone) | ||
| 30 | bug1.accepted_fe = True | 32 | bug1.accepted_fe = True | ||
| 31 | bug2 = add_bug(9002, 'testbug2', cls.milestone) | 33 | bug2 = add_bug(9002, 'testbug2', cls.milestone) | ||
| 32 | bug2.accepted_blocker = False | 34 | bug2.accepted_blocker = False | ||
| 33 | bug2.proposed_fe = True | 35 | bug2.proposed_fe = True | ||
| 34 | cls.update_pending_stable = add_update(u'test-pending-stable.fc99', | 36 | cls.update_pending_stable = add_update(u'test-pending-stable.fc99', | ||
| ▲ Show 20 Lines • Show All 247 Lines • ▼ Show 20 Line(s) | 283 | def test_update_spin_auth_failed(self): | |||
| 282 | spin_id = Spin.query.filter_by(name='test-spin2').first().id | 284 | spin_id = Spin.query.filter_by(name='test-spin2').first().id | ||
| 283 | url = '/api/v0/milestones/99/final/spins/%d' % (spin_id) | 285 | url = '/api/v0/milestones/99/final/spins/%d' % (spin_id) | ||
| 284 | update_data = {'date_created': 'foo', } | 286 | update_data = {'date_created': 'foo', } | ||
| 285 | resp = self.client.put(url, data=json.dumps(update_data), | 287 | resp = self.client.put(url, data=json.dumps(update_data), | ||
| 286 | content_type='application/json') | 288 | content_type='application/json') | ||
| 287 | assert resp.status_code == httplib.FORBIDDEN | 289 | assert resp.status_code == httplib.FORBIDDEN | ||
| 288 | error = json.loads(resp.data)['error'] | 290 | error = json.loads(resp.data)['error'] | ||
| 289 | assert error['code'] == errors.AuthFailedError.code | 291 | assert error['code'] == errors.AuthFailedError.code | ||
| 292 | | ||||
| 293 | def test_get_current_milestone(self): | ||||
| 294 | url = '/api/v0/milestones/current' | ||||
| 295 | resp = self.client.get(url) | ||||
| 296 | assert resp.status_code == httplib.OK | ||||
| 297 | data = json.loads(resp.data) | ||||
| 298 | assert data['name'] == self.milestone.name | ||||