Differential D225

depcheck input format change
ClosedPublic
Actions

Authored by lbrabec on Aug 28 2014, 10:01 AM.

Details

Reviewers
kparal
tflink
jskladan
Maniphest Tasks
T310: Update depcheck, so it can parse the new output of `yumrepoinfo` directive
Commits
rDEPCK399425b7b706: depcheck input format change
Summary

yumrepoinfo will accept multiple arches and output format will be changed, this
diff will ensure that depcheck will accept the new format.

Test Plan

python runtask.py -t koji_tag -i f20-updates-testing-pending ../task-depcheck/depcheck.yml
with new yumrepoinfo directive

Diff Detail

Repository
rDEPCK task-depcheck
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
lbrabec retitled this revision from to depcheck input format change.Aug 28 2014, 10:01 AM
lbrabec updated this object.
lbrabec edited the test plan for this revision. (Show Details)
lbrabec added a reviewer: jskladan.
tflink accepted this revision.Sep 2 2014, 12:56 PM

LGTM

This revision is now accepted and ready to land.Sep 2 2014, 12:56 PM
jskladan accepted this revision.Mar 4 2015, 2:54 PM

Good for me, the testing was done.

Closed by commit rDEPCK399425b7b706: depcheck input format change (authored by Lukas Brabec <lukas.sparrow@gmail.com>, committed by Lukas Brabec <lbrabec@redhat.com>). · Explain WhyMar 4 2015, 4:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathPackages
Mrun_depcheck.py (5 lines)

Diff 834

View Options

run_depcheck.py

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Line(s)40 for name, url in repo.items():
43 repositories[name] = url 43​ repositories[name] = url
44 44​
45 elif isinstance(repos, dict): 45​ elif isinstance(repos, dict):
46 repositories = repos 46​ repositories = repos
47 47​
48 else: 48​ else:
49 raise exc.DepcheckException('Unsupported type of repos arg') 49​ raise exc.DepcheckException('Unsupported type of repos arg')
50 50​
51​
52​ for name, val in repositories.items():
53​ if isinstance(val, dict):
54​ repositories[name] = val[arch]
55​
51 return depcheck.run(rpms, arch, repositories, report_format, workdir) 56​ return depcheck.run(rpms, arch, repositories, report_format, workdir)
52 57​
53if __name__ == '__main__': 58​if __name__ == '__main__':
54 depcheck.depcheck_cli() 59​ depcheck.depcheck_cli()