All arbitrary lists were moved to libtaskotron.arch_utils.
Arch strings and lists all over the code were replaced with atributes of class Arches (probably WIP).
Details
py.test -F testing/
Diff Detail
- Repository
- rLTRN libtaskotron
- Lint
Lint Skipped - Unit
Unit Tests Skipped
A few things to consider below
libtaskotron/arch_utils.py | ||
---|---|---|
10 | Maybe all the attributes can be class attributes? It will make the imports easier: from libtaskotron.arch_utils import Arches and then Arches don't clash with arches (which is a usual variable name) :-) | |
11–18 | I'm not sure we gain too much by using attributes here instead of using plain strings inside our code. E.g.: if Arches.i386 in arches: instead of if 'i386' in arches: The second one seems simpler. | |
20 | Let's include this once we need it. | |
22 | It depends on the use case, but I think all would be better to include really everything, i.e. lines 10-17. | |
25 | If we keep this, I'd rename it to x86_32 to make it clear. | |
libtaskotron/directives/bodhi_directive.py | ||
129 | If we change all to include really all, let's make sure it works well for Bodhi. | |
133–134 | I think the old approach is a bit more readable, I'd stick with it. | |
libtaskotron/directives/yumrepoinfo_directive.py | ||
90–91 | This approach should be used in this case. | |
libtaskotron/rpm_utils.py | ||
14–15 | Let's move this to arch_utils? |
Doc please.