Differential D218

Fix traceback when removing upgradepath from scheduling
ClosedPublic
Actions

Authored by mkrizek on Aug 21 2014, 12:01 PM.

Details

Reviewers
tflink
Commits
rTRGRf1314c04464b: Fix traceback when removing upgradepath from scheduling
Summary

Traceback (most recent call last):

File "/home/mkrizek/devel/taskotron-trigger/env_trigger/lib/python2.7/site-packages/twisted/internet/base.py", line 1192, in run
  self.mainLoop()
File "/home/mkrizek/devel/taskotron-trigger/env_trigger/lib/python2.7/site-packages/twisted/internet/base.py", line 1201, in mainLoop
  self.runUntilCurrent()
File "/home/mkrizek/devel/taskotron-trigger/env_trigger/lib/python2.7/site-packages/twisted/internet/base.py", line 824, in runUntilCurrent
  call.func(*call.args, **call.kw)
File "/home/mkrizek/devel/taskotron-trigger/env_trigger/lib/python2.7/site-packages/twisted/internet/task.py", line 218, in __call__
  d = defer.maybeDeferred(self.f, *self.a, **self.kw)
  • <exception caught here> --- File "/home/mkrizek/devel/taskotron-trigger/env_trigger/lib/python2.7/site-packages/twisted/internet/defer.py", line 139, in maybeDeferred result = f(*args, **kw) File "/home/mkrizek/devel/taskotron-trigger/jobtriggers/koji_tag_msg.py", line 33, in delayed_consume tasks.remove('upgradepath')

exceptions.ValueError: list.remove(x): x not in list

Test Plan

None

Diff Detail

Repository
rTRGR taskotron-trigger
Lint
Lint Skipped
Unit
Unit Tests Skipped
mkrizek retitled this revision from to Fix traceback when removing upgradepath from scheduling.Aug 21 2014, 12:01 PM
mkrizek updated this object.
mkrizek edited the test plan for this revision. (Show Details)
mkrizek added a reviewer: tflink.
tflink accepted this revision.Aug 21 2014, 2:51 PM

LGTM, good work figuring this out

This revision is now accepted and ready to land.Aug 21 2014, 2:51 PM
mkrizek closed this revision.Aug 21 2014, 3:01 PM
mkrizek updated this revision to Diff 623.

Closed by commit rTRGRf1314c04464b (authored by @mkrizek).

Revision Contents

PathPackages
Mjobtriggers/koji_tag_msg.py (4 lines)

Diff 623

View Options

jobtriggers/koji_tag_msg.py

1​from copy import deepcopy
2​
1import fedmsg 3​import fedmsg
2import fedmsg.encoding 4​import fedmsg.encoding
3import moksha.hub.reactor 5​import moksha.hub.reactor
4 6​
5from twisted.internet.task import LoopingCall 7​from twisted.internet.task import LoopingCall
6 8​
7from . import config 9​from . import config
8from . import JobTrigger 10​from . import JobTrigger
Show All 14 Lines19 def __init__(self, *args, **kw):
23 lc = LoopingCall(self.delayed_consume) 25​ lc = LoopingCall(self.delayed_consume)
24 lc.start(config.fuse_delay) 26​ lc.start(config.fuse_delay)
25 27​
26 def delayed_consume(self): 28​ def delayed_consume(self):
27 if self.queued_tags: 29​ if self.queued_tags:
28 try: 30​ try:
29 for tag in self.queued_tags: 31​ for tag in self.queued_tags:
30 # XXX ugly: do not schedule upgradepath for updates-testing-pending 32​ # XXX ugly: do not schedule upgradepath for updates-testing-pending
31 tasks = config.koji_tag_changed_tasks 33​ tasks = deepcopy(config.koji_tag_changed_tasks)
32 if tag.endswith('testing-pending'): 34​ if tag.endswith('testing-pending'):
33 tasks.remove('upgradepath') 35​ tasks.remove('upgradepath')
34 # it is sufficient to run depcheck and upgradepath only on one arch 36​ # it is sufficient to run depcheck and upgradepath only on one arch
35 # XXX hardcoding X86_64 37​ # XXX hardcoding X86_64
36 self.trigger_tasks(tag, ITEM_TYPE, tasks, ['x86_64']) 38​ self.trigger_tasks(tag, ITEM_TYPE, tasks, ['x86_64'])
37 finally: 39​ finally:
38 self.queued_tags = set() 40​ self.queued_tags = set()
39 else: 41​ else:
Show All 17 Lines