Differential D216

list trigger.cfg as config file in the spec file
ClosedPublic
Actions

Authored by mkrizek on Aug 20 2014, 11:27 AM.

Details

Reviewers

tflink

Commits

rTRGRa70de372fcec: list trigger.cfg as config file in the spec file

Summary

None

Test Plan

None

Diff Detail

Repository

rTRGR taskotron-trigger

Lint

Lint Skipped

Unit

Unit Tests Skipped

mkrizek retitled this revision from to list trigger.cfg as config file in the spec file.Aug 20 2014, 11:27 AM

mkrizek updated this object.

mkrizek edited the test plan for this revision. (Show Details)

mkrizek added a reviewer: tflink.

Herald added a subscriber: tflink. · View Herald TranscriptAug 20 2014, 11:27 AM

taskotron-trigger.spec
61	Does this work? I've always done `%config(noreplace)` instead of the more common file declaration, not used both

Delete previous file declaration

taskotron-trigger.spec
61	Forgot to remove it...

Looks good to me

This revision is now accepted and ready to land.Aug 20 2014, 12:00 PM

Closed by commit rTRGRa70de372fcec (authored by @mkrizek).

Revision Contents

			Path	Packages
M			taskotron-trigger.spec (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	612	4fdeaf1		Aug 20 2014, 11:27 AM	★	★
Diff 2	614	4fdeaf1	Delete previous file declaration	Aug 20 2014, 11:58 AM	★	★
Diff 3	616	4fdeaf1	Commit rTRGRa70de372fcec4e29d758816de6a5ae4d9643c89e	Aug 20 2014, 12:05 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
2c92133602e3	81b363d20d75	4fdeaf19d4cf	Martin Krizek	list trigger.cfg as config file in the spec file (Show More…)	Aug 20 2014, 11:26 AM

Diff 616

View Options

taskotron-trigger.spec

1	Name: taskotron-trigger	1		Name: taskotron-trigger
2	Version: 0.3.5	2		Version: 0.3.5
3	Release: 1%{?dist}	3		Release: 2%{?dist}
4	Summary: Triggering Taskotron jobs via fedmsg.	4		Summary: Triggering Taskotron jobs via fedmsg.
5		5
6	License: GPLv2+	6		License: GPLv2+
7	URL: https://fedorahosted.org/fedora-qa	7		URL: https://fedorahosted.org/fedora-qa
8	Source0: %{name}-%{version}.tar.gz	8		Source0: %{name}-%{version}.tar.gz
9		9
10	BuildArch: noarch	10		BuildArch: noarch
11		11
Show All 39 Lines
51		51
52	%attr(755,root,root) %{_bindir}/jobrunner	52		%attr(755,root,root) %{_bindir}/jobrunner
53		53
54	%config(noreplace) %{_sysconfdir}/logrotate.d/taskotron-trigger	54		%config(noreplace) %{_sysconfdir}/logrotate.d/taskotron-trigger
55		55
56	%dir %attr(755,fedmsg,fedmsg) %{_localstatedir}/log/taskotron-trigger	56		%dir %attr(755,fedmsg,fedmsg) %{_localstatedir}/log/taskotron-trigger
57		57
58	%dir %{_sysconfdir}/taskotron	58		%dir %{_sysconfdir}/taskotron
59	%{_sysconfdir}/taskotron/trigger.cfg
60	%{_sysconfdir}/fedmsg.d/taskotron-trigger.py*	59		%{_sysconfdir}/fedmsg.d/taskotron-trigger.py*
61		60
		61		%config(noreplace) %{_sysconfdir}/taskotron/trigger.cfg
			tflinkUnsubmitted Not Done Does this work? I've always done `%config(noreplace)` instead of the more common file declaration, not used both
			mkrizekAuthorUnsubmitted Not Done Forgot to remove it...
62		62
63	%changelog	63		%changelog
		64		* Wed Aug 20 2014 Martin Krizek <mkrizek@redhat.com> - 0.3.5-2
		65		- list trigger.cfg as config file
		66
64	* Thu Aug 14 2014 Tim Flink <tflink@fedoraproject.org> - 0.3.5-1	67		* Thu Aug 14 2014 Tim Flink <tflink@fedoraproject.org> - 0.3.5-1
65	- change to not schedule upgradepath on *-testing-pending	68		- change to not schedule upgradepath on *-testing-pending
66		69
67	* Mon Jun 30 2014 Tim Flink <tflink@fedoraproject.org> - 0.3.3-1	70		* Mon Jun 30 2014 Tim Flink <tflink@fedoraproject.org> - 0.3.3-1
68	- switching trigger over to use change_source instead of hacking at force build	71		- switching trigger over to use change_source instead of hacking at force build
69	- supporting x86_64-only checks	72		- supporting x86_64-only checks
70		73
71	* Tue Jun 24 2014 Martin Krizek <mkrizek@redhat.com> - 0.3.2-1	74		* Tue Jun 24 2014 Martin Krizek <mkrizek@redhat.com> - 0.3.2-1
Show All 28 Lines