run_rpmlint.py
22–24	Can you please change `RPMLINT` into lower case? Thanks.
24	For example purposes I think it would be better to replace `output.split('\n')` with `[output]`. There is no need to split it per line, it just needs to be a list.

This revision is now accepted and ready to land.Aug 18 2014, 11:54 AM

Closed by commit rRPMLINTfe2f78562ef8 (authored by @lbrabec).

Revision Contents

			Path	Packages
M			rpmlint.yml (1 line)
M			run_rpmlint.py (43 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	602	d6c85f2		Aug 18 2014, 10:19 AM	★	★
Diff 2	603	d6c85f2	Commit rRPMLINTfe2f78562ef8f9af8ea0e5e1290aab4d957a4a1b	Aug 18 2014, 12:43 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
902c096ee66a	c6b0b7be1dc4	d6c85f295d55	Lukas Brabec	rpmlint is now reporting whole koji build (Show More…)	Aug 18 2014, 10:16 AM

Diff 603

View Options

rpmlint.yml

Show All 18 Lines		17	koji:
19	koji_build: ${koji_build}	19		koji_build: ${koji_build}
20	arch: ${arch}	20		arch: ${arch}
21		21
22	- name: run rpmlint on downloaded rpms	22		- name: run rpmlint on downloaded rpms
23	python:	23		python:
24	file: run_rpmlint.py	24		file: run_rpmlint.py
25	callable: run	25		callable: run
26	workdir: ${workdir}	26		workdir: ${workdir}
		27		koji_build: ${koji_build}
27	export: rpmlint_output	28		export: rpmlint_output
28		29
29	- name: report results to resultsdb	30		- name: report results to resultsdb
30	resultsdb:	31		resultsdb:
31	results: ${rpmlint_output}	32		results: ${rpmlint_output}

View Options

run_rpmlint.py

1	import subprocess as sub	1		import subprocess as sub
2	import os	2		import os
3	from libtaskotron import check	3		from libtaskotron import check
4	import sys	4		import sys
5		5
6	def run(workdir = u'.'):	6		def run(koji_build, workdir = u'.'):
7	results = []	7		result = None
8	rpmfiles = [r for r in os.listdir(workdir) if r.split(u'.')[-1] == u'rpm']	8		p = sub.Popen(['rpmlint', '%s' % os.path.abspath(workdir)],
9		9		stdout=sub.PIPE,stderr=sub.PIPE)
10	for rpmfile in rpmfiles:	10		output, errors = p.communicate()
11	result = None	11		retcode = p.returncode
12	p = sub.Popen(['rpmlint', '%s/%s' % (os.path.abspath(workdir), rpmfile)],	12		if retcode == 0:
13	stdout=sub.PIPE,stderr=sub.PIPE)	13		result = 'PASSED'
14	output, errors = p.communicate()	14		else:
15	retcode = p.returncode	15		if retcode == 64 or retcode == 66:
16	if retcode == 0:	16		result = 'FAILED'
17	result = 'PASSED'
18	else:	17		else:
19	if retcode == 64 or retcode == 66:	18		result = 'ABORTED'
20	result = 'FAILED'	19		sys.stderr.write("STDOUT: %s" % output)
21	else:	20		sys.stderr.write("STDERR: %s" % errors)
22	result = 'ABORTED'
23	sys.stderr.write("STDOUT: %s" % output)
24	sys.stderr.write("STDERR: %s" % errors)
25		21
26	summary = 'RPMLINT %s for %s' % (result, rpmfile)	22		summary = 'rpmlint %s for %s' % (result, koji_build)
27	detail = check.CheckDetail(rpmfile, check.ReportType.KOJI_BUILD,	23		detail = check.CheckDetail(koji_build, check.ReportType.KOJI_BUILD,
28	result, summary, output.split('\n'))	24		result, summary, [output])
			kparalUnsubmitted Not Done Can you please change `RPMLINT` into lower case? Thanks.
			kparalUnsubmitted Not Done For example purposes I think it would be better to replace `output.split('\n')` with `[output]`. There is no need to split it per line, it just needs to be a list.
29	results.append(detail)
30		25
31	tapdetails = check.export_TAP(results)	26		tapdetail = check.export_TAP(detail)
32	return tapdetails	27		return tapdetail
33		28
34	if __name__ == '__main__':	29		if __name__ == '__main__':
35	tapout = run()	30		tapout = run()
36		31
37	for result in tapout:	32		for result in tapout:
38	print result	33		print result
39		34

rpmlint is now reporting whole koji buildClosedPublicActions

Details

Diff Detail

Revision Contents

Diff 603

rpmlint.yml

run_rpmlint.py

rpmlint is now reporting whole koji build
ClosedPublic
Actions