allow -pending koji tags
ClosedPublic
Actions

Authored by kparal on Jul 22 2014, 12:40 PM.

Details

Reviewers

tflink
mkrizek

Commits

rUPGR63d2dee631b7: allow -pending koji tags

Summary

Instead of demanding target Koji tags, allow to specify source Koji tags
as well and covert it.

This solves a problem in Taskotron where we are not yet able to
manipulate Koji tags very well.

Test Plan

tested manually, seems to work

Repository

rUPGR task-upgradepath

Lint

Lint Skipped

Unit

Unit Tests Skipped

kparal retitled this revision from to allow -pending koji tags.Jul 22 2014, 12:40 PM

kparal updated this object.

kparal edited the test plan for this revision. (Show Details)

kparal added reviewers: tflink, mkrizek.

Looks good to me

This revision is now accepted and ready to land.Jul 22 2014, 12:43 PM

Closed by commit rUPGR63d2dee631b7 (authored by @kparal).

			Path	Packages
M			upgradepath.py (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	555	0f196f6		Jul 22 2014, 12:40 PM	★	★
Diff 2	556	0f196f6	Commit rUPGR63d2dee631b702b3791eab98f63bffc44500382f	Jul 22 2014, 1:22 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
f132acc54b3b	83ec387db1e9	0f196f6eb0d2	Kamil Páral	allow -pending koji tags (Show More…)	Jul 22 2014, 12:38 PM

Show First 20 Lines • Show All 611 Lines • ▼ Show 20 Line(s)		603	# 'builds in the -pending version of KOJI_TAG get checked.')
612		612
613	logger.debug('Cmdline args: %s', args)	613		logger.debug('Cmdline args: %s', args)
614		614
615	# validate args	615		# validate args
616	if '-testing' in args.koji_tag:	616		if '-testing' in args.koji_tag:
617	parser.error('Koji tags ending in "-testing" are not supported at the '	617		parser.error('Koji tags ending in "-testing" are not supported at the '
618	'moment')	618		'moment')
619		619
		620		# strip unnecessary '-pending' from koji tag, if provided
		621		if args.koji_tag.endswith('-pending'):
		622		args.koji_tag = args.koji_tag[:-len('-pending')]
		623		logger.info('It seems the source instead of the target Koji tag was '
		624		'specified. Assuming this one instead: %s' % args.koji_tag)
		625
620	return args	626		return args
621		627
622		628
623	if __name__ == '__main__':	629		if __name__ == '__main__':
624	try:	630		try:
625	main()	631		main()
626	except KeyboardInterrupt:	632		except KeyboardInterrupt:
627	logger.critical('Interrupted by user, exiting...')	633		logger.critical('Interrupted by user, exiting...')
628	sys.exit(1)	634		sys.exit(1)