Differential D189

add `item` field to results index
ClosedPublic
Actions

Authored by garretraziel on Jul 17 2014, 2:24 PM.

Details

Reviewers
tflink
jskladan
Maniphest Tasks
T279: display `item` in frontend view
Commits
rRSFEfe7e7f6340cd: add `item` field to results index
Summary

Add item to results index (but only when result has it).

Test Plan

Run frontend on data that have and haven't item
field.

Diff Detail

Repository
rRSFE resultsdb_frontend
Lint
Lint Skipped
Unit
Unit Tests Skipped
garretraziel retitled this revision from to add `item` field to results index.Jul 17 2014, 2:24 PM
garretraziel updated this object.
garretraziel edited the test plan for this revision. (Show Details)
garretraziel added a reviewer: jskladan.
This revision is now accepted and ready to land.Jul 22 2014, 11:17 AM
tflink accepted this revision.Jul 22 2014, 11:54 AM
tflink added a reviewer: tflink.

Sorry about the delay on this. Looks good to me

garretraziel closed this revision.Jul 22 2014, 12:29 PM
garretraziel updated this revision to Diff 554.

Closed by commit rRSFEfe7e7f6340cd (authored by Garret Raziel <boloomka@gmail.com>).

Revision Contents

Diff 554

View Options

resultsdb_frontend/templates/results.html

1{% extends "layout.html" %} 1​{% extends "layout.html" %}
2 2​
3{% block body %} 3​{% block body %}
4<table class="table table-striped table-bordered"> 4​<table class="table table-striped table-bordered">
5 <thead> 5​ <thead>
6 <tr> 6​ <tr>
7 <th>ID</th> 7​ <th>ID</th>
8 <th>Submit time (UTC)</th> 8​ <th>Submit time (UTC)</th>
9 <th>Testcase</th> 9​ <th>Testcase</th>
10 <th>Outcome</th> 10​ <th>Outcome</th>
11 <th>Summary</th> 11​ <th>Summary</th>
12​ <th>Item</th>
12 <th>Details</th> 13​ <th>Details</th>
13 <th>Job</th> 14​ <th>Job</th>
14 <th>Log</th> 15​ <th>Log</th>
15 </tr> 16​ </tr>
16 </thead> 17​ </thead>
17 <tbody> 18​ <tbody>
18 {% for result in results.data %} 19​ {% for result in results.data %}
19 <tr> 20​ <tr>
20 <td>{{ result.id }}</td> 21​ <td>{{ result.id }}</td>
21 <td>{{ result.submit_time | replace("T", " ")}}</td> 22​ <td>{{ result.submit_time | replace("T", " ")}}</td>
22 <td><a href="{{ url_for('main.testcase', testcase_name=result.testcase.href.split('/')[-1]) }}">{{ result.testcase.name }}</a></td> 23​ <td><a href="{{ url_for('main.testcase', testcase_name=result.testcase.href.split('/')[-1]) }}">{{ result.testcase.name }}</a></td>
23 <td>{{ result.outcome }}</td> 24​ <td>{{ result.outcome }}</td>
24 <td>{{ result.summary }}</td> 25​ <td>{{ result.summary }}</td>
26​ {% if result.result_data.item %}
27​ <td>{{ ",".join(result.result_data.item) }}</td>
28​ {% else %}
29​ <td>-</td>
30​ {% endif %}
25 <td><a href="{{ url_for('main.result', result_id=result.id) }}">Details</a></td> 31​ <td><a href="{{ url_for('main.result', result_id=result.id) }}">Details</a></td>
26 <td><a href="{{ url_for('main.job', job_id=result.job_url.split('/')[-1]) }}">Job</a></td> 32​ <td><a href="{{ url_for('main.job', job_id=result.job_url.split('/')[-1]) }}">Job</a></td>
27 <td><a href="{{ result.log_url }}">Log &rarr;</a></td> 33​ <td><a href="{{ result.log_url }}">Log &rarr;</a></td>
28 </tr> 34​ </tr>
29 {% endfor %} 35​ {% endfor %}
30 </tbody> 36​ </tbody>
31</table> 37​</table>
32 38​
Show All 12 Lines