Differential D181

provide item summary
ClosedPublic
Actions

Authored by kparal on Jul 4 2014, 1:01 PM.

Details

Reviewers
tflink
mkrizek
jskladan
Commits
rUPGR0f196f6eb0d2: provide item summary
Summary

This helps to see results in ResultsDB, at least until it displays
item as a new column (T279).

Before:

ok - $CHECKNAME for Bodhi update voms-api-java-3.0.3-1.fc20
  ---
  details:
    output: |-
      ============================================================
      voms-api-java-3.0.3-1.fc20 into f20-updates
      ============================================================
      [ OK ] f19
              Latest package:         voms-api-java-2.0.10-2.fc19
      [ OK ] f19-updates
              Latest package:         voms-api-java-2.0.10-4.fc19
      [ OK ] f20
              Latest package:         voms-api-java-2.0.10-4.fc20
      [--->] f20-updates
              Proposed package:       voms-api-java-3.0.3-1.fc20
      [ OK ] f21
              Latest package:         voms-api-java-3.0.3-1.fc21
              Latest pending package: None
      RESULT: PASSED
  item: voms-api-java-3.0.3-1.fc20
  outcome: PASSED
  type: bodhi_update
  ...

After:

ok - $CHECKNAME for Bodhi update voms-api-java-3.0.3-1.fc20
  ---
  details:
    output: |-
      ============================================================
      voms-api-java-3.0.3-1.fc20 into f20-updates
      ============================================================
      [ OK ] f19
              Latest package:         voms-api-java-2.0.10-2.fc19
      [ OK ] f19-updates
              Latest package:         voms-api-java-2.0.10-4.fc19
      [ OK ] f20
              Latest package:         voms-api-java-2.0.10-4.fc20
      [--->] f20-updates
              Proposed package:       voms-api-java-3.0.3-1.fc20
      [ OK ] f21
              Latest package:         voms-api-java-3.0.3-1.fc21
              Latest pending package: None
      RESULT: PASSED
  item: voms-api-java-3.0.3-1.fc20
  outcome: PASSED
  summary: voms-api-java-3.0.3-1.fc20 into f20-updates
  type: bodhi_update
  ...

But of course, this is not about console output, but about output at http://resultsdb-stg.cloud.fedoraproject.org/results?testcase_name=upgradepath .

Test Plan

I ran it manually, no issues.

Diff Detail

Repository
rUPGR task-upgradepath
Lint
Lint Skipped
Unit
Unit Tests Skipped
kparal retitled this revision from to provide item summary.Jul 4 2014, 1:01 PM
kparal updated this object.
kparal edited the test plan for this revision. (Show Details)
kparal added reviewers: mkrizek, tflink, jskladan.
mkrizek accepted this revision.Jul 7 2014, 11:32 AM
This revision is now accepted and ready to land.Jul 7 2014, 11:32 AM
tflink accepted this revision.Jul 7 2014, 12:46 PM

Looks good to me

kparal closed this revision.Jul 7 2014, 2:19 PM
kparal updated this revision to Diff 531.

Closed by commit rUPGR0f196f6eb0d2 (authored by @kparal).

Revision Contents

PathPackages
Mupgradepath.py (4 lines)

Diff 531

View Options

upgradepath.py

Show First 20 Lines • Show All 391 Lines • ▼ Show 20 Line(s)244 def run_once(self, kojitag, event='post-bodhi-update-batch', **kwargs):
392 for nevr in nevrs: 392​ for nevr in nevrs:
393 self.koji.session.getBuild(rpm_utils.rpmformat(nevr, 'nvr')) 393​ self.koji.session.getBuild(rpm_utils.rpmformat(nevr, 'nvr'))
394 koji_builds = self.koji.session.multiCall() 394​ koji_builds = self.koji.session.multiCall()
395 395​
396 # Let the testing begin! 396​ # Let the testing begin!
397 logger.debug('Running main upgradepath checks...') 397​ logger.debug('Running main upgradepath checks...')
398 for (nevr, koji_build) in zip(nevrs, koji_builds): 398​ for (nevr, koji_build) in zip(nevrs, koji_builds):
399 detail = self.build2detail[nevr] 399​ detail = self.build2detail[nevr]
400​ detail.summary = '%s into %s' % (nevr, kojitag)
401​
400 if detail.broken(): 402​ if detail.broken():
401 # this Bodhi update was already broken by some nevr, skip it 403​ # this Bodhi update was already broken by some nevr, skip it
402 continue 404​ continue
403 405​
404 detail.store('%s\n%s into %s\n%s' % (60*'=', nevr, kojitag, 60*'=')) 406​ detail.store('%s\n%s\n%s' % (60*'=', detail.summary, 60*'='))
405 407​
406 # Koji returns list if the call succeeded and dict (containing error 408​ # Koji returns list if the call succeeded and dict (containing error
407 # information) if the call failed 409​ # information) if the call failed
408 if isinstance(koji_build, dict): 410​ if isinstance(koji_build, dict):
409 msg = "Can't fetch info about %s from Koji: %s" % (nevr, koji_build) 411​ msg = "Can't fetch info about %s from Koji: %s" % (nevr, koji_build)
410 detail.store(msg) 412​ detail.store(msg)
411 self.problematic[nevr] = msg 413​ self.problematic[nevr] = msg
412 detail.update_outcome('ABORTED') 414​ detail.update_outcome('ABORTED')
▲ Show 20 Lines • Show All 214 Lines • Show Last 20 Lines