Differential D180

Make fake_fedorainfra support newer versions of Flask-WTF
ClosedPublic
Actions

Authored by nanonyme on Jul 3 2014, 7:26 PM.

Details

Reviewers
tflink
Maniphest Tasks
T275: update fake_fedorainfra for new flask-wtf
Commits
rFAKE11dc10329195: Release version locks for Flask and Flask-SQLAlchemy
rFAKEdf27657125f4: Make fake_fedorainfra support newer versions of Flask-WTF
Summary

Flask-WTF version 0.9.0 no longer imports wtforms so fake_fedorainfa
needs to import certain fields and validators directly from wtforms

Test Plan

All tests pass with original Flask-WTF 0.8.0 and current latest
0.9.5

Diff Detail

Repository
rFAKE fake_fedorainfra
Lint
Lint Skipped
Unit
Unit Tests Skipped
nanonyme retitled this revision from to Make fake_fedorainfra support newer versions of Flask-WTF.Jul 3 2014, 7:26 PM
nanonyme updated this object.
nanonyme edited the test plan for this revision. (Show Details)
nanonyme added a comment.Jul 3 2014, 7:31 PM

Locally tested with both 0.8.0 and 0.9.5

tflink accepted this revision.Jul 3 2014, 7:31 PM
tflink added a reviewer: tflink.

Overall, looks good to me. Just two small requests while the requirements.txt file is being changed but it doesn't need re-review for those tiny changes

requirements.txt
2

can you change this to >=0.9

5

same here, could you chang ehtis to >= 0.16?

This revision is now accepted and ready to land.Jul 3 2014, 7:31 PM
nanonyme updated this revision to Diff 523.Jul 3 2014, 7:42 PM
  • Release version locks for Flask and Flask-SQLAlchemy
nanonyme closed this revision.Jul 3 2014, 8:09 PM
nanonyme updated this revision to Diff 525.

Closed by commit rFAKE11dc10329195 (authored by @nanonyme).

nanonyme closed this revision.Jul 3 2014, 8:09 PM
nanonyme updated this revision to Diff 524.

Closed by commit rFAKEdf27657125f4 (authored by @nanonyme).

Revision Contents

PathPackages
Mrequirements.txt (4 lines)

Diff 525

View Options

requirements.txt

1pytest>=2.0.3 1​pytest>=2.0.3
2Flask==0.9 2​Flask>=0.9
tflinkUnsubmitted
Not Done

can you change this to >=0.9

3Flask-XML-RPC>=0.1.2 3​Flask-XML-RPC>=0.1.2
4SQLAlchemy>= 0.7 4​SQLAlchemy>= 0.7
5Flask-SQLAlchemy==0.16 5​Flask-SQLAlchemy>=0.16
tflinkUnsubmitted
Not Done

same here, could you chang ehtis to >= 0.16?

6WTForms>1.0 6​WTForms>1.0
7Flask-WTF>=0.8 7​Flask-WTF>=0.8
8Flask-Login>=0.1.3 8​Flask-Login>=0.1.3
9python-fedora>=0.3.33 9​python-fedora>=0.3.33
10 10​