Differential D178

koji_utils: decrease debug verbosity about downloading
ClosedPublic
Actions

Authored by kparal on Jul 3 2014, 9:24 AM.

Details

Reviewers
mkrizek
jskladan
Commits
rLTRN40926d08a211: koji_utils: decrease debug verbosity about downloading
Summary

Because file_utils.download() prints a debugging message itself, we
don't need to duplicate the message even in koji_utils.get_nvr_rpms().

This is output before:

[libtaskotron:koji_utils.py:87] 2014-07-03 11:17:31 INFO    Querying Koji for a list of RPMS for: mingw-gsm-1.0.13-1.fc19
[libtaskotron:koji_utils.py:137] 2014-07-03 11:17:35 INFO    Fetching 4 RPMs for: mingw-gsm-1.0.13-1.fc19
[libtaskotron:koji_utils.py:139] 2014-07-03 11:17:35 DEBUG     Fetching http://kojipkgs.fedoraproject.org/packages/mingw-gsm/1.0.13/1.fc19/noarch/mingw32-gsm-1.0.13-1.fc19.noarch.rpm
[libtaskotron:file_utils.py:106] 2014-07-03 11:17:35 DEBUG   Downloading: http://kojipkgs.fedoraproject.org/packages/mingw-gsm/1.0.13/1.fc19/noarch/mingw32-gsm-1.0.13-1.fc19.noarch.rpm
mingw32-gsm-1.0.13-1.fc19.noarch.rpm                                                                                                                                                        |  27 kB  00:00:00     
[libtaskotron:koji_utils.py:139] 2014-07-03 11:17:36 DEBUG     Fetching http://kojipkgs.fedoraproject.org/packages/mingw-gsm/1.0.13/1.fc19/noarch/mingw32-gsm-tools-1.0.13-1.fc19.noarch.rpm
[libtaskotron:file_utils.py:106] 2014-07-03 11:17:36 DEBUG   Downloading: http://kojipkgs.fedoraproject.org/packages/mingw-gsm/1.0.13/1.fc19/noarch/mingw32-gsm-tools-1.0.13-1.fc19.noarch.rpm
mingw32-gsm-tools-1.0.13-1.fc19.noarch.rpm                                                                                                                                                  |  16 kB  00:00:00     
[libtaskotron:koji_utils.py:139] 2014-07-03 11:17:36 DEBUG     Fetching http://kojipkgs.fedoraproject.org/packages/mingw-gsm/1.0.13/1.fc19/noarch/mingw64-gsm-1.0.13-1.fc19.noarch.rpm
[libtaskotron:file_utils.py:106] 2014-07-03 11:17:36 DEBUG   Downloading: http://kojipkgs.fedoraproject.org/packages/mingw-gsm/1.0.13/1.fc19/noarch/mingw64-gsm-1.0.13-1.fc19.noarch.rpm
mingw64-gsm-1.0.13-1.fc19.noarch.rpm                                                                                                                                                        |  29 kB  00:00:00     
[libtaskotron:koji_utils.py:139] 2014-07-03 11:17:37 DEBUG     Fetching http://kojipkgs.fedoraproject.org/packages/mingw-gsm/1.0.13/1.fc19/noarch/mingw64-gsm-tools-1.0.13-1.fc19.noarch.rpm
[libtaskotron:file_utils.py:106] 2014-07-03 11:17:37 DEBUG   Downloading: http://kojipkgs.fedoraproject.org/packages/mingw-gsm/1.0.13/1.fc19/noarch/mingw64-gsm-tools-1.0.13-1.fc19.noarch.rpm
mingw64-gsm-tools-1.0.13-1.fc19.noarch.rpm                                                                                                                                                  |  18 kB  00:00:00    
`

This is after:

[libtaskotron:koji_utils.py:87] 2014-07-03 11:20:07 INFO    Querying Koji for a list of RPMS for: mingw-gsm-1.0.13-1.fc19
[libtaskotron:koji_utils.py:137] 2014-07-03 11:20:09 INFO    Fetching 4 RPMs for: mingw-gsm-1.0.13-1.fc19
[libtaskotron:file_utils.py:106] 2014-07-03 11:20:09 DEBUG   Downloading: http://kojipkgs.fedoraproject.org/packages/mingw-gsm/1.0.13/1.fc19/noarch/mingw32-gsm-1.0.13-1.fc19.noarch.rpm
mingw32-gsm-1.0.13-1.fc19.noarch.rpm                                                                                                                                                        |  27 kB  00:00:00     
[libtaskotron:file_utils.py:106] 2014-07-03 11:20:09 DEBUG   Downloading: http://kojipkgs.fedoraproject.org/packages/mingw-gsm/1.0.13/1.fc19/noarch/mingw32-gsm-tools-1.0.13-1.fc19.noarch.rpm
mingw32-gsm-tools-1.0.13-1.fc19.noarch.rpm                                                                                                                                                  |  16 kB  00:00:00     
[libtaskotron:file_utils.py:106] 2014-07-03 11:20:10 DEBUG   Downloading: http://kojipkgs.fedoraproject.org/packages/mingw-gsm/1.0.13/1.fc19/noarch/mingw64-gsm-1.0.13-1.fc19.noarch.rpm
mingw64-gsm-1.0.13-1.fc19.noarch.rpm                                                                                                                                                        |  29 kB  00:00:00     
[libtaskotron:file_utils.py:106] 2014-07-03 11:20:10 DEBUG   Downloading: http://kojipkgs.fedoraproject.org/packages/mingw-gsm/1.0.13/1.fc19/noarch/mingw64-gsm-tools-1.0.13-1.fc19.noarch.rpm
mingw64-gsm-tools-1.0.13-1.fc19.noarch.rpm                                                                                                                                                  |  18 kB  00:00:00
Test Plan

tested in action with depcheck

Diff Detail

Repository
rLTRN libtaskotron
Lint
Lint Skipped
Unit
Unit Tests Skipped
kparal retitled this revision from to koji_utils: decrease debug verbosity about downloading.Jul 3 2014, 9:24 AM
kparal updated this object.
kparal edited the test plan for this revision. (Show Details)
kparal added reviewers: mkrizek, jskladan.
mkrizek accepted this revision.Jul 3 2014, 9:29 AM

LGTM

This revision is now accepted and ready to land.Jul 3 2014, 9:29 AM
jskladan accepted this revision.Jul 3 2014, 1:44 PM
kparal closed this revision.Jul 3 2014, 1:47 PM
kparal updated this revision to Diff 517.

Closed by commit rLTRN40926d08a211 (authored by @kparal).

Revision Contents

PathPackages
Mlibtaskotron/koji_utils.py (1 line)

Diff 517

View Options

libtaskotron/koji_utils.py

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Line(s)114 def get_nvr_rpms(self, nvr, rpm_dir, arches=None, debuginfo=False,
131 except exc.TaskotronRemoteError, e: 131​ except exc.TaskotronRemoteError, e:
132 log.warn('Error while retrieving urls for %s (%s)' % (nvr, arches)) 132​ log.warn('Error while retrieving urls for %s (%s)' % (nvr, arches))
133 log.warn(e) 133​ log.warn(e)
134 return 134​ return
135 135​
136 rpm_files = [] 136​ rpm_files = []
137 log.info('Fetching %s RPMs for: %s', len(rpm_urls), nvr) 137​ log.info('Fetching %s RPMs for: %s', len(rpm_urls), nvr)
138 for url in rpm_urls: 138​ for url in rpm_urls:
139 log.debug(' Fetching %s', url) ​
140 rpm_file = file_utils.download(url, rpm_dir) 139​ rpm_file = file_utils.download(url, rpm_dir)
141 rpm_files.append(rpm_file) 140​ rpm_files.append(rpm_file)
142 141​
143 return rpm_files 142​ return rpm_files
144 143​
145 144​
146 def get_tagged_rpms(self, tag, dest, arches): 145​ def get_tagged_rpms(self, tag, dest, arches):
147 '''Downloads all RPMs of all NVRs tagged by a specific Koji tag. 146​ '''Downloads all RPMs of all NVRs tagged by a specific Koji tag.
▲ Show 20 Lines • Show All 45 Lines • Show Last 20 Lines