Changing rpmlint call to use taskotron provided workdir
AbandonedPublic
Actions

Authored by tflink on Jun 27 2014, 12:34 PM.

Details

Reviewers

kparal
roshi

Maniphest Tasks

Summary

adding an argument to rpmlint so that it doesn't create its own tempdir

Test Plan

I've tested the change locally, seems to be working fine

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

tflink retitled this revision from to Changing rpmlint call to use taskotron provided workdir.Jun 27 2014, 12:34 PM

tflink updated this object.

tflink edited the test plan for this revision. (Show Details)

tflink added reviewers: kparal, roshi.

run_rpmlint.py
12–13	I wonder whether it might happen that those temporary rpmlint files override something in the directory full of RPMs. I think it would be safer to make a subdir in `workdir` and give it to `-E`. But if you don't see it necessary, please push.

Works fine here.

Creating a subdir like @kparal suggested might not be bad practice. Will re-review if you decide to create a subdir.

This revision is now accepted and ready to land.Jun 27 2014, 3:56 PM

Spoke too soon, I just got lucky with the build I picked.

This revision now requires changes to proceed.Jun 27 2014, 4:19 PM

This turned out to be not a bug but a problem with one of the clients. As such, the fix is not needed and I'm abandoning the revision

run_rpmlint.py
12–13	yeah, that makes sense. will make the change

			Path
M			run_rpmlint.py (3 lines)

Commit	Tree	Parents	Author	Summary	Date
c08d891fdcb1	51683902b513	c20111f18565	Tim Flink	Specifying tempdir for rpmlint call to use taskotron workdir. Fixes T267.	Jun 27 2014, 12:19 PM

1	import subprocess as sub	1		import subprocess as sub
2	import os	2		import os
3	from libtaskotron import check	3		from libtaskotron import check
4		4
5		5
6	def run(workdir = u'.'):	6		def run(workdir = u'.'):
7	results = []	7		results = []
8	rpmfiles = [r for r in os.listdir(workdir) if r.split(u'.')[-1] == u'rpm']	8		rpmfiles = [r for r in os.listdir(workdir) if r.split(u'.')[-1] == u'rpm']
9		9
10	for rpmfile in rpmfiles:	10		for rpmfile in rpmfiles:
11	result = None	11		result = None
12	p = sub.Popen(['rpmlint', '%s/%s' % (os.path.abspath(workdir), rpmfile)],	12		p = sub.Popen(['rpmlint', '-E %s' % workdir,
		13		'%s/%s' % (os.path.abspath(workdir), rpmfile)],
			kparalUnsubmitted Not Done I wonder whether it might happen that those temporary rpmlint files override something in the directory full of RPMs. I think it would be safer to make a subdir in `workdir` and give it to `-E`. But if you don't see it necessary, please push.
			tflinkAuthorUnsubmitted Not Done yeah, that makes sense. will make the change
13	stdout=sub.PIPE,stderr=sub.PIPE)	14		stdout=sub.PIPE,stderr=sub.PIPE)
14	output, errors = p.communicate()	15		output, errors = p.communicate()
15	retcode = p.returncode	16		retcode = p.returncode
16	if retcode == 0:	17		if retcode == 0:
17	result = 'PASSED'	18		result = 'PASSED'
18	elif retcode == 64 or retcode == 66:	19		elif retcode == 64 or retcode == 66:
19	result = 'FAILED'	20		result = 'FAILED'
20	else:	21		else:
Show All 16 Lines

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	493	c20111f		Jun 27 2014, 12:33 PM	★	★