Differential D157

add url_for() into redirect of default_boji_comments()
ClosedPublic
Actions

Authored by garretraziel on Jun 25 2014, 12:26 PM.

Details

Reviewers
tflink
jskladan
Maniphest Tasks
T194: fake_fedorainfra comments listing link dosen't account for base_url
Commits
rFAKE21079fb7b98c: add url_for() into redirect of default_boji_comments()
Summary

Add url_for() into redirect of default_boji_comments() so that
visiting /boji/comments redirects you correctly in case of different
baseurl.

Test Plan

Ran fake_fedorainfra app, visited localhost:5000/boji/comments,
got redirected to localhost:5000/boji/comments/0. Configured Apache to host
fake_fedorainfra under localhost/fake_fedorainfra, tried it again.

Diff Detail

Repository
rFAKE fake_fedorainfra
Lint
Lint Skipped
Unit
Unit Tests Skipped
garretraziel retitled this revision from to add url_for() into redirect of default_boji_comments().Jun 25 2014, 12:26 PM
garretraziel updated this object.
garretraziel edited the test plan for this revision. (Show Details)
garretraziel added a reviewer: tflink.
tflink accepted this revision.Jun 25 2014, 1:03 PM

Looks good to me

This revision is now accepted and ready to land.Jun 25 2014, 1:03 PM
garretraziel closed this revision.Jun 25 2014, 1:52 PM
garretraziel updated this revision to Diff 459.

Closed by commit rFAKE21079fb7b98c (authored by Garret Raziel <boloomka@gmail.com>).

Revision Contents

Diff 459

View Options

fake_fedorainfra/controllers/main.py

Show First 20 Lines • Show All 101 Lines • ▼ Show 20 Line(s)
102def get_comments(start=0, num_comments=NUM_PAGE): 102​def get_comments(start=0, num_comments=NUM_PAGE):
103 c = db.session.query(BodhiComment).order_by(desc(BodhiComment.id)).slice(start, start+num_comments) 103​ c = db.session.query(BodhiComment).order_by(desc(BodhiComment.id)).slice(start, start+num_comments)
104 comments = [dict(date=str(row.date), update=row.title, text=row.text, user=row.username, 104​ comments = [dict(date=str(row.date), update=row.title, text=row.text, user=row.username,
105 karma=row.karma, send_email=row.send_email, id=row.id ) for row in c] 105​ karma=row.karma, send_email=row.send_email, id=row.id ) for row in c]
106 return comments 106​ return comments
107 107​
108@app.route('/boji/comments', methods=['GET']) 108​@app.route('/boji/comments', methods=['GET'])
109def default_boji_comments(): 109​def default_boji_comments():
110 return redirect('/boji/comments/0') 110​ return redirect(url_for('boji_comments', start_comment=0))
111 111​
112@app.route('/boji/comments/<int:start_comment>', methods=['GET']) 112​@app.route('/boji/comments/<int:start_comment>', methods=['GET'])
113def boji_comments(start_comment): 113​def boji_comments(start_comment):
114 comments = get_comments(start=start_comment) 114​ comments = get_comments(start=start_comment)
115 for c in comments: 115​ for c in comments:
116 c['url'] = url_for('get_boji_comment', comment_id=c['id']) 116​ c['url'] = url_for('get_boji_comment', comment_id=c['id'])
117 next_start = (start_comment + NUM_PAGE) 117​ next_start = (start_comment + NUM_PAGE)
118 prev_start = (start_comment - NUM_PAGE) 118​ prev_start = (start_comment - NUM_PAGE)
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines