Differential D156

log info about workdir when taskotron starts
ClosedPublic
Actions

Authored by garretraziel on Jun 25 2014, 11:57 AM.

Details

Reviewers
kparal
tflink
Commits
rLTRNb59e0305c0cd: log info about workdir when taskotron starts
Summary

log info about workdir when taskotron starts

Test Plan

runtask -i qt-creator-3.1.1-1.fc20 -t bodhi_id task-upgradepath/upgradepath.yml,
[libtaskotron:runner.py:41] 2014-06-25 13:56:01 DEBUG Current workdir: /var/tmp/taskotron/task-aZLD1g
is shown.

Diff Detail

Repository
rLTRN libtaskotron
Lint
Lint Skipped
Unit
Unit Tests Skipped
garretraziel retitled this revision from to log info about workdir when taskotron starts.Jun 25 2014, 11:57 AM
garretraziel updated this object.
garretraziel edited the test plan for this revision. (Show Details)
garretraziel added a reviewer: kparal.
kparal accepted this revision.Jun 25 2014, 12:01 PM

Yes, that's exactly what I wanted. Please wait if somebody else has something to say, otherwise push tomorrow. Thanks.

This revision is now accepted and ready to land.Jun 25 2014, 12:01 PM
tflink accepted this revision.Jun 25 2014, 12:24 PM
tflink added a reviewer: tflink.

sounds like a good idea to me

garretraziel closed this revision.Jun 26 2014, 7:52 AM
garretraziel updated this revision to Diff 468.

Closed by commit rLTRNb59e0305c0cd (authored by Garret Raziel <boloomka@gmail.com>).

Revision Contents

PathPackages
Mlibtaskotron/runner.py (2 lines)

Diff 468

View Options

libtaskotron/runner.py

Show All 32 Lines28 def __init__(self, taskdata, argdata, workdir=None):
33 self.workdir = workdir or tempfile.mkdtemp(prefix="task-", 33​ self.workdir = workdir or tempfile.mkdtemp(prefix="task-",
34 dir=config.get_config().tmpdir) 34​ dir=config.get_config().tmpdir)
35 35​
36 def run(self): 36​ def run(self):
37 self._validate_input() 37​ self._validate_input()
38 self.envdata['workdir'] = self.workdir 38​ self.envdata['workdir'] = self.workdir
39 self.envdata['checkname'] = self.taskdata['name'] 39​ self.envdata['checkname'] = self.taskdata['name']
40 40​
41​ log.debug("Current workdir: %s", self.workdir)
42​
41 self.do_actions() 43​ self.do_actions()
42 44​
43 def _load_directive(self, directive_name, directive_dir=None): 45​ def _load_directive(self, directive_name, directive_dir=None):
44 # look in default path if nothing is specified 46​ # look in default path if nothing is specified
45 if not directive_dir: 47​ if not directive_dir:
46 directive_dir = os.path.join(os.path.dirname(__file__), 48​ directive_dir = os.path.join(os.path.dirname(__file__),
47 'directives') 49​ 'directives')
48 50​
▲ Show 20 Lines • Show All 160 Lines • Show Last 20 Lines