Schedule bodhi_to_koji_tags only for -pending
ClosedPublic

Authored by mkrizek on Jun 24 2014, 12:10 PM.

Diff Detail

Repository
rTRGR taskotron-trigger
Lint
Lint Skipped
Unit
Unit Tests Skipped
mkrizek retitled this revision from to Schedule bodhi_to_koji_tags only for -pending.Jun 24 2014, 12:10 PM
mkrizek updated this object.
mkrizek edited the test plan for this revision. (Show Details)
mkrizek added reviewers: tflink, kparal.
tflink requested changes to this revision.Jun 24 2014, 12:23 PM

This gets halfway there :) As I'm reading this code, it'll trigger when updates are pending but it will use the fXX-updates(-testing) tag when it triggers.

The tag name construction needs to take "pending" into account

jobtriggers/bodhi_msg.py
53–54

This will still prevent *-pending tags from being used.

This revision now requires changes to proceed.Jun 24 2014, 12:23 PM
mkrizek added inline comments.Jun 24 2014, 12:37 PM
jobtriggers/bodhi_msg.py
53–54

Er, good catch, thanks.

mkrizek updated this revision to Diff 453.Jun 24 2014, 12:37 PM

Address issue mentioned in the review

mkrizek updated this revision to Diff 454.Jun 24 2014, 12:40 PM

Minor fix

tflink accepted this revision.Jun 24 2014, 12:58 PM

It looks good to me. If you haven't already, could you run taskotron-trigger in stream mode for a while to make sure that it's only acting on *-pending tags before pushing?

This revision is now accepted and ready to land.Jun 24 2014, 12:58 PM
mkrizek closed this revision.Jun 24 2014, 1:41 PM
mkrizek updated this revision to Diff 456.

Closed by commit rTRGR6b9d85398511 (authored by @mkrizek).