Fixes T252
Details
Details
Tests included. Run fedmsg-hub.
Diff Detail
Diff Detail
- Repository
- rTRGR taskotron-trigger
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
This gets halfway there :) As I'm reading this code, it'll trigger when updates are pending but it will use the fXX-updates(-testing) tag when it triggers.
The tag name construction needs to take "pending" into account
jobtriggers/bodhi_msg.py | ||
---|---|---|
53–54 | This will still prevent *-pending tags from being used. |
jobtriggers/bodhi_msg.py | ||
---|---|---|
53–54 | Er, good catch, thanks. |
Comment Actions
It looks good to me. If you haven't already, could you run taskotron-trigger in stream mode for a while to make sure that it's only acting on *-pending tags before pushing?
This will still prevent *-pending tags from being used.