Differential D15

Rename line.png to line-bottom.png to reflect the actual state of css.
ClosedPublic
Actions

Authored by mkrizek on Feb 21 2014, 12:09 PM.

Details

Reviewers
tflink
Commits
rBLKR026450a207d0: Rename line.png to line-bottom.png to reflect the actual state of css.
Summary

It appears that we've been getting ""GET /static/img/line-bottom.png HTTP/1.1" 404" for quite some time now...

Test Plan

Works on my dev machine

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
tflink added a comment.Feb 24 2014, 1:47 AM

If we're really hitting this in production, I'm OK with the change but since this affects the application itself, I'd like to see a bug filed describing the issue instead of just doing the change even though it's a little pedantic.

mkrizek added a comment.Feb 24 2014, 1:47 PM

If we're really hitting this in production, I'm OK with the change but since this affects the application itself, I'd like to see a bug filed describing the issue instead of just doing the change even though it's a little pedantic.

Yeah, I didn't think that making "a noise" and filling a bug was needed in this case since the issue is described in the summary here and the change is very small.

tflink accepted this revision.Feb 24 2014, 4:40 PM

Yeah, I didn't think that making "a noise" and filling a bug was needed in this case since the issue is described in the summary here and the change is very small.

Sure, but I'm wary of getting into a habit of making changes to the application without filing bugs. Metadata, makefiles and support stuff doesn't worry me much but this is a change to the actual application. Like I said, it's pedantic :)

Accepted but please don't make a habit of changes without tasks.

mkrizek closed this revision.Feb 25 2014, 9:31 AM

Closed by commit rBLKR026450a207d0 (authored by @mkrizek).

Revision Contents

Path
No data available.

Diff 31