Mash directive created non-valid config for mash.
Details
Details
- Reviewers
kparal tflink - Commits
- rLTRN7648ed2e280a: Fixed mash directive
unittests work and the mash directive correctly uses mash to solve multilib
Diff Detail
Diff Detail
- Repository
- rLTRN libtaskotron
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
I'm of a similar mind to @kparal. I don't quite understand the significance of the mash config changes but trust that it does what we need it to.
Comment Actions
the output_dir and output_subdir are required (even set to nothing) in order for mash to work, there are lines like:
pkgdir = os.path.join(self.config.outputdir, self.config.output_subdir,-
self.config.rpm_path % {'arch':arch})
repodir = os.path.join(self.config.outputdir, self.config.output_subdir,-
self.config.repodata_path % {'arch':arch})in the code, and if outputdir/output_subdir is not set, the default value is None and os.path.join fails on
File "<stdin>", line 1, in <module>
File "/usr/lib64/python2.7/posixpath.py", line 75, in join
if b.startswith('/'):
AttributeError: 'NoneType' object has no attribute 'startswith'The most significant change is the arches line, which needs to look like
arches = arch1 arch2 arch3 `
but in the previous patch, it looked like this
arches = ['arch1', 'arch2']