Differential D14

Fix needinfo field length
ClosedPublic
Actions

Authored by mkrizek on Feb 21 2014, 12:07 PM.

Details

Reviewers
tflink
Commits
rBLKR9f659cf2c5fa: Fix needinfo field length
Summary

Now that we support multiple needinfo flags, we also need to increase length of the needinfo field.

Test Plan

Works on my dev machine

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
tflink added a comment.Feb 24 2014, 1:44 AM

Has this been a problem in production? If so, why isn't there a bug for it? How often has this been a problem and is an increase to 80 chars really enough if we're getting many bugs with multiple needinfos?

mkrizek added a comment.Feb 24 2014, 11:45 AM

Has this been a problem in production? If so, why isn't there a bug for it? How often has this been a problem and is an increase to 80 chars really enough if we're getting many bugs with multiple needinfos?

It hasn't been a problem in production since the feature is not included in any release yet [1] :)

Increasing to 80 chars is plenty, usually there are not more than 3 people in needinfo flag, e.g.:
len('Adam Williamson, Josef Skladanka, Petr Schindler') = 48

So, 80 seems enough to me, do you think we shoud change the value?

"if we're getting many bugs with multiple needinfos"

I don't think I understand what you mean.

[1] https://git.fedorahosted.org/cgit/blockerbugs.git/commit/?h=develop&id=0618ae3bc89431f9d00a3cc103b19fc0376697ed

tflink requested changes to this revision.Feb 25 2014, 4:33 AM

> Has this been a problem in production? If so, why isn't there a bug for it? How often has this been a problem and is an increase to 80 chars really enough if we're getting many bugs with multiple needinfos?

It hasn't been a problem in production since the feature is not included in any release yet [1] :)

Increasing to 80 chars is plenty, usually there are not more than 3 people in needinfo flag, e.g.:

len('Adam Williamson, Josef Skladanka, Petr Schindler') = 48

So, 80 seems enough to me, do you think we shoud change the value?

No, I just didn't realize that's where this was coming from. If there really aren't any bugs with more needinfo people then we should be fine. However, the first bug we hit with with more than 80 chars of needinfo people would cause problems during sync, no? If that's the case, unless we have proof that it can't be more than 80 chars, I'd rather have something like 1024 just to be really safe.

mkrizek updated this revision.Feb 25 2014, 9:55 AM

Increase needinfo length to 1024 for safety

tflink accepted this revision.Mar 3 2014, 4:22 PM

Looks good to me, please merge to develop

mkrizek closed this revision.Mar 4 2014, 9:10 AM

Closed by commit rBLKR9f659cf2c5fa (authored by @mkrizek).

Revision Contents

Diff 45

View Options

alembic/versions/1dfd879c7637_fix_needinfo_field_l.py

  • This file was added.
1​"""Fix needinfo field length
2​
3​Revision ID: 1dfd879c7637
4​Revises: 23cc8daafea8
5​Create Date: 2013-12-18 17:15:47.512317
6​
7​"""
8​
9​# revision identifiers, used by Alembic.
10​revision = '1dfd879c7637'
11​down_revision = '23cc8daafea8'
12​
13​from alembic import op
14​import sqlalchemy as sa
15​
16​
17​def upgrade():
18​ op.alter_column(u'bug', u'needinfo', type_=sa.String(1024))
19​
20​
21​def downgrade():
22​ op.alter_column(u'bug', u'needinfo', type_=sa.String(30))
View Options

blockerbugs/models/bug.py

Show All 28 Lines28class Bug(db.Model):
29 id = db.Column(db.Integer, primary_key=True) 29​ id = db.Column(db.Integer, primary_key=True)
30 bugid = db.Column(db.Integer, unique=False) 30​ bugid = db.Column(db.Integer, unique=False)
31 url = db.Column(db.String(1024), unique=False) 31​ url = db.Column(db.String(1024), unique=False)
32 summary = db.Column(db.String(2048), unique=False) 32​ summary = db.Column(db.String(2048), unique=False)
33 status = db.Column(db.String(80), unique=False) 33​ status = db.Column(db.String(80), unique=False)
34 component = db.Column(db.String(80), unique=False) 34​ component = db.Column(db.String(80), unique=False)
35 active = db.Column(db.Boolean) 35​ active = db.Column(db.Boolean)
36 last_bug_sync = db.Column(db.DateTime) 36​ last_bug_sync = db.Column(db.DateTime)
37 needinfo = db.Column(db.String(30), unique=False) 37​ needinfo = db.Column(db.String(1024), unique=False)
38 proposed_blocker = db.Column(db.Boolean) 38​ proposed_blocker = db.Column(db.Boolean)
39 proposed_fe = db.Column(db.Boolean) 39​ proposed_fe = db.Column(db.Boolean)
40 rejected_blocker = db.Column(db.Boolean) 40​ rejected_blocker = db.Column(db.Boolean)
41 rejected_fe = db.Column(db.Boolean) 41​ rejected_fe = db.Column(db.Boolean)
42 accepted_blocker = db.Column(db.Boolean) 42​ accepted_blocker = db.Column(db.Boolean)
43 accepted_fe = db.Column(db.Boolean) 43​ accepted_fe = db.Column(db.Boolean)
44 milestone_id = db.Column(db.Integer, db.ForeignKey('milestone.id')) 44​ milestone_id = db.Column(db.Integer, db.ForeignKey('milestone.id'))
45 milestone = db.relationship('Milestone', 45​ milestone = db.relationship('Milestone',
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines