| kparal | |
| tflink |
Re-submitting, as D125 got falsely closed
unit-tests, this code needs more work to run with taskotron
| No Linters Available |
| No Unit Test Coverage |
| Path | Packages | |||
|---|---|---|---|---|
| M | .arcconfig (2 lines) | |||
| M | depcheck.yml (2 lines) | |||
| M | depcheck/__init__.py (87 lines) | |||
| M | depcheck/depcheck.py (57 lines) | |||
| D | M | depcheck/output.py (62 lines) | ||
| A | M | depcheck/squash_results.py (54 lines) | ||
| M | etc/depcheck.conf (4 lines) | |||
| M | run_depcheck.py (40 lines) | |||
| M | tests/functest_depcheck_scenarios.py (24 lines) | |||
| M | tests/test_depcheck.py (57 lines) | |||
| A | M | tests/test_squash_results.py (113 lines) |
| Commit | Tree | Parents | Author | Summary | Date |
|---|---|---|---|---|---|
| 3b1e30bfdc83 | 7f552e81b25f | 277d15e9d4cc | Josef Skladanka | tflink's catches | Jun 10 2014, 2:47 PM |
| 277d15e9d4cc | d8b5ce32c57d | 3b3d01bf6724 | Josef Skladanka | fixed conf file | Jun 10 2014, 11:05 AM |
| 3b3d01bf6724 | f6eddb65c48f | 6e29020af65a | Josef Skladanka | typos | Jun 10 2014, 11:02 AM |
| 6e29020af65a | 20f8e4806f04 | bb95550643a4 | Josef Skladanka | Minor fix | Jun 10 2014, 11:00 AM |
| bb95550643a4 | e717560d9f65 | 7f823133359d | Josef Skladanka | Changed as per @tflink's requests | Jun 10 2014, 10:58 AM |
| 7f823133359d | de856bc68f66 | 66ba8c9b004f | Josef Skladanka | Moar Comments | Jun 6 2014, 10:33 AM |
| 66ba8c9b004f | e3e4a58c08b9 | d13b035f8a23 | Josef Skladanka | Moar tests | Jun 6 2014, 10:23 AM |
| d13b035f8a23 | c301e47dfbdc | 6330623ba7c7 | Josef Skladanka | T195 - Depcheck reports results per update (Show More…) | Jun 5 2014, 1:39 PM |
| 6330623ba7c7 | 71cbb7ac02da | 19b94716d8a3 | Josef Skladanka | Functional tests run and mean something | Jun 5 2014, 1:32 PM |
| 19b94716d8a3 | eeb5d7b67354 | 8cc07032b75e | Josef Skladanka | fixed obvious typos | Jun 5 2014, 7:36 AM |
| 8cc07032b75e | eeb3e191057e | fb9887e72f6f | Josef Skladanka | removed unnecessary run method in depcheck.py | Jun 5 2014, 7:29 AM |
| fb9887e72f6f | b2482212a567 | f67661fe7212 | Josef Skladanka | removed output.py | Jun 5 2014, 7:29 AM |
| f67661fe7212 | dbd1863c8146 | bd797217b7f6 | Josef Skladanka | renamed some methods | Jun 4 2014, 12:58 PM |
| bd797217b7f6 | e7837e8c2bd6 | e831a3498ac9 | Josef Skladanka | remove self.run_result | Jun 4 2014, 12:23 PM |
| e831a3498ac9 | 2f4f50004572 | 43921c10b920 | Josef Skladanka | t195 - grouping results per update | Jun 4 2014, 12:08 PM |
| 43921c10b920 | 494b05119c2c | 33df059a8acc | Josef Skladanka | t195 - minor sanity changes | Jun 4 2014, 12:07 PM |
| 1 | { | 1 | { | ||
|---|---|---|---|---|---|
| 2 | "project_id" : "task-depcheck", | 2 | "project_id" : "task-depcheck", | ||
| 3 | "conduit_uri" : "https://phab.qadevel.cloud.fedoraproject.org", | 3 | "conduit_uri" : "https://phab.qadevel.cloud.fedoraproject.org", | ||
| 4 | "arc.land.onto.default" : "master", | ||||
| 5 | "arc.feature.start.default" : "master" | ||||
| 4 | } | 6 | } | ||
| Show All 13 Lines | |||||
| 14 | task: | 14 | task: | ||
| 15 | - name: run depcheck | 15 | - name: run depcheck | ||
| 16 | python: | 16 | python: | ||
| 17 | file: run_depcheck.py | 17 | file: run_depcheck.py | ||
| 18 | callable: run | 18 | callable: run | ||
| 19 | arch: "{{ arch }}" | 19 | arch: "{{ arch }}" | ||
| 20 | rpms: "{{ workdir }}" | 20 | rpms: "{{ workdir }}" | ||
| 21 | repos: "{{ repos }}" | 21 | repos: "{{ repos }}" | ||
| 22 | out_format: "tap" | 22 | report_format: "update" | ||
| 23 | export: depcheck_output | 23 | export: depcheck_output | ||
| 24 | 24 | | |||
| 25 | - name: report results to resultsdb | 25 | - name: report results to resultsdb | ||
| 26 | resultsdb: | 26 | resultsdb: | ||
| 27 | results: "{{ depcheck_output }}" | 27 | results: "{{ depcheck_output }}" | ||
| 28 | 28 | | |||
| Show All 21 Lines | |||||
| 22 | # EPEL dep: python-argparse | 22 | # EPEL dep: python-argparse | ||
| 23 | """Depcheck mk 2 is a new dependency checker for rpms and yum repositories""" | 23 | """Depcheck mk 2 is a new dependency checker for rpms and yum repositories""" | ||
| 24 | 24 | | |||
| 25 | __version__ = '0.0.5' | 25 | __version__ = '0.0.5' | ||
| 26 | 26 | | |||
| 27 | 27 | | |||
| 28 | # Check to see if libtaskotron is present; if so, import pass and fail | 28 | # Check to see if libtaskotron is present; if so, import pass and fail | ||
| 29 | 29 | | |||
| 30 | try: | 30 | Pass = 'PASSED' | ||
| 31 | from libtaskotron import tap | 31 | Fail = 'FAILED' | ||
| 32 | | ||||
| 33 | Pass = tap.PASS | | |||
| 34 | Fail = tap.FAIL | | |||
| 35 | except ImportError: | | |||
| 36 | Pass = 0 | | |||
| 37 | Fail = 1 | | |||
| 38 | 32 | | |||
| 39 | import os.path | 33 | import os.path | ||
| 40 | import sys | 34 | import sys | ||
| 41 | import argparse | 35 | import argparse | ||
| 42 | import tempfile | 36 | import tempfile | ||
| 43 | import platform | 37 | import platform | ||
| 44 | 38 | | |||
| 45 | from . import depcheck | 39 | from . import depcheck | ||
| Show All 12 Lines | 51 | if filename.endswith('.rpm'): | |||
| 58 | rpm_list.append(os.path.join(dirname, filename)) | 52 | rpm_list.append(os.path.join(dirname, filename)) | ||
| 59 | return rpm_list | 53 | return rpm_list | ||
| 60 | 54 | | |||
| 61 | 55 | | |||
| 62 | def extract_named_repo(namedrepo): | 56 | def extract_named_repo(namedrepo): | ||
| 63 | return namedrepo.split(':', 1) | 57 | return namedrepo.split(':', 1) | ||
| 64 | 58 | | |||
| 65 | 59 | | |||
| 66 | def depcheck_cli(): | 60 | def run(rpms, arch, repos, report_format="builds"): | ||
| 67 | parser = argparse.ArgumentParser() | | |||
| 68 | parser.add_argument("rpm", nargs='+', help="RPM to be tested") | | |||
| 69 | parser.add_argument("-a", "--arch", choices=["i386", "x86_64", "armhfp"], help=""" | | |||
| 70 | Architecture to be tested; support arches are x86, x86_64, and armhfp. | | |||
| 71 | If omitted, defaults to current machine architecture. | | |||
| 72 | """) | | |||
| 73 | parser.add_argument("-r", "--repos", nargs='+', action='store', help=""" | | |||
| 74 | Repo to be tested against, in the form of reponame:repolocation where | | |||
| 75 | repolocation can be local (in the form /dir/of/repo) or | | |||
| 76 | remote (direct link or standard metalink), to be tested against. | | |||
| 77 | """) | | |||
| 78 | parser.add_argument("--release", help="Fedora release to be tested") | | |||
| 79 | parser.add_argument("-f", "--format", choices=["json", "tap"], help=""" | | |||
| 80 | Specify output format to override configuration | | |||
| 81 | """) | | |||
| 82 | | ||||
| 83 | args = parser.parse_args() | | |||
| 84 | 61 | | |||
| 85 | rpmlist = [] | 62 | rpmlist = [] | ||
| 86 | # handle directory args, expanding them to a list of rpm files with absolute | 63 | # handle directory args, expanding them to a list of rpm files with absolute | ||
| 87 | # paths | 64 | # paths | ||
| 88 | for filename in args.rpm: | 65 | for filename in rpms: | ||
| 89 | if os.path.isdir(filename): | 66 | if os.path.isdir(filename): | ||
| 90 | rpmlist.extend(dir_to_rpms(filename)) | 67 | rpmlist.extend(dir_to_rpms(filename)) | ||
| 91 | else: | 68 | else: | ||
| 92 | rpmlist.append(filename) | 69 | rpmlist.append(filename) | ||
| 93 | 70 | | |||
| 94 | # autodetect arch if none is passed in | | |||
| 95 | if args.arch is None: | | |||
| 96 | arch = platform.machine() | | |||
| 97 | else: | | |||
| 98 | arch = args.arch | | |||
| 99 | | ||||
| 100 | # arm has some special case requirements for arch handling | 71 | # arm has some special case requirements for arch handling | ||
| 101 | # Fixup for arm; the yum repo is labled as armhfp but the envr is armv7hl | 72 | # Fixup for arm; the yum repo is labled as armhfp but the nvr is armv7hl | ||
| 102 | if arch == 'armv7l': | 73 | if arch == 'armv7l': | ||
| 103 | arch = 'armhfp' | 74 | arch = 'armhfp' | ||
| 104 | 75 | | |||
| 105 | # handle data formatting for repo metadata (list of dicts) | 76 | # handle data formatting for repo metadata (list of dicts) | ||
| 106 | repos = {} | 77 | repos = {} | ||
| 107 | for repo in args.repos: | 78 | for repo in repos: | ||
| 108 | namedrepo = extract_named_repo(repo) | 79 | namedrepo = extract_named_repo(repo) | ||
| 109 | repos[namedrepo[0]] = {'arch': args.arch, 'path': namedrepo[1]} | 80 | repos[namedrepo[0]] = {'arch': arch, 'path': namedrepo[1]} | ||
| 110 | 81 | | |||
| 111 | workdir = tempfile.mkdtemp('', 'depcheck-', '/var/tmp/') | 82 | workdir = tempfile.mkdtemp('', 'depcheck-', '/var/tmp/') | ||
| 112 | md_handle = metadata.DepcheckMetadata(repos, targetdir=workdir) | 83 | md_handle = metadata.DepcheckMetadata(repos, targetdir=workdir) | ||
| 113 | 84 | | |||
| 114 | repomd_files = md_handle.repodata | 85 | repomd_files = md_handle.repodata | ||
| 115 | 86 | | |||
| 116 | output = [] | 87 | output = None | ||
| 88 | | ||||
| 89 | depck = Depcheck(arch, repomd_files, workdir=workdir) | ||||
| 90 | run_result = depck.check_rpm_deps(rpmlist) | ||||
| 91 | | ||||
| 92 | if report_format == 'updates': | ||||
| 93 | results = squash_results.squash_build_results_to_updates(run_result) | ||||
| 94 | output = squash_results.check.export_TAP(results) | ||||
| 95 | else: | ||||
| 96 | output = json.dumps(run_result, indent=4, separators=(',', ': ')) | ||||
| 97 | | ||||
| 98 | return output | ||||
| 99 | | ||||
| 100 | def depcheck_cli(): | ||||
| 101 | parser = argparse.ArgumentParser() | ||||
| 102 | parser.add_argument("rpm", nargs='+', help="RPM to be tested") | ||||
| 103 | parser.add_argument("-a", "--arch", choices=["i386", "x86_64", "armhfp"], help=""" | ||||
| 104 | Architecture to be tested; support arches are x86, x86_64, and armhfp. | ||||
| 105 | If omitted, defaults to current machine architecture. | ||||
| 106 | """) | ||||
| 107 | parser.add_argument("-r", "--repos", nargs='+', action='store', help=""" | ||||
| 108 | Repo to be tested against, in the form of reponame:repolocation where | ||||
| 109 | repolocation can be local (in the form /dir/of/repo) or | ||||
| 110 | remote (direct link or standard metalink), to be tested against. | ||||
| 111 | """) | ||||
| 112 | parser.add_argument("-f", "--format", choices=["builds", "updates"], help=""" | ||||
| 113 | Specify output format to override configuration | ||||
| 114 | """) | ||||
| 115 | | ||||
| 116 | | ||||
| 117 | args = parser.parse_args() | ||||
| 118 | # autodetect arch if none is passed in | ||||
| 119 | arch = args.arch | ||||
| 120 | if arch is None: | ||||
| 121 | arch = platform.machine() | ||||
| 122 | | ||||
| 123 | | ||||
| 117 | try: | 124 | try: | ||
| 118 | depck = depcheck.Depcheck(arch, repomd_files, workdir=workdir) | 125 | print run(args.rpm, arch, args.repos, args.format) | ||
| 119 | depck.check_rpm_deps(rpmlist) | | |||
| 120 | output = depck.get_output(output_format=args.format) | | |||
| 121 | except KeyboardInterrupt, e: | 126 | except KeyboardInterrupt, e: | ||
| 122 | print >> sys.stderr, ("\n\nExiting on user cancel.") | 127 | print >> sys.stderr, ("\n\nExiting on user cancel.") | ||
| 123 | sys.exit(1) | 128 | sys.exit(1) | ||
| 124 | 129 | | |||
| 125 | print output | 130 | | ||
| Show All 24 Lines | |||||
| 25 | # | 25 | # | ||
| 26 | # EPEL dep: python-argparse | 26 | # EPEL dep: python-argparse | ||
| 27 | 27 | | |||
| 28 | 28 | | |||
| 29 | import solv | 29 | import solv | ||
| 30 | import os | 30 | import os | ||
| 31 | import tempfile | 31 | import tempfile | ||
| 32 | 32 | | |||
| 33 | from .output import format_out | | |||
| 34 | from . import Pass, Fail | 33 | from . import Pass, Fail | ||
| 35 | 34 | | |||
| 35 | from libtaskotron.rpm_utils import rpmformat | ||||
| 36 | | ||||
| 36 | config_file = "/etc/depcheck.conf" | 37 | config_file = "/etc/depcheck.conf" | ||
| 37 | 38 | | |||
| 38 | # TODO: handle configuration file | 39 | # TODO: handle configuration file | ||
| 39 | 40 | | |||
| 40 | # FIXME: this will eventually be a util in libtaskotron | 41 | class DepcheckException(Exception): | ||
| 41 | def rpm_filename_to_envr(filename): | 42 | pass | ||
| 42 | return os.path.basename(filename)[:-4] | | |||
| 43 | 43 | | |||
| 44 | 44 | | |||
| 45 | class Depcheck(object): | 45 | class Depcheck(object): | ||
| 46 | def __init__(self, arch, repodata, workdir=None): | 46 | def __init__(self, arch, repodata, workdir=None): | ||
| 47 | """Depcheck uses existing repodata to check a set of rpm files for | 47 | """Depcheck uses existing repodata to check a set of rpm files for | ||
| 48 | depsolving issues. | 48 | depsolving issues. | ||
| 49 | 49 | | |||
| 50 | This class itself doesn't handle much other than checking rpms and all | 50 | This class itself doesn't handle much other than checking rpms and all | ||
| 51 | data prep needs to be handled externally | 51 | data prep needs to be handled externally | ||
| 52 | 52 | | |||
| 53 | :param arch: The repository arch to use for dependency solving | 53 | :param arch: The repository arch to use for dependency solving | ||
| 54 | :type arch: str | 54 | :type arch: str | ||
| 55 | :param repodata: local paths to downloaded and verified repodata | 55 | :param repodata: local paths to downloaded and verified repodata | ||
| 56 | :type repodata: dir of dir {'reponame': {'primary': primarygz_filename, 'filelists': filelists_filename}...} | 56 | :type repodata: dir of dir {'reponame': {'primary': primarygz_filename, 'filelists': filelists_filename}...} | ||
| 57 | :param workdir: The directory to use for depcheck work, a temp directory will be created if workdir is None | 57 | :param workdir: The directory to use for depcheck work, a temp directory will be created if workdir is None | ||
| 58 | :type workdir: str | 58 | :type workdir: str | ||
| 59 | """ | 59 | """ | ||
| 60 | 60 | | |||
| 61 | self.arch = arch | 61 | self.arch = arch | ||
| 62 | self.repos = repodata | 62 | self.repos = repodata | ||
| 63 | self.solvpool_object = None | 63 | self.solvpool_object = None | ||
| 64 | self.solvrepo_object = None | 64 | self.solvrepo_object = None | ||
| 65 | self.run_result = [] | | |||
| 66 | | ||||
| 67 | if workdir is None: | 65 | if workdir is None: | ||
| 68 | self.workdir = tempfile.mkdtemp('', 'depcheck-', '/var/tmp/') | 66 | self.workdir = tempfile.mkdtemp('', 'depcheck-', '/var/tmp/') | ||
| 69 | else: | 67 | else: | ||
| 70 | self.workdir = workdir | 68 | self.workdir = workdir | ||
| 71 | 69 | | |||
| 72 | @property | 70 | @property | ||
| 73 | def solvpool(self): | 71 | def solvpool(self): | ||
| 74 | if self.solvpool_object is None: | 72 | if self.solvpool_object is None: | ||
| ▲ Show 20 Lines • Show All 52 Lines • ▼ Show 20 Line(s) | 116 | else: | |||
| 127 | 125 | | |||
| 128 | return Fail, problem_strs | 126 | return Fail, problem_strs | ||
| 129 | 127 | | |||
| 130 | def check_rpm_deps(self, rpmfiles): | 128 | def check_rpm_deps(self, rpmfiles): | ||
| 131 | """Check dependencies of the given rpms against supplied repodata | 129 | """Check dependencies of the given rpms against supplied repodata | ||
| 132 | 130 | | |||
| 133 | :param rpmfiles: local absolute paths to rpms to check | 131 | :param rpmfiles: local absolute paths to rpms to check | ||
| 134 | :type rpmfiles: list of str | 132 | :type rpmfiles: list of str | ||
| 133 | :returns: dictionary of results {NVR: {'results': Pass/Fail, 'details': []}} | ||||
| 135 | """ | 134 | """ | ||
| 136 | 135 | | |||
| 137 | self._prepare_libsolv() | 136 | self._prepare_libsolv() | ||
| 138 | 137 | | |||
| 138 | run_result = {} | ||||
| 139 | | ||||
| 139 | for rpmfile in rpmfiles: | 140 | for rpmfile in rpmfiles: | ||
| 140 | print 'running depcheck for %s' % rpmfile | 141 | print 'running depcheck for %s' % rpmfile | ||
| 141 | result_state, result_details = self._check_rpm(rpmfile) | 142 | result_state, result_details = self._check_rpm(rpmfile) | ||
| 142 | 143 | | |||
| 143 | self.run_result.append({'envr': rpm_filename_to_envr(rpmfile), | 144 | nvr = self.rpm_filename_to_nvr(rpmfile) | ||
| 144 | 'result': result_state, | 145 | if nvr in run_result: | ||
| 145 | 'results': result_details}) | 146 | if result_state != run_result[nvr]['result']: | ||
| 147 | #TODO maybe do something saner, ideas welcomed | ||||
| 148 | raise DepcheckException("NVR %r has multiple conflicting results" % nvr) | ||||
| 149 | else: | ||||
| 150 | run_result[nvr]['details'].append(result_details) | ||||
| 146 | 151 | | |||
| 147 | def get_output(self, output_format='tap'): | 152 | else: | ||
| 148 | """Get formatted run result output. Will return empty if do_depcheck has | 153 | run_result[nvr] = {'result': result_state, | ||
| 149 | not yet been run | 154 | 'details': result_details} | ||
| 150 | 155 | | |||
| 151 | :param output_format: output format to use, can be one of 'tap' or 'json' | 156 | return run_result | ||
| 152 | :type output_format: str | | |||
| 153 | :returns: formatted run result | | |||
| 154 | """ | | |||
| 155 | 157 | | |||
| 156 | return format_out(self.run_result, output_format) | | |||
| 157 | 158 | | |||
| 159 | # FIXME: this will eventually be a util in libtaskotron | ||||
| 160 | def rpm_filename_to_nvr(self, filename): | ||||
| 161 | """ | ||||
| 162 | Transforms rpm filename to NVR. | ||||
| 163 | We assume the Fedora environment, where all the rpm filenames | ||||
| 164 | are in the NVRA.rpm format. | ||||
| 165 | | ||||
| 166 | :param filename: name of the rpm file | ||||
| 167 | :type filename: str | ||||
| 168 | :returns: NVR | ||||
| 169 | """ | ||||
| 170 | name = os.path.basename(filename)[:-len('.rpm')] | ||||
| 171 | return rpmformat(name, 'nvr') | ||||
| 158 | 172 | | |||
| 159 | def run(rpms, arch, release, repos, out_format): | | |||
| 160 | # for the moment, make the following assumptions: | | |||
| 161 | # - arch is specified and correct | | |||
| 162 | # - all repos are passed in the form of local paths | | |||
| 163 | # - output format is tap | | |||
| 164 | # - all rpms are passed in as a list - no dirs | | |||
| 165 | 173 | | |||
| 166 | # setup solv pool | | |||
| 167 | # collate results | | |||
| 168 | pass | | |||
| 1 | from libtaskotron.bodhi_utils import BodhiUtils | ||||
|---|---|---|---|---|---|
| 2 | from libtaskotron import check | ||||
| 3 | from . import Pass, Fail | ||||
| 4 | | ||||
| 5 | def squash_build_results_to_updates(run_result, bodhi = None): | ||||
| 6 | """ | ||||
| 7 | Converts the per-build results created by check_rpm_deps into per-update | ||||
| 8 | results. | ||||
| 9 | :param run_result: output of the check_rpm_deps method | ||||
| 10 | :type run_result: dict | ||||
| 11 | :returns: list of CheckDetail | ||||
| 12 | """ | ||||
| 13 | if bodhi is None: | ||||
| 14 | bodhi = BodhiUtils() | ||||
| 15 | | ||||
| 16 | pending_ok, pending_fail = bodhi.build2update(run_result.keys(), strict = True) | ||||
| 17 | | ||||
| 18 | updates = {} | ||||
| 19 | for _, update in pending_ok.items(): | ||||
| 20 | updates[update['title']] = update | ||||
| 21 | | ||||
| 22 | for _, update in pending_fail.items(): | ||||
| 23 | if update['title'] not in updates: | ||||
| 24 | updates[update['title']] = update | ||||
| 25 | | ||||
| 26 | updates_results = [] | ||||
| 27 | for update_title, update in updates.items(): | ||||
| 28 | cd = check.CheckDetail(update_title, check.ReportType.BODHI_UPDATE, outcome = 'PASSED') | ||||
| 29 | updates_results.append(cd) | ||||
| 30 | | ||||
| 31 | for build in update['builds']: | ||||
| 32 | # If build is in pending_fail either when it has no assigned | ||||
| 33 | # update (that can not happen, as we traverse builds of | ||||
| 34 | # a specific update), or when an update was incomplete | ||||
| 35 | # (e.g. missing some builds). | ||||
| 36 | # If an update is incomplete, all it's builds are put | ||||
| 37 | # into the pending_fail, so this should fail early, | ||||
| 38 | if build in pending_fail: | ||||
| 39 | cd.update_outcome('ABORTED') | ||||
| 40 | cd.store('Update was incomplete.') | ||||
| 41 | break | ||||
| 42 | | ||||
| 43 | if build not in pending_ok: | ||||
| 44 | cd.update_outcome('ABORTED') | ||||
| 45 | cd.store('Update contains build that was not tested.') | ||||
| 46 | break | ||||
| 47 | | ||||
| 48 | if run_result[build]['result'] is not Pass: | ||||
| 49 | cd.update_outcome('FAILED') | ||||
| 50 | cd.store('Build %s failed depcheck' % build) | ||||
| 51 | cd.output.extend(run_result[build]['details']) | ||||
| 52 | | ||||
| 53 | return updates_results | ||||
| 54 | | ||||
| 1 | # Configuration file for depcheck mk 2 | 1 | # Configuration file for depcheck mk 2 | ||
|---|---|---|---|---|---|
| 2 | 2 | | |||
| 3 | [configuration] | 3 | [configuration] | ||
| 4 | # output format; so far tap and json are available | 4 | # output format; build or update | ||
| 5 | format=tap | 5 | format=builds | ||
| 6 | 6 | | |||
| 7 | 7 | | |||
| 8 | [released] | 8 | [released] | ||
| 9 | metalink=https://mirrors.fedoraproject.org/metalink?repo=fedora-$release&arch=$arch | 9 | metalink=https://mirrors.fedoraproject.org/metalink?repo=fedora-$release&arch=$arch | ||
| 10 | 10 | | |||
| 11 | 11 | | |||
| 12 | [updates] | 12 | [updates] | ||
| 13 | metalink=https://mirrors.fedoraproject.org/metalink?repo=updates-released-f$release&arch=$arch | 13 | metalink=https://mirrors.fedoraproject.org/metalink?repo=updates-released-f$release&arch=$arch | ||
| 14 | 14 | | |||
| 1 | #!/usr/bin/python | 1 | #!/usr/bin/python | ||
|---|---|---|---|---|---|
| 2 | 2 | | |||
| 3 | import depcheck | 3 | import depcheck | ||
| 4 | from depcheck.depcheck import Depcheck | | |||
| 5 | from depcheck import dir_to_rpms, extract_named_repo | | |||
| 6 | from depcheck.metadata import DepcheckMetadata | | |||
| 7 | import os | | |||
| 8 | import tempfile | | |||
| 9 | | ||||
| 10 | def run(rpms, arch, repos, out_format="tap"): | | |||
| 11 | """Entry point for depcheck""" | | |||
| 12 | rpmlist = [] | | |||
| 13 | # handle directory args, expanding them to a list of rpm files with absolute | | |||
| 14 | # paths | | |||
| 15 | for filename in rpms: | | |||
| 16 | if os.path.isdir(filename): | | |||
| 17 | rpmlist.extend(dir_to_rpms(filename)) | | |||
| 18 | else: | | |||
| 19 | rpmlist.append(filename) | | |||
| 20 | | ||||
| 21 | # arm has some special case requirements for arch handling | | |||
| 22 | # Fixup for arm; the yum repo is labled as armhfp but the envr is armv7hl | | |||
| 23 | if arch == 'armv7l': | | |||
| 24 | arch = 'armhfp' | | |||
| 25 | | ||||
| 26 | # handle data formatting for repo metadata (list of dicts) | | |||
| 27 | repos = {} | | |||
| 28 | for repo in repos: | | |||
| 29 | namedrepo = extract_named_repo(repo) | | |||
| 30 | repos[namedrepo[0]] = {'arch': args.arch, 'path': namedrepo[1]} | | |||
| 31 | | ||||
| 32 | workdir = tempfile.mkdtemp('', 'depcheck-', '/var/tmp/') | | |||
| 33 | md_handle = DepcheckMetadata(repos, targetdir=workdir) | | |||
| 34 | | ||||
| 35 | repomd_files = md_handle.repodata | | |||
| 36 | | ||||
| 37 | output = [] | | |||
| 38 | | ||||
| 39 | depck = Depcheck(arch, repomd_files, workdir=workdir) | | |||
| 40 | depck.check_rpm_deps(rpmlist) | | |||
| 41 | output = depck.get_output(output_format=args.format) | | |||
| 42 | 4 | | |||
| 5 | def run(rpms, arch, repos, report_format="builds"): | ||||
| 6 | return depcheck.run(rpms, arch, repos, report_format) | ||||
| 43 | 7 | | |||
| 44 | if __name__ == '__main__': | 8 | if __name__ == '__main__': | ||
| 45 | depcheck.depcheck_cli() | 9 | depcheck.depcheck_cli() | ||
| Show All 10 Lines | |||||
| 11 | 11 | | |||
| 12 | import os | 12 | import os | ||
| 13 | import pytest | 13 | import pytest | ||
| 14 | import yaml | 14 | import yaml | ||
| 15 | 15 | | |||
| 16 | import depcheck | 16 | import depcheck | ||
| 17 | from depcheck.depcheck import Depcheck | 17 | from depcheck.depcheck import Depcheck | ||
| 18 | from depcheck import metadata | 18 | from depcheck import metadata | ||
| 19 | from depcheck import Pass | ||||
| 19 | from .depcheck_scenarios import yaml_to_repos | 20 | from .depcheck_scenarios import yaml_to_repos | ||
| 20 | 21 | | |||
| 22 | import pprint | ||||
| 21 | 23 | | |||
| 22 | def get_depcheck_scenarios(): | 24 | def get_depcheck_scenarios(): | ||
| 23 | """assuming that the depcheck_scenarios repo is checked out in the tests/ | 25 | """assuming that the depcheck_scenarios repo is checked out in the tests/ | ||
| 24 | directory, scan the directory structure for scenarios that should pass or | 26 | directory, scan the directory structure for scenarios that should pass or | ||
| 25 | fail. | 27 | fail. | ||
| 26 | 28 | | |||
| 27 | :returns: list of tuples of the form (should_pass, path_to_scenario_yaml) | 29 | :returns: list of tuples of the form (should_pass, path_to_scenario_yaml) | ||
| 28 | """ | 30 | """ | ||
| Show All 11 Lines | |||||
| 40 | return yamlfiles | 42 | return yamlfiles | ||
| 41 | 43 | | |||
| 42 | 44 | | |||
| 43 | @pytest.fixture(params=get_depcheck_scenarios()) | 45 | @pytest.fixture(params=get_depcheck_scenarios()) | ||
| 44 | def depcheck_scenario(request): | 46 | def depcheck_scenario(request): | ||
| 45 | return request.param | 47 | return request.param | ||
| 46 | 48 | | |||
| 47 | 49 | | |||
| 48 | def is_tap_output_pass(tap_output): | 50 | def is_output_pass(output): | ||
| 49 | for output in tap_output: | 51 | result = True | ||
| 50 | if output.startswith('not ok'): | 52 | for key, value in output.items(): | ||
| 51 | return False | 53 | result = result and (value['result'] == Pass) | ||
| 52 | return True | 54 | return result | ||
| 53 | | ||||
| 54 | 55 | | |||
| 55 | def read_yamldata(filename): | 56 | def read_yamldata(filename): | ||
| 56 | with open(filename, 'r') as filedata: | 57 | with open(filename, 'r') as filedata: | ||
| 57 | return yaml.load(filedata) | 58 | return yaml.load(filedata) | ||
| 58 | 59 | | |||
| 59 | 60 | | |||
| 60 | def test_depcheck_scenarios(depcheck_scenario, tmpdir): | 61 | def test_depcheck_scenarios(depcheck_scenario, tmpdir, monkeypatch): | ||
| 61 | # decode the input tuple for readability | 62 | # decode the input tuple for readability | ||
| 62 | scenario_pass = depcheck_scenario[0] | 63 | scenario_pass = depcheck_scenario[0] | ||
| 63 | scenario_path = depcheck_scenario[1] | 64 | scenario_path = depcheck_scenario[1] | ||
| 64 | 65 | | |||
| 65 | print "running scenario %s" % scenario_path | 66 | print "\n### Running scenario %s" % scenario_path | ||
| 66 | 67 | | |||
| 67 | # convert the yaml scenario to fake rpms and repos | 68 | # convert the yaml scenario to fake rpms and repos | ||
| 68 | scenario_data = read_yamldata(scenario_path) | 69 | scenario_data = read_yamldata(scenario_path) | ||
| 69 | current_repo, update_repo, dummy = \ | 70 | current_repo, update_repo, dummy = \ | ||
| 70 | yaml_to_repos.create_repos(scenario_data, outdir=str(tmpdir)) | 71 | yaml_to_repos.create_repos(scenario_data, outdir=str(tmpdir)) | ||
| 71 | 72 | | |||
| 72 | # get list of rpms | 73 | # get list of rpms | ||
| 73 | rpm_list = depcheck.dir_to_rpms(str(update_repo)) | 74 | rpm_list = depcheck.dir_to_rpms(str(update_repo)) | ||
| 74 | 75 | | |||
| 75 | # handle data formatting for repo metadata (list of dicts) | 76 | # handle data formatting for repo metadata (list of dicts) | ||
| 76 | repos = {'current': {'arch': 'x86_64', 'path': str(current_repo)}} | 77 | repos = {'current': {'arch': 'x86_64', 'path': str(current_repo)}} | ||
| 77 | md_handle = metadata.DepcheckMetadata(repos, | 78 | md_handle = metadata.DepcheckMetadata(repos, | ||
| 78 | targetdir=str(tmpdir)) | 79 | targetdir=str(tmpdir)) | ||
| 79 | repomd_files = md_handle.repodata | 80 | repomd_files = md_handle.repodata | ||
| 80 | 81 | | |||
| 81 | # run depcheck on the scenario's repos and rpms | 82 | # run depcheck on the scenario's repos and rpms | ||
| 82 | depck = Depcheck('x86_64', repomd_files) | 83 | depck = Depcheck('x86_64', repomd_files) | ||
| 83 | depck.check_rpm_deps(rpm_list) | 84 | run_result = depck.check_rpm_deps(rpm_list) | ||
| 84 | output = depck.get_output() | 85 | | ||
| 86 | pprint.pprint(run_result) | ||||
| 85 | 87 | | |||
| 86 | assert is_tap_output_pass(output) is scenario_pass | 88 | assert is_output_pass(run_result) is scenario_pass | ||
| 1 | import pytest | ||||
|---|---|---|---|---|---|
| 1 | from dingus import Dingus | 2 | from dingus import Dingus | ||
| 2 | import __builtin__ | 3 | import __builtin__ | ||
| 3 | 4 | | |||
| 4 | from depcheck import depcheck | 5 | from depcheck import depcheck | ||
| 6 | from depcheck import Pass, Fail | ||||
| 5 | 7 | | |||
| 6 | 8 | | |||
| 7 | class TestDepcheckLibsolvPrep(object): | 9 | class TestDepcheck(object): | ||
| 8 | def test_libsolv_setup_adds_repos(self, monkeypatch): | 10 | def test_libsolv_setup_adds_repos(self, monkeypatch): | ||
| 9 | ref_arch = 'x86_64' | 11 | ref_arch = 'x86_64' | ||
| 10 | ref_basepath = '/path/to/testing-repo/' | 12 | ref_basepath = '/path/to/testing-repo/' | ||
| 11 | ref_repomdfiles = {'reponame': {'primary': '%sprimary.xml.gz' % ref_basepath, | 13 | ref_repomdfiles = {'reponame': {'primary': '%sprimary.xml.gz' % ref_basepath, | ||
| 12 | 'filelists': '%sfilielists.xml.gz' % ref_basepath}} | 14 | 'filelists': '%sfilielists.xml.gz' % ref_basepath}} | ||
| 13 | 15 | | |||
| 14 | stub_solvpool = Dingus('solvpool') | 16 | stub_solvpool = Dingus('solvpool') | ||
| 15 | stub_solvrepo = Dingus('solvrepo') | 17 | stub_solvrepo = Dingus('solvrepo') | ||
| 16 | stub_open = Dingus('open') | 18 | stub_open = Dingus('open') | ||
| 17 | test_depcheck = depcheck.Depcheck(ref_arch, ref_repomdfiles) | 19 | test_depcheck = depcheck.Depcheck(ref_arch, ref_repomdfiles) | ||
| 18 | test_depcheck.solvpool_object = stub_solvpool | 20 | test_depcheck.solvpool_object = stub_solvpool | ||
| 19 | test_depcheck.solvrepo_object = stub_solvrepo | 21 | test_depcheck.solvrepo_object = stub_solvrepo | ||
| 20 | 22 | | |||
| 21 | monkeypatch.setattr(__builtin__, 'open', stub_open) | 23 | monkeypatch.setattr(__builtin__, 'open', stub_open) | ||
| 22 | 24 | | |||
| 23 | test_depcheck._prepare_libsolv() | 25 | test_depcheck._prepare_libsolv() | ||
| 24 | 26 | | |||
| 25 | assert len(stub_solvrepo.calls()) == 2 | 27 | assert len(stub_solvrepo.calls()) == 2 | ||
| 26 | 28 | | |||
| 29 | def test_check_rpm_deps_output(self, monkeypatch): | ||||
| 30 | """ | ||||
| 31 | Tests whether rpm_deps provides correct output for a given input. | ||||
| 32 | """ | ||||
| 33 | return_input = lambda x: x | ||||
| 34 | | ||||
| 35 | test_depcheck = depcheck.Depcheck(None, None, "fakedir") | ||||
| 36 | monkeypatch.setattr(test_depcheck, '_prepare_libsolv', Dingus()) | ||||
| 37 | monkeypatch.setattr(test_depcheck, 'rpm_filename_to_nvr', return_input) | ||||
| 38 | | ||||
| 39 | rpmfiles = ['rpm_1', 'rpm_2'] | ||||
| 40 | def fake_check_rpm(rpmfile): | ||||
| 41 | results = { | ||||
| 42 | rpmfiles[0]: (Pass, []), | ||||
| 43 | rpmfiles[1]: (Fail, ['message']), | ||||
| 44 | } | ||||
| 45 | return results.get(rpmfile, (Pass, [])) | ||||
| 46 | | ||||
| 47 | monkeypatch.setattr(test_depcheck, '_check_rpm', fake_check_rpm) | ||||
| 48 | | ||||
| 49 | outcome = test_depcheck.check_rpm_deps(rpmfiles) | ||||
| 50 | | ||||
| 51 | assert len(outcome) == 2 | ||||
| 52 | assert 'rpm_1' in outcome | ||||
| 53 | assert 'rpm_2' in outcome | ||||
| 54 | assert outcome['rpm_1']['result'] == Pass | ||||
| 55 | assert outcome['rpm_2']['result'] == Fail | ||||
| 56 | assert outcome['rpm_2']['details'] == ['message'] | ||||
| 57 | | ||||
| 58 | def test_check_rpm_deps_conflicting_results(self, monkeypatch): | ||||
| 59 | """ | ||||
| 60 | Checks whether rpm_deps raises Exceptions when conflicting | ||||
| 61 | results are provided for one NVR. | ||||
| 62 | """ | ||||
| 63 | return_input = lambda x: x | ||||
| 64 | | ||||
| 65 | test_depcheck = depcheck.Depcheck(None, None, "fakedir") | ||||
| 66 | monkeypatch.setattr(test_depcheck, '_prepare_libsolv', Dingus()) | ||||
| 67 | monkeypatch.setattr(test_depcheck, 'rpm_filename_to_nvr', return_input) | ||||
| 68 | | ||||
| 69 | self.tmp_result = Pass | ||||
| 70 | def fake_check_rpm(rpmfile): | ||||
| 71 | if self.tmp_result == Pass: | ||||
| 72 | self.tmp_result = Fail | ||||
| 73 | else: | ||||
| 74 | self.tmp_result = Pass | ||||
| 75 | return (self.tmp_result, []) | ||||
| 76 | | ||||
| 77 | monkeypatch.setattr(test_depcheck, '_check_rpm', fake_check_rpm) | ||||
| 78 | | ||||
| 79 | with pytest.raises(depcheck.DepcheckException): | ||||
| 80 | outcome = test_depcheck.check_rpm_deps(['rpm1', 'rpm1']) | ||||
| 81 | | ||||
| 1 | import pytest | ||||
|---|---|---|---|---|---|
| 2 | from dingus import Dingus | ||||
| 3 | import __builtin__ | ||||
| 4 | | ||||
| 5 | from depcheck.squash_results import squash_build_results_to_updates | ||||
| 6 | from depcheck import Pass, Fail | ||||
| 7 | | ||||
| 8 | | ||||
| 9 | class TestSquashResults(object): | ||||
| 10 | def test_squash_build_results_to_updates_all_ok(self): | ||||
| 11 | """ | ||||
| 12 | Checks whether _squash_build_results_to_updates provides correct output | ||||
| 13 | when all the builds in an update passed depchecking. | ||||
| 14 | """ | ||||
| 15 | run_results = { | ||||
| 16 | 'nvr1': {'result': Pass, 'details': []}, | ||||
| 17 | 'nvr2': {'result': Pass, 'details': []}, | ||||
| 18 | } | ||||
| 19 | update = {'title': 'update_name', 'builds': run_results.keys()} | ||||
| 20 | build_2_update = ( | ||||
| 21 | { | ||||
| 22 | 'nvr1': update, | ||||
| 23 | 'nvr2': update, | ||||
| 24 | }, {}) | ||||
| 25 | | ||||
| 26 | fake_bodhi = Dingus(build2update__returns = build_2_update) | ||||
| 27 | | ||||
| 28 | outcome = squash_build_results_to_updates(run_results, fake_bodhi) | ||||
| 29 | assert len(outcome) == 1 | ||||
| 30 | | ||||
| 31 | detail = outcome[0] | ||||
| 32 | assert detail.item == update['title'] | ||||
| 33 | assert detail.outcome == 'PASSED' | ||||
| 34 | | ||||
| 35 | def test_squash_build_results_to_updates_build_failed(self): | ||||
| 36 | """ | ||||
| 37 | Checks whether _squash_build_results_to_updates provides correct output | ||||
| 38 | when some of the builds in an update failed depchecking. | ||||
| 39 | """ | ||||
| 40 | run_results = { | ||||
| 41 | 'nvr1': {'result': Pass, 'details': []}, | ||||
| 42 | 'nvr2': {'result': Fail, 'details': ['### TEST @@@']}, | ||||
| 43 | } | ||||
| 44 | update = {'title': 'update_name', 'builds': run_results.keys()} | ||||
| 45 | build_2_update = ( | ||||
| 46 | { | ||||
| 47 | 'nvr1': update, | ||||
| 48 | 'nvr2': update, | ||||
| 49 | }, {}) | ||||
| 50 | | ||||
| 51 | fake_bodhi = Dingus(build2update__returns = build_2_update) | ||||
| 52 | | ||||
| 53 | outcome = squash_build_results_to_updates(run_results, fake_bodhi) | ||||
| 54 | assert len(outcome) == 1 | ||||
| 55 | | ||||
| 56 | detail = outcome[0] | ||||
| 57 | assert detail.item == update['title'] | ||||
| 58 | assert detail.outcome == 'FAILED' | ||||
| 59 | assert '### TEST @@@' in detail.output | ||||
| 60 | | ||||
| 61 | def test_squash_build_results_to_updates_incomplete_update(self): | ||||
| 62 | """ | ||||
| 63 | Checks whether _squash_build_results_to_updates provides correct output | ||||
| 64 | when some update is incomplete (i.e. present in the second return-value | ||||
| 65 | from the build2update method). | ||||
| 66 | """ | ||||
| 67 | run_results = { | ||||
| 68 | 'nvr1': {'result': Pass, 'details': []}, | ||||
| 69 | 'nvr2': {'result': Pass, 'details': []}, | ||||
| 70 | } | ||||
| 71 | update = {'title': 'update_name', 'builds': run_results.keys()} | ||||
| 72 | build_2_update = ({}, | ||||
| 73 | { | ||||
| 74 | 'nvr1': update, | ||||
| 75 | 'nvr2': update, | ||||
| 76 | }) | ||||
| 77 | | ||||
| 78 | fake_bodhi = Dingus(build2update__returns = build_2_update) | ||||
| 79 | | ||||
| 80 | outcome = squash_build_results_to_updates(run_results, fake_bodhi) | ||||
| 81 | assert len(outcome) == 1 | ||||
| 82 | | ||||
| 83 | detail = outcome[0] | ||||
| 84 | assert detail.item == update['title'] | ||||
| 85 | assert detail.outcome == 'ABORTED' | ||||
| 86 | assert 'Update was incomplete.' in detail.output | ||||
| 87 | | ||||
| 88 | def test_squash_build_results_to_updates_missing_build(self): | ||||
| 89 | """ | ||||
| 90 | Checks whether _squash_build_results_to_updates provides correct output | ||||
| 91 | when update is missing a result for one of its builds. | ||||
| 92 | """ | ||||
| 93 | run_results = { | ||||
| 94 | 'nvr1': {'result': Pass, 'details': []}, | ||||
| 95 | 'nvr2': {'result': Pass, 'details': []}, | ||||
| 96 | } | ||||
| 97 | update = {'title': 'update_name', 'builds': run_results.keys()} | ||||
| 98 | update['builds'].append('nvr3') | ||||
| 99 | build_2_update = ( | ||||
| 100 | { | ||||
| 101 | 'nvr1': update, | ||||
| 102 | 'nvr2': update, | ||||
| 103 | }, {}) | ||||
| 104 | | ||||
| 105 | fake_bodhi = Dingus(build2update__returns = build_2_update) | ||||
| 106 | | ||||
| 107 | outcome = squash_build_results_to_updates(run_results, fake_bodhi) | ||||
| 108 | assert len(outcome) == 1 | ||||
| 109 | | ||||
| 110 | detail = outcome[0] | ||||
| 111 | assert detail.item == update['title'] | ||||
| 112 | assert detail.outcome == 'ABORTED' | ||||
| 113 | assert 'Update contains build that was not tested.' in detail.output | ||||