Differential D132

TAP parsing should fail on multiple TAP headers
ClosedPublic
Actions

Authored by lbrabec on Jun 11 2014, 9:16 AM.

Details

Reviewers
kparal
Maniphest Tasks
T205: TAP validity check fails to recognize duplicated header
Commits
rLTRNea1e2f786471: TAP parsing should fail on multiple TAP headers
Summary

pytap13 0.1.0 (with multiple header check) is now in pypi, tests will pass.

Test Plan

$ py.test -F

Diff Detail

Repository
rLTRN libtaskotron
Branch
feature/T205
Lint
No Linters Available
Unit
No Unit Test Coverage
lbrabec retitled this revision from to TAP parsing should fail on multiple TAP headers.Jun 11 2014, 9:16 AM
lbrabec updated this object.
lbrabec edited the test plan for this revision. (Show Details)
lbrabec added a reviewer: kparal.
kparal added inline comments.Jun 11 2014, 11:01 AM
testing/test_check.py
425–451

Since the purpose is to test doubled TAP header, let's make the body of the TAP result as short as possible, so that we avoid unnecessary wall of text. The minimal functional TAP should be like this:

TAP Version 13
1..1
ok - $CHECKNAME for XXX
---
item: XXX
...
lbrabec updated this revision to Diff 386.Jun 11 2014, 11:25 AM
  • shorter test
lbrabec updated this revision to Diff 387.Jun 11 2014, 11:34 AM
  • correct version of pytap13 in requirements.txt
lbrabec updated this object.Jun 11 2014, 11:39 AM
lbrabec updated this revision to Diff 388.Jun 11 2014, 11:59 AM
  • correct version of pytap13 in spec file
kparal accepted this revision.Jun 11 2014, 12:00 PM

Seems OK.

This revision is now accepted and ready to land.Jun 11 2014, 12:00 PM
lbrabec added a comment.Jun 11 2014, 12:06 PM

Closed by commit ea1e2f7 (authored by @lbrabec).

lbrabec closed this revision.Jun 11 2014, 12:06 PM

Revision Contents

PathPackages
Mlibtaskotron.spec (4 lines)
Mrequirements.txt (2 lines)
Mtesting/test_check.py (19 lines)

Diff 388

View Options

libtaskotron.spec

Show All 13 Lines
14BuildArch: noarch 14​BuildArch: noarch
15 15​
16Requires: bodhi-client 16​Requires: bodhi-client
17Requires: koji 17​Requires: koji
18Requires: rpm-python 18​Requires: rpm-python
19Requires: pyOpenSSL 19​Requires: pyOpenSSL
20Requires: python-pycurl 20​Requires: python-pycurl
21Requires: python-urlgrabber 21​Requires: python-urlgrabber
22Requires: pytap13 22​Requires: pytap13 >= 0.1.0
23Requires: resultsdb_api 23​Requires: resultsdb_api
24Requires: python-bayeux 24​Requires: python-bayeux
25Requires: resultsdb_api 25​Requires: resultsdb_api
26Requires: python-hawkey >= 0.4.13-1 26​Requires: python-hawkey >= 0.4.13-1
27Requires: python-bunch 27​Requires: python-bunch
28Requires: python-fedora 28​Requires: python-fedora
29Requires: createrepo 29​Requires: createrepo
30Requires: mash 30​Requires: mash
31Requires: libtaskotron-config 31​Requires: libtaskotron-config
32BuildRequires: python-devel 32​BuildRequires: python-devel
33BuildRequires: python-setuptools 33​BuildRequires: python-setuptools
34BuildRequires: pytest 34​BuildRequires: pytest
35BuildRequires: python-bunch 35​BuildRequires: python-bunch
36BuildRequires: python-dingus 36​BuildRequires: python-dingus
37BuildRequires: python-urlgrabber 37​BuildRequires: python-urlgrabber
38BuildRequires: koji 38​BuildRequires: koji
39BuildRequires: pytap13 39​BuildRequires: pytap13 >= 0.1.0
40BuildRequires: python-bayeux 40​BuildRequires: python-bayeux
41BuildRequires: bodhi-client 41​BuildRequires: bodhi-client
42BuildRequires: resultsdb_api 42​BuildRequires: resultsdb_api
43BuildRequires: python-hawkey >= 0.4.13-1 43​BuildRequires: python-hawkey >= 0.4.13-1
44BuildRequires: python-fedora 44​BuildRequires: python-fedora
45 45​
46 46​
47%description 47​%description
▲ Show 20 Lines • Show All 83 Lines • Show Last 20 Lines
View Options

requirements.txt

1PyYAML==3.10 1​PyYAML==3.10
2dingus==0.3.4 2​dingus==0.3.4
3py>=1.4.18 3​py>=1.4.18
4pyaml==13.07.1 4​pyaml==13.07.1
5pytest>=2.4.2 5​pytest>=2.4.2
6pytest-cov>=1.6 6​pytest-cov>=1.6
7bayeux>=0.9 7​bayeux>=0.9
8yamlish>=0.12 8​yamlish>=0.12
9pytap13>=0.0.2 9​pytap13>=0.1.0
10resultsdb_api>=1.0.1 10​resultsdb_api>=1.0.1
11python-fedora>=0.3.33 11​python-fedora>=0.3.33
12bunch>=1.0.1 12​bunch>=1.0.1
View Options

testing/test_check.py

Show First 20 Lines • Show All 413 Lines • ▼ Show 20 Line(s)361ok - $CHECKNAME for Koji build xchat-0.5-1.fc20
414 def test_invalid_tap(self): 414​ def test_invalid_tap(self):
415 tap_output = """ 415​ tap_output = """
416TAP version 13 416​TAP version 13
417ok 2 foo 417​ok 2 foo
418ok 1 bar""" 418​ok 1 bar"""
419 with pytest.raises(exc.TaskotronValueError): 419​ with pytest.raises(exc.TaskotronValueError):
420 check.import_TAP(tap_output) 420​ check.import_TAP(tap_output)
421 421​
422​ def test_invalid_tap_multi_header(self):
423​ #simplified test data from phab/T205
424​ tap_output_multi_header = """
425​TAP version 13
426​1..1
427​ok - $CHECKNAME for XXX
428​---
429​item: XXX
430​...
431​TAP version 13
432​1..1
433​ok - $CHECKNAME for YYY
434​---
435​item: YYY
436​...
437​"""
438​ with pytest.raises(ValueError):
439​ check.import_TAP(tap_output_multi_header)
440​