add handlers to root logger instead of libtaskotron logger
ClosedPublic
Actions

Authored by garretraziel on Jun 6 2014, 8:27 AM.

Details

Reviewers

kparal
jskladan

Maniphest Tasks

T208: Upgradepath no longer shows debug messages when run with runtask

Commits

rLTRN2877a86cc040: add handlers to root logger instead of libtaskotron logger

Summary

Add stdout/file/syslog handler to root logger, not
libtaskotron logger. logger.init() is called only when we are
running runner.py, so we know that libtaskotron is the one that
should handle root logger.

Test Plan

Run upgradepath through runtask and observe that
output contains debug messages from upgradepath.

Diff Detail

Repository

rLTRN libtaskotron

Lint

Lint Skipped

Unit

Unit Tests Skipped

garretraziel retitled this revision from to add handlers to root logger instead of libtaskotron logger.Jun 6 2014, 8:27 AM

garretraziel updated this object.

garretraziel edited the test plan for this revision. (Show Details)

garretraziel added a reviewer: kparal.

Herald added a subscriber: tflink. · View Herald TranscriptJun 6 2014, 8:27 AM

garretraziel added a task: T208: Upgradepath no longer shows debug messages when run with runtask.Jun 6 2014, 8:28 AM

garretraziel added a reviewer: jskladan.Jun 9 2014, 11:21 AM

Yeah, I think this is the correct behavior - the main script should configure the root logger. When we run through runtask, we are the main script. And logger.init() is run only when started this way (but not when used as a library). Seems OK.

This revision is now accepted and ready to land.Jun 10 2014, 7:37 AM

Please add a parameter set_rootlogger=False to the init() method, and add set_rootlogger=True to the appropriate init call in runtask.
That is better than working with the assumption that init() is called just from runtask.

This revision now requires changes to proceed.Jun 10 2014, 11:15 AM

add set_rootlogger to logger.init

coolio!

This revision is now accepted and ready to land.Jun 10 2014, 2:02 PM

garretraziel requested a review of this revision.Jun 10 2014, 2:14 PM

kparal accepted this revision.Jun 10 2014, 2:15 PM

This revision is now accepted and ready to land.Jun 10 2014, 2:15 PM

stop this acking madness!

Closed by commit rLTRN2877a86cc040 (authored by Garret Raziel <boloomka@gmail.com>).

Revision Contents

			Path	Packages
M			libtaskotron/logger.py (13 lines)
M			libtaskotron/runner.py (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	365	9660b0a		Jun 6 2014, 8:27 AM	★	★
Diff 2	381	024d201	- add set_rootlogger to logger.init	Jun 10 2014, 1:44 PM	★	★
Diff 3	382	024d201	Commit rLTRN2877a86cc040bec1205b2ca7ad84d31b2606e106	Jun 10 2014, 2:22 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
ecd32a1a506a	937e2e917c15	b7e6f2b07743	Garret Raziel	add set_rootlogger to logger.init	Jun 10 2014, 1:37 PM
b7e6f2b07743	8318a5ac7d98	024d20150945	Garret Raziel	add handlers to root logger instead of libtaskotron logger (Show More…)	Jun 6 2014, 7:54 AM

Diff 382

View Options

libtaskotron/logger.py

Show All 30 Lines
31		31
32		32
33	def _log_excepthook(*exc_info):	33	def _log_excepthook(*exc_info):
34	'''Called when an exception is not caught'''	34	'''Called when an exception is not caught'''
35	log.critical(''.join(traceback.format_exception(*exc_info)))	35	log.critical(''.join(traceback.format_exception(*exc_info)))
36		36
37		37
38	def init(name='libtaskotron', level=logging.INFO, stream=True, syslog=False,	38	def init(name='libtaskotron', level=logging.INFO, stream=True, syslog=False,
39	filelog=None):	39	filelog=None, set_rootlogger=False):
40	"""Setup a logger	40	"""Setup a logger
41		41
42	:param str name: name of the logger, 'libtaskotron' is default	42	:param str name: name of the logger, 'libtaskotron' is default
43	:param level: level of logging	43	:param level: level of logging
44	:type level: level definitions from :mod:`logging`	44	:type level: level definitions from :mod:`logging`
45	:param bool stream: enables logging to stderr	45	:param bool stream: enables logging to stderr
46	:param bool syslog: enables logging to syslog	46	:param bool syslog: enables logging to syslog
47	:param str filelog: enables logging to a file, the value is the file name	47	:param str filelog: enables logging to a file, the value is the file name
		48	:param bool set_rootlogger: adds output handlers to root logger
48	"""	49	"""
49		50
50	# overwrite default except hook	51	# overwrite default except hook
51	sys.excepthook = _log_excepthook	52	sys.excepthook = _log_excepthook
52		53
53	logger = logging.getLogger(name)	54	logger = logging.getLogger(name)
		55	rootlogger = logging.getLogger()
54	logger.setLevel(level)	56	logger.setLevel(level)
55	logger.addHandler(logging.NullHandler())	57	logger.addHandler(logging.NullHandler())
56		58
57	fmt = '[%(name)s:%(filename)s:%(lineno)d] '\	59	fmt = '[%(name)s:%(filename)s:%(lineno)d] '\
58	'%(asctime)s %(levelname)-7s %(message)s'	60	'%(asctime)s %(levelname)-7s %(message)s'
59	datefmt = '%Y-%m-%d %H:%M:%S'	61	datefmt = '%Y-%m-%d %H:%M:%S'
60	formatter = logging.Formatter(fmt=fmt, datefmt=datefmt)	62	formatter = logging.Formatter(fmt=fmt, datefmt=datefmt)
61		63
62	if stream:	64	if stream:
63	stream_handler = logging.StreamHandler()	65	stream_handler = logging.StreamHandler()
64	stream_handler.setFormatter(formatter)	66	stream_handler.setFormatter(formatter)
65	logger.addHandler(stream_handler)	67	if set_rootlogger:
		68	rootlogger.addHandler(stream_handler)
66	logger.debug("doing stream logging")	69	logger.debug("doing stream logging")
67		70
68	if syslog:	71	if syslog:
69	syslog_handler = logging.handlers.SysLogHandler(address='/dev/log',	72	syslog_handler = logging.handlers.SysLogHandler(address='/dev/log',
70	facility=logging.handlers.SysLogHandler.LOG_LOCAL4)	73	facility=logging.handlers.SysLogHandler.LOG_LOCAL4)
71	syslog_handler.setFormatter(formatter)	74	syslog_handler.setFormatter(formatter)
72	logger.addHandler(syslog_handler)	75	if set_rootlogger:
		76	rootlogger.addHandler(syslog_handler)
73	logger.debug("doing syslog logging")	77	logger.debug("doing syslog logging")
74		78
75	if filelog:	79	if filelog:
76	file_handler = logging.handlers.RotatingFileHandler(filelog,	80	file_handler = logging.handlers.RotatingFileHandler(filelog,
77	maxBytes=500000, backupCount=5)	81	maxBytes=500000, backupCount=5)
78	file_handler.setFormatter(formatter)	82	file_handler.setFormatter(formatter)
79	logger.addHandler(file_handler)	83	if set_rootlogger:
		84	rootlogger.addHandler(file_handler)
80	logger.debug('doing file logging to %s', filelog)	85	logger.debug('doing file logging to %s', filelog)
81		86
82	return logger	87	return logger