Differential D123

task-rpmlint fix, export_TAP now accepts list
ClosedPublic
Actions

Authored by lbrabec on Jun 5 2014, 11:24 AM.

Details

Reviewers
kparal
Maniphest Tasks
T204: CheckDetail.export_TAP() should accept a list
Commits
Unknown Object (Diffusion Commit)
rRPMLINTc20111f18565: export_TAP now accepts list
Test Plan

with changes from D122
$ python runtask.py -i xchat-2.8.8-21.fc20 -t koji_build -a x86_64 ../task-rpmlint/rpmlint.yml

Diff Detail

Branch
feature/T204
Lint
No Linters Available
Unit
No Unit Test Coverage
lbrabec retitled this revision from to task-rpmlint fix, export_TAP now accepts list.Jun 5 2014, 11:24 AM
lbrabec updated this object.
lbrabec edited the test plan for this revision. (Show Details)
lbrabec added a reviewer: kparal.
kparal accepted this revision.Jun 5 2014, 1:07 PM
This revision is now accepted and ready to land.Jun 5 2014, 1:07 PM
lbrabec closed this revision.Jun 6 2014, 7:34 AM

Closed by hand, commit c20111f (authored by @lbrabec).

Revision Contents

Path
Mrun_rpmlint.py (2 lines)

Diff 356

View Options

run_rpmlint.py

Show All 19 Lines10 for rpmfile in rpmfiles:
20 else: 20​ else:
21 result = 'ABORTED' 21​ result = 'ABORTED'
22 22​
23 summary = 'RPMLINT %s for %s' % (result, rpmfile) 23​ summary = 'RPMLINT %s for %s' % (result, rpmfile)
24 detail = check.CheckDetail(rpmfile, check.ReportType.KOJI_BUILD, 24​ detail = check.CheckDetail(rpmfile, check.ReportType.KOJI_BUILD,
25 result, summary, output.split('\n')) 25​ result, summary, output.split('\n'))
26 results.append(detail) 26​ results.append(detail)
27 27​
28 tapdetails = check.export_TAP(*results) 28​ tapdetails = check.export_TAP(results)
29 return tapdetails 29​ return tapdetails
30 30​
31if __name__ == '__main__': 31​if __name__ == '__main__':
32 tapout = run() 32​ tapout = run()
33 33​
34 for result in tapout: 34​ for result in tapout:
35 print result 35​ print result
36 36​