Differential D1201

add UEFI for blivet tests
ClosedPublic
Actions

Authored by jsedlak on May 19 2017, 12:08 PM.

Details

Reviewers
adamwill
jskladan
Commits
rOPENQATESTS41144066683b: add UEFI for blivet tests
Summary

Change blivet test so that they could be also run on UEFI with GPT.

Test Plan

Run all blivet tests on uefi machine.

Diff Detail

Repository
rOPENQATESTS os-autoinst-distri-fedora
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jsedlak created this revision.May 19 2017, 12:08 PM
adamwill accepted this revision.May 19 2017, 6:35 PM

Looks fine. Out of interest - do you get a useful warning / error if you try to do an install *without* an ESP? If not, might be worth a bug report...

This revision is now accepted and ready to land.May 19 2017, 6:35 PM
jsedlak added a comment.May 22 2017, 7:24 AM
In D1201#22289, @adamwill wrote:

Looks fine. Out of interest - do you get a useful warning / error if you try to do an install *without* an ESP? If not, might be worth a bug report...

It does indeed show error about missing esp.

Closed by commit rOPENQATESTS41144066683b: add UEFI for blivet tests (authored by jsedlak). · Explain WhyMay 22 2017, 7:32 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 3049

View Options

needles/anaconda/partitioning/blivet/anaconda_blivet_part_fs_efi_filesystem-20170518.json

  • This file was added.
1​{
2​ "area": [
3​ {
4​ "xpos": 413,
5​ "ypos": 194,
6​ "width": 118,
7​ "height": 19,
8​ "type": "match"
9​ }
10​ ],
11​ "properties": [],
12​ "tags": [
13​ "anaconda_blivet_part_fs_efi_filesystem"
14​ ]
15​}
16​No newline at end of file
View Options

needles/anaconda/partitioning/blivet/anaconda_blivet_part_fs_efi_filesystem-20170518.png

  • This binary file was added.
View Options

templates

Show First 20 Lines • Show All 958 Lines • ▼ Show 20 Line(s)958 product => {
959 arch => "x86_64", 959​ arch => "x86_64",
960 distri => "fedora", 960​ distri => "fedora",
961 flavor => "universal", 961​ flavor => "universal",
962 version => "*", 962​ version => "*",
963 }, 963​ },
964 test_suite => { name => "install_blivet_lvmthin" }, 964​ test_suite => { name => "install_blivet_lvmthin" },
965 }, 965​ },
966 { 966​ {
967​ machine => { name => "uefi" },
968​ prio => 41,
969​ product => {
970​ arch => "x86_64",
971​ distri => "fedora",
972​ flavor => "universal",
973​ version => "*",
974​ },
975​ test_suite => { name => "install_blivet_ext3" },
976​ },
977​ {
978​ machine => { name => "uefi" },
979​ prio => 41,
980​ product => {
981​ arch => "x86_64",
982​ distri => "fedora",
983​ flavor => "universal",
984​ version => "*",
985​ },
986​ test_suite => { name => "install_blivet_btrfs" },
987​ },
988​ {
989​ machine => { name => "uefi" },
990​ prio => 51,
991​ product => {
992​ arch => "x86_64",
993​ distri => "fedora",
994​ flavor => "universal",
995​ version => "*",
996​ },
997​ test_suite => { name => "install_blivet_no_swap" },
998​ },
999​ {
1000​ machine => { name => "uefi" },
1001​ prio => 41,
1002​ product => {
1003​ arch => "x86_64",
1004​ distri => "fedora",
1005​ flavor => "universal",
1006​ version => "*",
1007​ },
1008​ test_suite => { name => "install_blivet_xfs" },
1009​ },
1010​ {
1011​ machine => { name => "uefi" },
1012​ prio => 41,
1013​ product => {
1014​ arch => "x86_64",
1015​ distri => "fedora",
1016​ flavor => "universal",
1017​ version => "*",
1018​ },
1019​ test_suite => { name => "install_blivet_software_raid" },
1020​ },
1021​ {
1022​ machine => { name => "uefi" },
1023​ prio => 41,
1024​ product => {
1025​ arch => "x86_64",
1026​ distri => "fedora",
1027​ flavor => "universal",
1028​ version => "*",
1029​ },
1030​ test_suite => { name => "install_blivet_lvmthin" },
1031​ },
1032​ {
967 machine => { name => "64bit" }, 1033​ machine => { name => "64bit" },
968 prio => 50, 1034​ prio => 50,
969 product => { 1035​ product => {
970 arch => "x86_64", 1036​ arch => "x86_64",
971 distri => "fedora", 1037​ distri => "fedora",
972 flavor => "universal", 1038​ flavor => "universal",
973 version => "*", 1039​ version => "*",
974 }, 1040​ },
▲ Show 20 Lines • Show All 1631 Lines • Show Last 20 Lines
View Options

tests/disk_custom_blivet_btrfs.pm

1use base "anacondatest"; 1​use base "anacondatest";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4use anaconda; 4​use anaconda;
5 5​
6sub run { 6​sub run {
7 my $self = shift; 7​ my $self = shift;
8 # Go to INSTALLATION DESTINATION and ensure the disk is selected. 8​ # Go to INSTALLATION DESTINATION and ensure the disk is selected.
9 # Because PARTITIONING starts with 'custom_blivet', this will select blivet-gui. 9​ # Because PARTITIONING starts with 'custom_blivet', this will select blivet-gui.
10 select_disks(); 10​ select_disks();
11 assert_and_click "anaconda_spoke_done"; 11​ assert_and_click "anaconda_spoke_done";
12 12​
13​ if (get_var("UEFI")) {
14​ # if we're running on UEFI, we need esp
15​ custom_blivet_add_partition(size => 512, mountpoint => '/boot/efi', filesystem => 'efi_filesystem');
16​ }
17​
13 custom_blivet_add_partition(size => 512, mountpoint => '/boot'); 18​ custom_blivet_add_partition(size => 512, mountpoint => '/boot');
14 custom_blivet_add_partition(size => 2048, filesystem => 'swap'); 19​ custom_blivet_add_partition(size => 2048, filesystem => 'swap');
15 20​
16 # selecting "btrfs" as filesystem creates new BTRFS drive in blivet-gui 21​ # selecting "btrfs" as filesystem creates new BTRFS drive in blivet-gui
17 custom_blivet_add_partition(filesystem => 'btrfs'); 22​ custom_blivet_add_partition(filesystem => 'btrfs');
18 # select newly created BTRFS drive (let's hope that BTRFS drive is only volume present) 23​ # select newly created BTRFS drive (let's hope that BTRFS drive is only volume present)
19 assert_and_click "anaconda_blivet_volumes_icon"; 24​ assert_and_click "anaconda_blivet_volumes_icon";
20 # add root partition to btrfs drive 25​ # add root partition to btrfs drive
Show All 17 Lines
View Options

tests/disk_custom_blivet_ext3.pm

1use base "anacondatest"; 1​use base "anacondatest";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4use anaconda; 4​use anaconda;
5 5​
6sub run { 6​sub run {
7 my $self = shift; 7​ my $self = shift;
8 # Go to INSTALLATION DESTINATION and ensure the disk is selected. 8​ # Go to INSTALLATION DESTINATION and ensure the disk is selected.
9 # Because PARTITIONING starts with 'custom_blivet', this will select blivet-gui. 9​ # Because PARTITIONING starts with 'custom_blivet', this will select blivet-gui.
10 select_disks(); 10​ select_disks();
11 assert_and_click "anaconda_spoke_done"; 11​ assert_and_click "anaconda_spoke_done";
12 12​
13​ if (get_var("UEFI")) {
14​ # if we're running on UEFI, we need esp
15​ custom_blivet_add_partition(size => 512, mountpoint => '/boot/efi', filesystem => 'efi_filesystem');
16​ }
17​
13 custom_blivet_add_partition(size => 512, mountpoint => '/boot'); 18​ custom_blivet_add_partition(size => 512, mountpoint => '/boot');
14 custom_blivet_add_partition(size => 2048, filesystem => 'swap'); 19​ custom_blivet_add_partition(size => 2048, filesystem => 'swap');
15 custom_blivet_add_partition(filesystem => 'ext3', mountpoint => '/'); 20​ custom_blivet_add_partition(filesystem => 'ext3', mountpoint => '/');
16 21​
17 assert_and_click "anaconda_spoke_done"; 22​ assert_and_click "anaconda_spoke_done";
18 assert_and_click "anaconda_part_accept_changes"; 23​ assert_and_click "anaconda_part_accept_changes";
19 24​
20 # Anaconda hub 25​ # Anaconda hub
Show All 11 Lines
View Options

tests/disk_custom_blivet_lvmthin.pm

1use base "anacondatest"; 1​use base "anacondatest";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4use anaconda; 4​use anaconda;
5 5​
6sub run { 6​sub run {
7 my $self = shift; 7​ my $self = shift;
8 # Go to INSTALLATION DESTINATION and ensure the disk is selected. 8​ # Go to INSTALLATION DESTINATION and ensure the disk is selected.
9 # Because PARTITIONING starts with 'custom_blivet', this will select blivet-gui. 9​ # Because PARTITIONING starts with 'custom_blivet', this will select blivet-gui.
10 select_disks(); 10​ select_disks();
11 assert_and_click "anaconda_spoke_done"; 11​ assert_and_click "anaconda_spoke_done";
12 12​
13​ if (get_var("UEFI")) {
14​ # if we're running on UEFI, we need esp
15​ custom_blivet_add_partition(size => 512, mountpoint => '/boot/efi', filesystem => 'efi_filesystem');
16​ }
17​
13 custom_blivet_add_partition(size => 512, mountpoint => '/boot'); 18​ custom_blivet_add_partition(size => 512, mountpoint => '/boot');
14 # add new LVM device 19​ # add new LVM device
15 custom_blivet_add_partition(devicetype => 'lvm'); 20​ custom_blivet_add_partition(devicetype => 'lvm');
16 # select newly created LVM device for adding new partition 21​ # select newly created LVM device for adding new partition
17 assert_and_click "anaconda_blivet_volumes_icon"; 22​ assert_and_click "anaconda_blivet_volumes_icon";
18 custom_blivet_add_partition(size => 2048, filesystem => 'swap'); 23​ custom_blivet_add_partition(size => 2048, filesystem => 'swap');
19 # add lvmthinpool 24​ # add lvmthinpool
20 custom_blivet_add_partition(devicetype => 'lvmthin'); 25​ custom_blivet_add_partition(devicetype => 'lvmthin');
Show All 19 Lines
View Options

tests/disk_custom_blivet_no_swap.pm

1use base "anacondatest"; 1​use base "anacondatest";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4use anaconda; 4​use anaconda;
5 5​
6sub run { 6​sub run {
7 my $self = shift; 7​ my $self = shift;
8 # Go to INSTALLATION DESTINATION and ensure the disk is selected. 8​ # Go to INSTALLATION DESTINATION and ensure the disk is selected.
9 # Because PARTITIONING starts with 'custom_blivet', this will select blivet-gui. 9​ # Because PARTITIONING starts with 'custom_blivet', this will select blivet-gui.
10 select_disks(); 10​ select_disks();
11 assert_and_click "anaconda_spoke_done"; 11​ assert_and_click "anaconda_spoke_done";
12 12​
13​ if (get_var("UEFI")) {
14​ # if we're running on UEFI, we need esp
15​ custom_blivet_add_partition(size => 512, mountpoint => '/boot/efi', filesystem => 'efi_filesystem');
16​ }
17​
13 custom_blivet_add_partition(size => 512, mountpoint => '/boot'); 18​ custom_blivet_add_partition(size => 512, mountpoint => '/boot');
14 custom_blivet_add_partition(mountpoint => '/'); 19​ custom_blivet_add_partition(mountpoint => '/');
15 20​
16 assert_and_click "anaconda_spoke_done"; 21​ assert_and_click "anaconda_spoke_done";
17 # click "done" second time, because it warns us about missing swap partition 22​ # click "done" second time, because it warns us about missing swap partition
18 assert_and_click "anaconda_spoke_done"; 23​ assert_and_click "anaconda_spoke_done";
19 assert_and_click "anaconda_part_accept_changes"; 24​ assert_and_click "anaconda_part_accept_changes";
20 25​
Show All 12 Lines
View Options

tests/disk_custom_blivet_software_raid.pm

1use base "anacondatest"; 1​use base "anacondatest";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4use anaconda; 4​use anaconda;
5 5​
6sub run { 6​sub run {
7 my $self = shift; 7​ my $self = shift;
8 # Go to INSTALLATION DESTINATION and ensure two disks are selected. 8​ # Go to INSTALLATION DESTINATION and ensure two disks are selected.
9 # Because PARTITIONING starts with 'custom_blivet', this will select blivet-gui. 9​ # Because PARTITIONING starts with 'custom_blivet', this will select blivet-gui.
10 select_disks(disks=>2); 10​ select_disks(disks=>2);
11 assert_and_click "anaconda_spoke_done"; 11​ assert_and_click "anaconda_spoke_done";
12 12​
13​ if (get_var("UEFI")) {
14​ # if we're running on UEFI, we need esp
15​ custom_blivet_add_partition(size => 512, mountpoint => '/boot/efi', filesystem => 'efi_filesystem');
16​ }
17​
13 custom_blivet_add_partition(size => 512, mountpoint => '/boot'); 18​ custom_blivet_add_partition(size => 512, mountpoint => '/boot');
14 custom_blivet_add_partition(size => 2048, filesystem => 'swap'); 19​ custom_blivet_add_partition(size => 2048, filesystem => 'swap');
15 custom_blivet_add_partition(raid1 => 1, mountpoint => '/'); 20​ custom_blivet_add_partition(raid1 => 1, mountpoint => '/');
16 21​
17 assert_and_click "anaconda_spoke_done"; 22​ assert_and_click "anaconda_spoke_done";
18 assert_and_click "anaconda_part_accept_changes"; 23​ assert_and_click "anaconda_part_accept_changes";
19 24​
20 # Anaconda hub 25​ # Anaconda hub
Show All 11 Lines
View Options

tests/disk_custom_blivet_xfs.pm

1use base "anacondatest"; 1​use base "anacondatest";
2use strict; 2​use strict;
3use testapi; 3​use testapi;
4use anaconda; 4​use anaconda;
5 5​
6sub run { 6​sub run {
7 my $self = shift; 7​ my $self = shift;
8 # Go to INSTALLATION DESTINATION and ensure the disk is selected. 8​ # Go to INSTALLATION DESTINATION and ensure the disk is selected.
9 # Because PARTITIONING starts with 'custom_blivet', this will select blivet-gui. 9​ # Because PARTITIONING starts with 'custom_blivet', this will select blivet-gui.
10 select_disks(); 10​ select_disks();
11 assert_and_click "anaconda_spoke_done"; 11​ assert_and_click "anaconda_spoke_done";
12 12​
13​ if (get_var("UEFI")) {
14​ # if we're running on UEFI, we need esp
15​ custom_blivet_add_partition(size => 512, mountpoint => '/boot/efi', filesystem => 'efi_filesystem');
16​ }
17​
13 custom_blivet_add_partition(size => 512, mountpoint => '/boot'); 18​ custom_blivet_add_partition(size => 512, mountpoint => '/boot');
14 custom_blivet_add_partition(size => 2048, filesystem => 'swap'); 19​ custom_blivet_add_partition(size => 2048, filesystem => 'swap');
15 custom_blivet_add_partition(filesystem => 'xfs', mountpoint => '/'); 20​ custom_blivet_add_partition(filesystem => 'xfs', mountpoint => '/');
16 21​
17 assert_and_click "anaconda_spoke_done"; 22​ assert_and_click "anaconda_spoke_done";
18 assert_and_click "anaconda_part_accept_changes"; 23​ assert_and_click "anaconda_part_accept_changes";
19 24​
20 # Anaconda hub 25​ # Anaconda hub
Show All 11 Lines